github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect OOM score description in kubelet/qos

Browse Source 
The multiplication factor is 10 and not 100 as clear from some other comments in the same file. Also mentioned at https://lwn.net/Articles/391222/.
This commit is contained in:
apeeyush
2015-11-11 19:12:18 +05:30
parent 0ee52eb0c8
commit ae259748ef
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/kubelet/qos/memory_policy.go
View File

@@ -44,7 +44,7 @@ func isMemoryGuaranteed(container *api.Container) bool {
// GetContainerOOMAdjust returns the amount by which the OOM score of all processes in the // GetContainerOOMAdjust returns the amount by which the OOM score of all processes in the
// container should be adjusted. The OOM score of a process is the percentage of memory it consumes // container should be adjusted. The OOM score of a process is the percentage of memory it consumes
// multiplied by 100 (barring exceptional cases) + a configurable quantity which is between -1000 // multiplied by 10 (barring exceptional cases) + a configurable quantity which is between -1000
// and 1000. Containers with higher OOM scores are killed if the system runs out of memory. // and 1000. Containers with higher OOM scores are killed if the system runs out of memory.
// See https://lwn.net/Articles/391222/ for more information. // See https://lwn.net/Articles/391222/ for more information.
func GetContainerOOMScoreAdjust(container *api.Container, memoryCapacity int64) int { func GetContainerOOMScoreAdjust(container *api.Container, memoryCapacity int64) int {