github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #83713 from RainbowMango/pr_refactor_kubelet_collector_test

Browse Source 
Refactor kubelet collector test
This commit is contained in:
Kubernetes Prow Robot 2019-10-24 22:55:38 -07:00 committed by GitHub
commit aebc8eae9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/kubelet/metrics/collectors/BUILD
View File

@ -30,7 +30,6 @@ go_test(
"//pkg/kubelet/server/stats/testing:go_default_library", "//pkg/kubelet/server/stats/testing:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/component-base/metrics/testutil:go_default_library", "//staging/src/k8s.io/component-base/metrics/testutil:go_default_library",
"//vendor/github.com/prometheus/client_golang/prometheus:go_default_library",
], ],
) )

10
pkg/kubelet/metrics/collectors/log_metrics_test.go
View File

@ -20,25 +20,19 @@ import (
"strings" "strings"
"testing" "testing"
"github.com/prometheus/client_golang/prometheus"
"k8s.io/component-base/metrics/testutil" "k8s.io/component-base/metrics/testutil"
statsapi "k8s.io/kubernetes/pkg/kubelet/apis/stats/v1alpha1" statsapi "k8s.io/kubernetes/pkg/kubelet/apis/stats/v1alpha1"
) )
func TestNoMetricsCollected(t *testing.T) { func TestNoMetricsCollected(t *testing.T) {
ch := make(chan prometheus.Metric)
collector := &logMetricsCollector{ collector := &logMetricsCollector{
podStats: func() ([]statsapi.PodStats, error) { podStats: func() ([]statsapi.PodStats, error) {
return []statsapi.PodStats{}, nil return []statsapi.PodStats{}, nil
}, },
} }
collector.Collect(ch)
num := len(ch) if err := testutil.CollectAndCompare(collector, strings.NewReader(""), ""); err != nil {
if num != 0 { t.Fatal(err)
t.Fatalf("Channel expected to be empty, but received %d", num)
} }
} }