github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Service names conform to RFC 1035

Browse Source
This commit is contained in:
Michael Fraenkel
2016-07-24 13:01:38 -04:00
parent 31da82df52
commit b1e7e6cf46
9 changed files with 43 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/util/validation/validation_test.go
View File

@@ -86,13 +86,13 @@ func TestIsDNS1123Subdomain(t *testing.T) {
}
}
func TestIsDNS952Label(t *testing.T) {
func TestIsDNS1035Label(t *testing.T) {
goodValues := []string{
"a", "ab", "abc", "a1", "a-1", "a--1--2--b",
strings.Repeat("a", 24),
strings.Repeat("a", 63),
}
for _, val := range goodValues {
if msgs := IsDNS952Label(val); len(msgs) != 0 {
if msgs := IsDNS1035Label(val); len(msgs) != 0 {
t.Errorf("expected true for '%s': %v", val, msgs)
}
}
@@ -104,10 +104,10 @@ func TestIsDNS952Label(t *testing.T) {
"_", "a_", "_a", "a_b", "1_", "_1", "1_2",
".", "a.", ".a", "a.b", "1.", ".1", "1.2",
" ", "a ", " a", "a b", "1 ", " 1", "1 2",
strings.Repeat("a", 25),
strings.Repeat("a", 64),
}
for _, val := range badValues {
if msgs := IsDNS952Label(val); len(msgs) == 0 {
if msgs := IsDNS1035Label(val); len(msgs) == 0 {
t.Errorf("expected false for '%s'", val)
}
}