github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix kubectl help command

Browse Source 
PR 48d47b1027 broke `kubectl help` command due
to wrong check `help for help cmd` .

Fixed issue #29736
This commit is contained in:
Andrey Kurilin
2016-07-28 17:47:03 +03:00
parent 1d8c15ba14
commit b2f8ee4f12
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/kubectl/cmd/help.go
View File

@@ -41,7 +41,7 @@ func NewCmdHelp(f *cmdutil.Factory, out io.Writer) *cobra.Command {
} }
func RunHelp(cmd *cobra.Command, args []string) { func RunHelp(cmd *cobra.Command, args []string) {
foundCmd, a, err := cmd.Root().Find(args) foundCmd, _, err := cmd.Root().Find(args)
// NOTE(andreykurilin): actually, I did not find any cases when foundCmd can be nil, // NOTE(andreykurilin): actually, I did not find any cases when foundCmd can be nil,
// but let's make this check since it is included in original code of initHelpCmd // but let's make this check since it is included in original code of initHelpCmd
@@ -69,10 +69,11 @@ func RunHelp(cmd *cobra.Command, args []string) {
// if nothing is found, just print usage // if nothing is found, just print usage
cmd.Root().Usage() cmd.Root().Usage()
} }
} else if len(a) == 0 {
// help message for help command :)
cmd.Root().Usage()
} else { } else {
if len(args) == 0 {
// help message for help command :)
foundCmd = cmd
}
helpFunc := foundCmd.HelpFunc() helpFunc := foundCmd.HelpFunc()
helpFunc(foundCmd, args) helpFunc(foundCmd, args)
} }