github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #17862 from feihujiang/ensureHeadlessServicePortEqualToTargetPort

Browse Source 
Auto commit by PR queue bot
This commit is contained in:
k8s-merge-robot
2015-12-02 03:35:36 -08:00
parent b69018eab2 81b095ee52
commit b3846ea748
2 changed files with 37 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
pkg/api/validation/validation_test.go
View File

@@ -1881,6 +1881,33 @@ func TestValidateService(t *testing.T) {
},
numErrs: 1,
},
{
name: "valid port headless",
tweakSvc: func(s *api.Service) {
s.Spec.Ports[0].Port = 11722
s.Spec.Ports[0].TargetPort = intstr.FromInt(11722)
s.Spec.ClusterIP = api.ClusterIPNone
},
numErrs: 0,
},
{
name: "invalid port headless",
tweakSvc: func(s *api.Service) {
s.Spec.Ports[0].Port = 11722
s.Spec.Ports[0].TargetPort = intstr.FromInt(11721)
s.Spec.ClusterIP = api.ClusterIPNone
},
numErrs: 1,
},
{
name: "invalid port headless",
tweakSvc: func(s *api.Service) {
s.Spec.Ports[0].Port = 11722
s.Spec.Ports[0].TargetPort = intstr.FromString("target")
s.Spec.ClusterIP = api.ClusterIPNone
},
numErrs: 1,
},
{
name: "invalid publicIPs localhost",
tweakSvc: func(s *api.Service) {