github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid data races in unit tests

Browse Source
This commit is contained in:
Jordan Liggitt
2018-03-30 17:19:40 -04:00
parent 8f7eb4e6ac
commit b562263427
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/kubelet/cm/cpumanager/state/state_file_test.go
View File

@@ -18,7 +18,6 @@ package state
import ( import (
"bytes" "bytes"
"flag"
"fmt" "fmt"
"io" "io"
"io/ioutil" "io/ioutil"
@@ -69,9 +68,6 @@ func stderrCapture(t *testing.T, f func() State) (bytes.Buffer, State) {
} }
func TestFileStateTryRestore(t *testing.T) { func TestFileStateTryRestore(t *testing.T) {
flag.Set("alsologtostderr", "true")
flag.Parse()
testCases := []struct { testCases := []struct {
description string description string
stateFileContent string stateFileContent string
@@ -292,9 +288,6 @@ func TestFileStateTryRestorePanic(t *testing.T) {
} }
func TestUpdateStateFile(t *testing.T) { func TestUpdateStateFile(t *testing.T) {
flag.Set("alsologtostderr", "true")
flag.Parse()
testCases := []struct { testCases := []struct {
description string description string
expErr string expErr string

2
pkg/kubelet/cm/devicemanager/manager_test.go
View File

@@ -17,7 +17,6 @@ limitations under the License.
package devicemanager package devicemanager
import ( import (
"flag"
"fmt" "fmt"
"io/ioutil" "io/ioutil"
"os" "os"
@@ -546,7 +545,6 @@ type TestResource struct {
} }
func TestPodContainerDeviceAllocation(t *testing.T) { func TestPodContainerDeviceAllocation(t *testing.T) {
flag.Set("alsologtostderr", fmt.Sprintf("%t", true))
res1 := TestResource{ res1 := TestResource{
resourceName: "domain1.com/resource1", resourceName: "domain1.com/resource1",
resourceQuantity: *resource.NewQuantity(int64(2), resource.DecimalSI), resourceQuantity: *resource.NewQuantity(int64(2), resource.DecimalSI),