github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add review comments in the APIs

Browse Source
This commit is contained in:
Xing Yang
2019-03-01 20:11:48 -08:00
parent 743d3a26e9
commit ba4ccfa8b1
7 changed files with 59 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
pkg/apis/storage/v1beta1/defaults_test.go
View File

@@ -65,12 +65,19 @@ func TestSetDefaultAttachRequired(t *testing.T) {
driver := &storagev1beta1.CSIDriver{}
// field should be defaulted
defaultMode := true
defaultAttach := true
defaultPodInfo := false
output := roundTrip(t, runtime.Object(driver)).(*storagev1beta1.CSIDriver)
outMode := output.Spec.AttachRequired
if outMode == nil {
t.Errorf("Expected AttachRequired to be defaulted to: %+v, got: nil", defaultMode)
} else if *outMode != defaultMode {
t.Errorf("Expected AttachRequired to be defaulted to: %+v, got: %+v", defaultMode, outMode)
outAttach := output.Spec.AttachRequired
if outAttach == nil {
t.Errorf("Expected AttachRequired to be defaulted to: %+v, got: nil", defaultAttach)
} else if *outAttach != defaultAttach {
t.Errorf("Expected AttachRequired to be defaulted to: %+v, got: %+v", defaultAttach, outAttach)
}
outPodInfo := output.Spec.PodInfoOnMount
if outPodInfo == nil {
t.Errorf("Expected PodInfoOnMount to be defaulted to: %+v, got: nil", defaultPodInfo)
} else if *outPodInfo != defaultPodInfo {
t.Errorf("Expected PodInfoOnMount to be defaulted to: %+v, got: %+v", defaultPodInfo, outPodInfo)
}
}