github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

httptest.NewTLSServer is ~0.2s of setup per test

Browse Source 
We're not exercising anything TLS related in client and request,
set these back to NewServer.  Should add a new TLS end-to-end
test for hack/test-cmd.sh with real (test) certs.
This commit is contained in:
Clayton Coleman
2014-08-05 00:59:42 -04:00
parent 83aeae7658
commit babb7528ce
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/client/client_test.go
View File

@@ -320,7 +320,7 @@ func (c *testClient) Setup() *testClient {
if responseBody := body(c.Response.Body, c.Response.RawBody); responseBody != nil {
c.handler.ResponseBody = *responseBody
}
c.server = httptest.NewTLSServer(c.handler)
c.server = httptest.NewServer(c.handler)
if c.Client == nil {
c.Client = New("", nil)
}
@@ -430,7 +430,7 @@ func TestDoRequestAccepted(t *testing.T) {
ResponseBody: string(expectedBody),
T: t,
}
testServer := httptest.NewTLSServer(&fakeHandler)
testServer := httptest.NewServer(&fakeHandler)
request, _ := http.NewRequest("GET", testServer.URL+"/foo/bar", nil)
auth := AuthInfo{User: "user", Password: "pass"}
c := New(testServer.URL, &auth)
@@ -464,7 +464,7 @@ func TestDoRequestAcceptedSuccess(t *testing.T) {
ResponseBody: string(expectedBody),
T: t,
}
testServer := httptest.NewTLSServer(&fakeHandler)
testServer := httptest.NewServer(&fakeHandler)
request, _ := http.NewRequest("GET", testServer.URL+"/foo/bar", nil)
auth := AuthInfo{User: "user", Password: "pass"}
c := New(testServer.URL, &auth)