github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix null lastTransitionTime in pod condition when setting scheduling gate

Browse Source
This commit is contained in:
lianghao208
2024-01-08 12:24:09 +08:00
parent 60dcf7fd8d
commit bbcb4ee690
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/registry/core/pod/strategy.go
View File

@@ -752,7 +752,7 @@ func applyWaitingForSchedulingGatesCondition(pod *api.Pod) {
} }
} }
pod.Status.Conditions = append(pod.Status.Conditions, api.PodCondition{ podutil.UpdatePodCondition(&pod.Status, &api.PodCondition{
Type: api.PodScheduled, Type: api.PodScheduled,
Status: api.ConditionFalse, Status: api.ConditionFalse,
Reason: apiv1.PodReasonSchedulingGated, Reason: apiv1.PodReasonSchedulingGated,

5
pkg/registry/core/pod/strategy_test.go
View File

@@ -371,7 +371,10 @@ func TestWaitingForGatesCondition(t *testing.T) {
} }
} }
if diff := cmp.Diff(tt.want, got); diff != "" { if got.LastTransitionTime.IsZero() && got.Type != "" {
t.Errorf("unexpected empty LastTransitionTime in condition")
}
if diff := cmp.Diff(tt.want, got, cmpopts.IgnoreFields(api.PodCondition{}, "LastTransitionTime")); diff != "" {
t.Errorf("unexpected field errors (-want, +got):\n%s", diff) t.Errorf("unexpected field errors (-want, +got):\n%s", diff)
} }
}) })