github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #123488 from dims/skip-autoscaling-tests-when-we-hit-rate-limits

Browse Source 
Skip autoscaling tests when we hit rate limits
This commit is contained in:
Kubernetes Prow Robot
2024-02-25 06:40:24 -08:00
committed by GitHub
parent 237d3dfda7 d7735f32d0
commit be4b7de022
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test/e2e/autoscaling/custom_metrics_stackdriver_autoscaling.go
View File

@@ -420,6 +420,9 @@ func (tc *CustomMetricTestCase) Run(ctx context.Context) {
// Set up a cluster: create a custom metric and set up k8s-sd adapter // Set up a cluster: create a custom metric and set up k8s-sd adapter
err = monitoring.CreateDescriptors(gcmService, projectID) err = monitoring.CreateDescriptors(gcmService, projectID)
if err != nil { if err != nil {
if strings.Contains(err.Error(), "Request throttled") {
e2eskipper.Skipf("Skipping...hitting rate limits on creating and updating metrics/labels")
}
framework.Failf("Failed to create metric descriptor: %v", err) framework.Failf("Failed to create metric descriptor: %v", err)
} }
defer monitoring.CleanupDescriptors(gcmService, projectID) defer monitoring.CleanupDescriptors(gcmService, projectID)

7
test/e2e/instrumentation/monitoring/custom_metrics_stackdriver.go
View File

@@ -18,6 +18,7 @@ package monitoring
import ( import (
"context" "context"
"strings"
"time" "time"
gcm "google.golang.org/api/monitoring/v3" gcm "google.golang.org/api/monitoring/v3"
@@ -112,6 +113,9 @@ func testCustomMetrics(ctx context.Context, f *framework.Framework, kubeClient c
// Set up a cluster: create a custom metric and set up k8s-sd adapter // Set up a cluster: create a custom metric and set up k8s-sd adapter
err = CreateDescriptors(gcmService, projectID) err = CreateDescriptors(gcmService, projectID)
if err != nil { if err != nil {
if strings.Contains(err.Error(), "Request throttled") {
e2eskipper.Skipf("Skipping...hitting rate limits on creating and updating metrics/labels")
}
framework.Failf("Failed to create metric descriptor: %s", err) framework.Failf("Failed to create metric descriptor: %s", err)
} }
ginkgo.DeferCleanup(CleanupDescriptors, gcmService, projectID) ginkgo.DeferCleanup(CleanupDescriptors, gcmService, projectID)
@@ -158,6 +162,9 @@ func testExternalMetrics(ctx context.Context, f *framework.Framework, kubeClient
// Set up a cluster: create a custom metric and set up k8s-sd adapter // Set up a cluster: create a custom metric and set up k8s-sd adapter
err = CreateDescriptors(gcmService, projectID) err = CreateDescriptors(gcmService, projectID)
if err != nil { if err != nil {
if strings.Contains(err.Error(), "Request throttled") {
e2eskipper.Skipf("Skipping...hitting rate limits on creating and updating metrics/labels")
}
framework.Failf("Failed to create metric descriptor: %s", err) framework.Failf("Failed to create metric descriptor: %s", err)
} }
ginkgo.DeferCleanup(CleanupDescriptors, gcmService, projectID) ginkgo.DeferCleanup(CleanupDescriptors, gcmService, projectID)