Update comments
This commit is contained in:
		| @@ -35,10 +35,9 @@ source "${KUBE_ROOT}/hack/lib/util.sh" | |||||||
| export KUBE_RELEASE_VERSION_REGEX="^v(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)(-([a-zA-Z0-9]+)\\.(0|[1-9][0-9]*))?$" | export KUBE_RELEASE_VERSION_REGEX="^v(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)(-([a-zA-Z0-9]+)\\.(0|[1-9][0-9]*))?$" | ||||||
| export KUBE_RELEASE_VERSION_DASHED_REGEX="v(0|[1-9][0-9]*)-(0|[1-9][0-9]*)-(0|[1-9][0-9]*)(-([a-zA-Z0-9]+)-(0|[1-9][0-9]*))?" | export KUBE_RELEASE_VERSION_DASHED_REGEX="v(0|[1-9][0-9]*)-(0|[1-9][0-9]*)-(0|[1-9][0-9]*)(-([a-zA-Z0-9]+)-(0|[1-9][0-9]*))?" | ||||||
|  |  | ||||||
| # KUBE_CI_VERSION_REGEX matches things like "v1.2.3-alpha.4.56+abcdefg" This | # KUBE_CI_VERSION_REGEX matches things like "v1.2.3-alpha.4.56+abcdefg" and "v1.2.3-56+abcdefg" | ||||||
| # | # | ||||||
| # NOTE This must match the version_regex in build/common.sh | # NOTE This must match the version_regex in build/common.sh | ||||||
| # kube::release::parse_and_validate_ci_version() |  | ||||||
| # | # | ||||||
| # TODO: KUBE_CI_VERSION_REGEX is used in hack/get-build.sh and KUBE_CI_VERSION_DASHED_REGEX is used in cluster/gce/util.sh, | # TODO: KUBE_CI_VERSION_REGEX is used in hack/get-build.sh and KUBE_CI_VERSION_DASHED_REGEX is used in cluster/gce/util.sh, | ||||||
| # make sure to remove these vars when not used anymore | # make sure to remove these vars when not used anymore | ||||||
|   | |||||||
| @@ -75,7 +75,7 @@ KUBE_RELEASE_VERSION_REGEX="^v(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)\\.(0|[1-9][0-9]* | |||||||
| KUBE_CI_VERSION_REGEX="^v(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)-([a-zA-Z0-9]+)\\.(0|[1-9][0-9]*)(\\.(0|[1-9][0-9]*)\\+[-0-9a-z]*)?$" | KUBE_CI_VERSION_REGEX="^v(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)-([a-zA-Z0-9]+)\\.(0|[1-9][0-9]*)(\\.(0|[1-9][0-9]*)\\+[-0-9a-z]*)?$" | ||||||
|  |  | ||||||
| # Sets KUBE_VERSION variable if an explicit version number was provided (e.g. "v1.0.6", | # Sets KUBE_VERSION variable if an explicit version number was provided (e.g. "v1.0.6", | ||||||
| # "v1.2.0-alpha.1.881+376438b69c7612") or resolves the "published" version | # "v1.2.0-alpha.1.881+376438b69c7612", or "v1.2.0-881+376438b69c7612") or resolves the "published" version | ||||||
| # <path>/<version> (e.g. "release/stable",' "ci/latest-1") by reading from GCS. | # <path>/<version> (e.g. "release/stable",' "ci/latest-1") by reading from GCS. | ||||||
| # | # | ||||||
| # See the docs on getting builds for more information about version | # See the docs on getting builds for more information about version | ||||||
| @@ -195,7 +195,7 @@ if [[ -z "${KUBERNETES_SKIP_RELEASE_VALIDATION-}" ]]; then | |||||||
|   elif [[ ${KUBE_VERSION} =~ ${KUBE_CI_VERSION_REGEX} ]]; then |   elif [[ ${KUBE_VERSION} =~ ${KUBE_CI_VERSION_REGEX} ]]; then | ||||||
|     # Override KUBERNETES_RELEASE_URL to point to the CI bucket; |     # Override KUBERNETES_RELEASE_URL to point to the CI bucket; | ||||||
|     # this will be used by get-kube-binaries.sh. |     # this will be used by get-kube-binaries.sh. | ||||||
|     # ie. v1.19.0-beta.0.318+b618411f1edb98 |     # ie. v1.19.0-beta.0.318+b618411f1edb98 and v1.19.0-318+b618411f1edb98 | ||||||
|     KUBERNETES_RELEASE_URL="${KUBERNETES_CI_RELEASE_URL}" |     KUBERNETES_RELEASE_URL="${KUBERNETES_CI_RELEASE_URL}" | ||||||
|   else |   else | ||||||
|     echo "Version doesn't match regexp" >&2 |     echo "Version doesn't match regexp" >&2 | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Jordan Liggitt
					Jordan Liggitt