github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed a possible nil pointer dereference caused by variable plug

Browse Source
This commit is contained in:
mengjiao.liu
2021-04-01 17:36:33 +08:00
committed by Mengjiao Liu
parent 5de1a754c8
commit c24b87b133
22 changed files with 47 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/volume/rbd/rbd_test.go
View File

@@ -106,7 +106,7 @@ func TestCanSupport(t *testing.T) {
plug, err := plugMgr.FindPluginByName("kubernetes.io/rbd")
if err != nil {
t.Errorf("Can't find the plugin by name")
t.Fatal("Can't find the plugin by name")
}
if plug.GetPluginName() != "kubernetes.io/rbd" {
t.Errorf("Wrong name: %s", plug.GetPluginName())
@@ -252,7 +252,7 @@ func doTestPlugin(t *testing.T, c *testcase) {
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, fakeVolumeHost)
plug, err := plugMgr.FindPluginByName("kubernetes.io/rbd")
if err != nil {
t.Errorf("Can't find the plugin by name")
t.Fatal("Can't find the plugin by name")
}
fakeMounter := fakeVolumeHost.GetMounter(plug.GetPluginName()).(*mount.FakeMounter)
fakeNodeName := types.NodeName("localhost")
@@ -604,7 +604,7 @@ func TestConstructVolumeSpec(t *testing.T) {
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, fakeVolumeHost)
plug, err := plugMgr.FindPluginByName("kubernetes.io/rbd")
if err != nil {
t.Errorf("Can't find the plugin by name")
t.Fatal("Can't find the plugin by name")
}
fakeMounter := fakeVolumeHost.GetMounter(plug.GetPluginName()).(*mount.FakeMounter)
@@ -753,7 +753,7 @@ func TestUnsupportedVolumeHost(t *testing.T) {
plug, err := plugMgr.FindPluginByName("kubernetes.io/rbd")
if err != nil {
t.Errorf("Can't find the plugin by name")
t.Fatal("Can't find the plugin by name")
}
_, err = plug.ConstructVolumeSpec("", "")