don't sync deployment when pod selector is empty

2016-03-25 00:40:12 -07:00
parent fa48e2497b
commit c4305762b2
3 changed files with 31 additions and 1 deletions
--- a/pkg/controller/deployment/deployment_controller.go
+++ b/pkg/controller/deployment/deployment_controller.go
@@ -426,6 +426,11 @@ func (dc *DeploymentController) syncDeployment(key string) error {
 	}

 	d := obj.(*extensions.Deployment)
+	everything := unversioned.LabelSelector{}
+	if reflect.DeepEqual(d.Spec.Selector, &everything) {
+		dc.eventRecorder.Eventf(d, api.EventTypeWarning, "SelectingAll", "This deployment is selecting all pods. A non-empty selector is required.")
+		return nil
+	}

 	if d.Spec.Paused {
 		// TODO: Implement scaling for paused deployments.