github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #24487 from cjcullen/sshleak

Browse Source 
Automatic merge from submit-queue

Fix goroutine leak in ssh-tunnel healthcheck.

Tunnel healthchecks were not closing the HTTP response body, leading to many open goroutines.
This commit is contained in:
k8s-merge-robot
2016-04-19 13:51:15 -07:00
parent d1c5ae65d8 cba5e84fd1
commit c6fec87021
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/ssh/ssh.go
View File

@@ -362,8 +362,12 @@ func (l *SSHTunnelList) healthCheck(e sshTunnelEntry) error {
TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
}) })
client := &http.Client{Transport: transport} client := &http.Client{Transport: transport}
_, err := client.Get(l.healthCheckURL.String()) resp, err := client.Get(l.healthCheckURL.String())
if err != nil {
return err return err
}
resp.Body.Close()
return nil
} }
func (l *SSHTunnelList) removeAndReAdd(e sshTunnelEntry) { func (l *SSHTunnelList) removeAndReAdd(e sshTunnelEntry) {