github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the redundant define name

Browse Source
This commit is contained in:
10177505 2020-11-07 10:37:21 +08:00
parent 151c2799d1
commit c9abf09136
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/controller/cronjob/cronjob_controller_test.go
View File

@ -250,6 +250,7 @@ func TestSyncOne_RunOrNot(t *testing.T) {
"prev ran but done, long overdue, past short deadline, F": {f, F, onTheHour, shortDead, T, F, weekAfterTheHour(), T, F, 1, 0}, "prev ran but done, long overdue, past short deadline, F": {f, F, onTheHour, shortDead, T, F, weekAfterTheHour(), T, F, 1, 0},
} }
for name, tc := range testCases { for name, tc := range testCases {
// Don't delete the redundant define 'name' and 'tc', keep those lines for goroutines.
name := name name := name
tc := tc tc := tc
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
@ -490,6 +491,7 @@ func TestCleanupFinishedJobs_DeleteOrNot(t *testing.T) {
} }
for name, tc := range testCases { for name, tc := range testCases {
// Don't delete the redundant define 'name' and 'tc', keep those lines for goroutines.
name := name name := name
tc := tc tc := tc
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
@ -677,6 +679,7 @@ func TestSyncOne_Status(t *testing.T) {
} }
for name, tc := range testCases { for name, tc := range testCases {
// Don't delete the redundant define 'name' and 'tc', keep those lines for goroutines.
name := name name := name
tc := tc tc := tc
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {