github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix sort on sets in hack/verify-flags-underscore.py

Browse Source
This commit is contained in:
Dr. Stefan Schimanski 2015-08-24 15:02:19 +02:00
parent 8800450c5f
commit ce013e288c
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hack/verify-flags-underscore.py
View File

@ -163,13 +163,15 @@ def get_flags(rootdir, files):
if len(new_excluded_flags) != 0: if len(new_excluded_flags) != 0:
print("Found a flag declared with an _ but which is not explicitly listed as a valid flag name in hack/verify-flags/excluded-flags.txt") print("Found a flag declared with an _ but which is not explicitly listed as a valid flag name in hack/verify-flags/excluded-flags.txt")
print("Are you certain this flag should not have been declared with an - instead?") print("Are you certain this flag should not have been declared with an - instead?")
new_excluded_flags.sort() l = list(new_excluded_flags)
print("%s" % "\n".join(new_excluded_flags)) l.sort()
print("%s" % "\n".join(l))
sys.exit(1) sys.exit(1)
if len(new_flags) != 0: if len(new_flags) != 0:
print("Found flags in golang files not in the list of known flags. Please add these to hack/verify-flags/known-flags.txt") print("Found flags in golang files not in the list of known flags. Please add these to hack/verify-flags/known-flags.txt")
new_flags.sort() l = list(new_flags)
print("%s" % "\n".join(new_flags)) l.sort()
print("%s" % "\n".join(l))
sys.exit(1) sys.exit(1)
return list(flags) return list(flags)