github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #29114 from matttproud/cleanups/density_e2e

Browse Source 
Automatic merge from submit-queue

test/e2e: plug time.Ticker resource leak.

This commit ensures that `logPodStartupStatus` does not leak
running `time.Ticker` instances.  Upon termination of the consuming
routine, we stop the ticker.
This commit is contained in:
k8s-merge-robot
2016-07-22 00:05:20 -07:00
committed by GitHub
parent 33f96bbbcb 656ea8f98f
commit cfdb468654
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/e2e/density.go
View File

@@ -151,6 +151,7 @@ func logPodStartupStatus(c *client.Client, expectedPods int, ns string, observed
podStore := framework.NewPodStore(c, ns, label, fields.Everything()) podStore := framework.NewPodStore(c, ns, label, fields.Everything())
defer podStore.Stop() defer podStore.Stop()
ticker := time.NewTicker(period) ticker := time.NewTicker(period)
defer ticker.Stop()
for { for {
select { select {
case <-ticker.C: case <-ticker.C: