From 77ac3290d603f51a4958c72e1c3210dff6ceedd0 Mon Sep 17 00:00:00 2001 From: Seth Jennings Date: Mon, 8 May 2017 13:39:01 -0500 Subject: [PATCH] check for walkErr before fileInfo deref --- pkg/kubectl/plugins/loader.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubectl/plugins/loader.go b/pkg/kubectl/plugins/loader.go index 6a34a150d7c..1301dbbb3c3 100644 --- a/pkg/kubectl/plugins/loader.go +++ b/pkg/kubectl/plugins/loader.go @@ -67,7 +67,7 @@ func (l *DirectoryPluginLoader) Load() (Plugins, error) { // read the base directory tree searching for plugin descriptors // fails silently (descriptors unable to be read or unmarshalled are logged but skipped) err = filepath.Walk(base, func(path string, fileInfo os.FileInfo, walkErr error) error { - if fileInfo.IsDir() || fileInfo.Name() != PluginDescriptorFilename || walkErr != nil { + if walkErr != nil || fileInfo.IsDir() || fileInfo.Name() != PluginDescriptorFilename { return nil }