github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dra: add "named resources" structured parameter model

Browse Source 
Like the current device plugin interface, a DRA driver using this model
announces a list of resource instances. In contrast to device plugins, this
list is made available to the scheduler together with attributes that can be
used to select suitable instances when they are not all alike.

Because this is the first structured parameter model, some checks that
previously were not possible, in particular "is one structured parameter field
set", now gets enabled. Adding another structured parameter model will be
similar.

The applyconfigs code generator assumes that all types in an API are defined in
a single package. If it wasn't for that, it would be possible to place the
"named resources" types in separate packages, which makes their names in the Go
code more natural and provides an indication of their stability level because
the package name could include a version.
This commit is contained in:
Patrick Ohly
2024-02-23 15:22:02 +01:00
parent 096e948905
commit d4d5ade7f5
66 changed files with 6143 additions and 274 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
pkg/apis/resource/validation/validation_resourceclassparameters_test.go
View File

@@ -186,15 +186,14 @@ func TestValidateResourceClassParameters(t *testing.T) {
}(),
},
// TODO: implement one structured parameter model
// "empty-model": {
// wantFailures: field.ErrorList{field.Required(field.NewPath("filters").Index(0), "exactly one structured model field must be set")},
// parameters: func() *resource.ResourceClassParameters {
// parameters := testResourceClassParameters(goodName, goodName, goodFilters)
// parameters.Filters = []resource.ResourceFilter{{DriverName: goodName}}
// return parameters
// }(),
// },
"empty-model": {
wantFailures: field.ErrorList{field.Required(field.NewPath("filters").Index(0), "exactly one structured model field must be set")},
parameters: func() *resource.ResourceClassParameters {
parameters := testResourceClassParameters(goodName, goodName, goodFilters)
parameters.Filters = []resource.ResourceFilter{{DriverName: goodName}}
return parameters
}(),
},
"filters-invalid-driver": {
wantFailures: field.ErrorList{field.Invalid(field.NewPath("filters").Index(1).Child("driverName"), badName, "a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')")},
@@ -202,15 +201,15 @@ func TestValidateResourceClassParameters(t *testing.T) {
parameters := testResourceClassParameters(goodName, goodName, goodFilters)
parameters.Filters = []resource.ResourceFilter{
{
DriverName: goodName,
DriverName: goodName,
ResourceFilterModel: resource.ResourceFilterModel{
// TODO: implement one structured parameter model
NamedResources: &resource.NamedResourcesFilter{Selector: "true"},
},
},
{
DriverName: badName,
DriverName: badName,
ResourceFilterModel: resource.ResourceFilterModel{
// TODO: implement one structured parameter model
NamedResources: &resource.NamedResourcesFilter{Selector: "true"},
},
},
}
@@ -224,14 +223,16 @@ func TestValidateResourceClassParameters(t *testing.T) {
parameters := testResourceClassParameters(goodName, goodName, goodFilters)
parameters.Filters = []resource.ResourceFilter{
{
DriverName: goodName,
DriverName: goodName,
ResourceFilterModel: resource.ResourceFilterModel{
// TODO: implement one structured parameter model
NamedResources: &resource.NamedResourcesFilter{Selector: "true"},
},
},
{
DriverName: goodName,
ResourceFilterModel: resource.ResourceFilterModel{},
DriverName: goodName,
ResourceFilterModel: resource.ResourceFilterModel{
NamedResources: &resource.NamedResourcesFilter{Selector: "true"},
},
},
}
return parameters