github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove unnecessary comment in pkg/scheduler/framework.QueueingHintFn

Browse Source 
event is not passed to QueueingHintFn but it exists a comment about it.
event is unnecessary in QueueingHintFn because QueueingHintFn is used in
ClusterEventWithHint and ClusterEventWithHint already have ClusterEvent.

Signed-off-by: Shingo Omura <everpeace@gmail.com>
This commit is contained in:
Shingo Omura
2023-06-29 21:19:00 +09:00
parent 7bac0cee89
commit d53762ec3a
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/scheduler/framework/types.go
View File

@@ -93,7 +93,6 @@ type ClusterEventWithHint struct {
// It's called before a Pod gets moved from unschedulableQ to backoffQ or activeQ. // It's called before a Pod gets moved from unschedulableQ to backoffQ or activeQ.
// //
// - `pod`: the Pod to be enqueued, which is rejected by this plugin in the past. // - `pod`: the Pod to be enqueued, which is rejected by this plugin in the past.
// - `event`: By which event the pod will be moved back to schedQ/backoffQ.
// - `oldObj` `newObj`: the object involved in that event. // - `oldObj` `newObj`: the object involved in that event.
// - For example, the given event is "Node deleted", the `oldObj` will be that deleted Node. // - For example, the given event is "Node deleted", the `oldObj` will be that deleted Node.
// - `oldObj` is nil if the event is add event. // - `oldObj` is nil if the event is add event.