github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #123659 from dims/check-length-of-instance-name-before-truncating

Browse Source 
Check length of instance name before truncating
This commit is contained in:
Kubernetes Prow Robot 2024-03-03 20:41:11 -08:00 committed by GitHub
commit d756b0a1c0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/e2e_node/remote/gce/gce_runner.go
View File

@ -646,8 +646,11 @@ func (g *GCERunner) imageToInstanceName(imageConfig *internalGCEImage) string {
// different machine types with the same image in parallel // different machine types with the same image in parallel
name := imageConfig.machine + "-" + imageConfig.image + "-" + uuid.New().String()[:8] name := imageConfig.machine + "-" + imageConfig.image + "-" + uuid.New().String()[:8]
// Sometimes the image is too long, we need instance names to have a max length of 63 // Sometimes the image is too long, we need instance names to have a max length of 63
if len(name) > 63 {
return name[:63] return name[:63]
} }
return name
}
func (g *GCERunner) registerGceHostIP(host string) error { func (g *GCERunner) registerGceHostIP(host string) error {
instance, err := getGCEInstance(host) instance, err := getGCEInstance(host)