Limit field errors to a single field name

This commit is contained in:
Jordan Liggitt
2015-08-12 11:26:23 -04:00
parent 5c08d276a0
commit d7a50c4778
3 changed files with 14 additions and 17 deletions

View File

@@ -223,7 +223,9 @@ func ValidateObjectMeta(meta *api.ObjectMeta, requiresNamespace bool, nameFn Val
// report it here. This may confuse users, but indicates a programming bug and still must be validated.
// If there are multiple fields out of which one is required then add a or as a separator
if len(meta.Name) == 0 {
allErrs = append(allErrs, errs.NewFieldRequired("name or generateName"))
requiredErr := errs.NewFieldRequired("name")
requiredErr.Detail = "name or generateName is required"
allErrs = append(allErrs, requiredErr)
} else {
if ok, qualifier := nameFn(meta.Name, false); !ok {
allErrs = append(allErrs, errs.NewFieldInvalid("name", meta.Name, qualifier))