Improved validation error message when env.valueFrom contains no (or misspelled) ref

This commit is contained in:
Marko Luksa
2016-11-08 17:48:12 +01:00
parent c41c24fbf3
commit d8ec7181b4
2 changed files with 13 additions and 2 deletions

View File

@@ -2446,6 +2446,15 @@ func TestValidateEnv(t *testing.T) {
}},
expectedError: "[0].valueFrom: Invalid value: \"\": may not be specified when `value` is not empty",
},
{
name: "valueFrom without a source",
envs: []api.EnvVar{{
Name: "abc",
ValueFrom: &api.EnvVarSource{
},
}},
expectedError: "[0].valueFrom: Invalid value: \"\": must specify one of: `fieldRef`, `resourceFieldRef`, `configMapKeyRef` or `secretKeyRef`",
},
{
name: "valueFrom.fieldRef and valueFrom.secretKeyRef specified",
envs: []api.EnvVar{{