From d9ab5e18d34ba24249e95fd7b11b19bab04623b0 Mon Sep 17 00:00:00 2001 From: calvin Date: Mon, 24 Jan 2022 15:01:49 +0800 Subject: [PATCH] fix: data race when hijack klog Signed-off-by: calvin --- .../nodeshutdown_manager_linux_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux_test.go b/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux_test.go index 0ed27932541..9f093b9aa21 100644 --- a/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux_test.go +++ b/pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux_test.go @@ -677,14 +677,14 @@ func Test_managerImpl_processShutdownEvent(t *testing.T) { }, } for _, tt := range tests { - - l := klog.Level(1) - l.Set("1") - tmpWriteBuffer := bytes.NewBuffer(nil) - klog.SetOutput(tmpWriteBuffer) - klog.LogToStderr(false) - t.Run(tt.name, func(t *testing.T) { + l := klog.Level(1) + l.Set("1") + // hijack the klog output + tmpWriteBuffer := bytes.NewBuffer(nil) + klog.SetOutput(tmpWriteBuffer) + klog.LogToStderr(false) + m := &managerImpl{ recorder: tt.fields.recorder, nodeRef: tt.fields.nodeRef,