github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add validation to MaxLimitRequestRatio in LimitRange

Browse Source 
MaxLimitRequestRatio should >=1
MaxLimitRequestRatio should <= max/min(if both are specified)
This commit is contained in:
hurf
2015-09-11 15:38:38 +08:00
parent d5b33614c3
commit daeae81e1e
2 changed files with 46 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
pkg/api/validation/validation_test.go
View File

@@ -3062,6 +3062,30 @@ func TestValidateLimitRange(t *testing.T) {
}},
"default request value 800m is greater than default limit value 500m",
},
"invalid spec maxLimitRequestRatio less than 1": {
api.LimitRange{ObjectMeta: api.ObjectMeta{Name: "abc", Namespace: "foo"}, Spec: api.LimitRangeSpec{
Limits: []api.LimitRangeItem{
{
Type: api.LimitTypePod,
MaxLimitRequestRatio: getResourceList("800m", ""),
},
},
}},
"maxLimitRequestRatio 800m is less than 1",
},
"invalid spec maxLimitRequestRatio greater than max/min": {
api.LimitRange{ObjectMeta: api.ObjectMeta{Name: "abc", Namespace: "foo"}, Spec: api.LimitRangeSpec{
Limits: []api.LimitRangeItem{
{
Type: api.LimitTypeContainer,
Max: getResourceList("", "2Gi"),
Min: getResourceList("", "512Mi"),
MaxLimitRequestRatio: getResourceList("", "10"),
},
},
}},
"maxLimitRequestRatio 10 is greater than max/min = 4.000000",
},
}
for k, v := range errorCases {