Enable dynamic azure disk volume limits

use API to get max disk num

use continue when got exception

add logging

add cache and unit test

fix comments
This commit is contained in:
andyzhangx
2018-07-24 02:00:57 +00:00
parent 974978a7c7
commit dd63d407a4
5 changed files with 144 additions and 11 deletions

View File

@@ -131,6 +131,11 @@ type DisksClient interface {
Get(ctx context.Context, resourceGroupName string, diskName string) (result compute.Disk, err error)
}
// VirtualMachineSizesClient defines needed functions for azure compute.VirtualMachineSizesClient
type VirtualMachineSizesClient interface {
List(ctx context.Context, location string) (result compute.VirtualMachineSizeListResult, err error)
}
// azClientConfig contains all essential information to create an Azure client.
type azClientConfig struct {
subscriptionID string
@@ -1327,3 +1332,41 @@ func (az *azDisksClient) Get(ctx context.Context, resourceGroupName string, disk
mc.Observe(err)
return
}
// azVirtualMachineSizesClient implements VirtualMachineSizesClient.
type azVirtualMachineSizesClient struct {
client compute.VirtualMachineSizesClient
rateLimiterReader flowcontrol.RateLimiter
rateLimiterWriter flowcontrol.RateLimiter
}
func newAzVirtualMachineSizesClient(config *azClientConfig) *azVirtualMachineSizesClient {
VirtualMachineSizesClient := compute.NewVirtualMachineSizesClient(config.subscriptionID)
VirtualMachineSizesClient.BaseURI = config.resourceManagerEndpoint
VirtualMachineSizesClient.Authorizer = autorest.NewBearerAuthorizer(config.servicePrincipalToken)
VirtualMachineSizesClient.PollingDelay = 5 * time.Second
configureUserAgent(&VirtualMachineSizesClient.Client)
return &azVirtualMachineSizesClient{
rateLimiterReader: config.rateLimiterReader,
rateLimiterWriter: config.rateLimiterWriter,
client: VirtualMachineSizesClient,
}
}
func (az *azVirtualMachineSizesClient) List(ctx context.Context, location string) (result compute.VirtualMachineSizeListResult, err error) {
if !az.rateLimiterReader.TryAccept() {
err = createRateLimitErr(false, "VMSizesList")
return
}
glog.V(10).Infof("azVirtualMachineSizesClient.List(%q): start", location)
defer func() {
glog.V(10).Infof("azVirtualMachineSizesClient.List(%q): end", location)
}()
mc := newMetricContext("vmsizes", "list", "", az.client.SubscriptionID)
result, err = az.client.List(ctx, location)
mc.Observe(err)
return
}