github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NodeLifecycleController: Remove race condition

Browse Source 
Patch request does not support RV by default, we need to include them explicitly and patching lists actually overwrites whole field. It means that there is a race condition, in which we can overwrite changes to taints that happened between GET and PATCH requests.
This commit is contained in:
Jakub Przychodzeń
2022-10-18 12:01:15 +00:00
parent 83415e5c9e
commit de25c5fdcf
5 changed files with 70 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/nodelifecycle/node_lifecycle_controller_test.go
View File

@@ -54,7 +54,7 @@ const (
testNodeMonitorGracePeriod = 40 * time.Second
testNodeStartupGracePeriod = 60 * time.Second
testNodeMonitorPeriod = 5 * time.Second
testRateLimiterQPS = float32(10000)
testRateLimiterQPS = float32(100000)
testLargeClusterThreshold = 20
testUnhealthyThreshold = float32(0.55)
)