github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

e2e: accept context from Ginkgo

Browse Source 
Every ginkgo callback should return immediately when a timeout occurs or the
test run manually gets aborted with CTRL-C. To do that, they must take a ctx
parameter and pass it through to all code which might block.

This is a first automated step towards that: the additional parameter got added
with

    sed -i 's/\(framework.ConformanceIt\|ginkgo.It\)\(.*\)func() {$/\1\2func(ctx context.Context) {/' \
        $(git grep -l -e framework.ConformanceIt -e ginkgo.It )
    $GOPATH/bin/goimports -w $(git status | grep modified: | sed -e 's/.* //')

log_test.go was left unchanged.
This commit is contained in:
Patrick Ohly
2022-10-17 14:47:15 +02:00
parent 63ff4a2659
commit df5d84ae81
291 changed files with 1542 additions and 1454 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/e2e_node/topology_manager_test.go
View File

@@ -884,7 +884,7 @@ func runTopologyManagerTests(f *framework.Framework) {
topologymanager.PolicyNone,
}
ginkgo.It("run Topology Manager policy test suite", func() {
ginkgo.It("run Topology Manager policy test suite", func(ctx context.Context) {
oldCfg, err = getCurrentKubeletConfig()
framework.ExpectNoError(err)
@@ -901,7 +901,7 @@ func runTopologyManagerTests(f *framework.Framework) {
}
})
ginkgo.It("run Topology Manager node alignment test suite", func() {
ginkgo.It("run Topology Manager node alignment test suite", func(ctx context.Context) {
numaNodes, coreCount := hostPrecheck()
configMap := getSRIOVDevicePluginConfigMap(framework.TestContext.SriovdpConfigMapFile)
@@ -925,7 +925,7 @@ func runTopologyManagerTests(f *framework.Framework) {
}
})
ginkgo.It("run the Topology Manager pod scope alignment test suite", func() {
ginkgo.It("run the Topology Manager pod scope alignment test suite", func(ctx context.Context) {
numaNodes, coreCount := hostPrecheck()
configMap := getSRIOVDevicePluginConfigMap(framework.TestContext.SriovdpConfigMapFile)