Merge pull request #107527 from wojtek-t/remove_selflink_ga

Graduate RemoveSelfLink to Stable

pkg/api/testing/applyconfiguration_test.go

@@ -179,6 +179,7 @@ func fuzzObject(t *testing.T, gvk schema.GroupVersionKind) runtime.Object {
 			func(s *v1.ObjectMeta, c fuzz.Continue) {
 				c.FuzzNoCustom(s)
 				s.ManagedFields = nil
+				s.SelfLink = ""
 			},
 		).Fuzz(internalObj)
 

pkg/api/testing/deep_copy_test.go

@@ -46,7 +46,6 @@ var benchmarkPod = api.Pod{
 	ObjectMeta: metav1.ObjectMeta{
 		Name:              "etcd-server-e2e-test-wojtekt-master",
 		Namespace:         "default",
-		SelfLink:          "/api/v1/namespaces/default/pods/etcd-server-e2e-test-wojtekt-master",
 		UID:               types.UID("a671734a-e8e5-11e4-8fde-42010af09327"),
 		ResourceVersion:   "22",
 		CreationTimestamp: parseTimeOrDie("2015-04-22T11:49:36Z"),

pkg/api/testing/meta_test.go

@@ -56,11 +56,6 @@ func TestAccessorImplementations(t *testing.T) {
 						t.Errorf("%v (%v) did not preserve resource version", gv.WithKind(kind), knownType)
 						continue
 					}
-					m.SetSelfLink("102030")
-					if m.GetSelfLink() != "102030" {
-						t.Errorf("%v (%v) did not preserve self link", gv.WithKind(kind), knownType)
-						continue
-					}
 				case isOM:
 					m := om.GetObjectMeta()
 					if m == nil {
@@ -72,11 +67,6 @@ func TestAccessorImplementations(t *testing.T) {
 						t.Errorf("%v (%v) did not preserve resource version", gv.WithKind(kind), knownType)
 						continue
 					}
-					m.SetSelfLink("102030")
-					if m.GetSelfLink() != "102030" {
-						t.Errorf("%v (%v) did not preserve self link", gv.WithKind(kind), knownType)
-						continue
-					}
 					labels := map[string]string{"a": "b"}
 					m.SetLabels(labels)
 					if !reflect.DeepEqual(m.GetLabels(), labels) {

pkg/api/testing/node_example.json

@@ -3,7 +3,6 @@
     "apiVersion": "v1",
     "metadata": {
         "name": "e2e-test-wojtekt-node-etd6",
-        "selfLink": "/api/v1/nodes/e2e-test-wojtekt-node-etd6",
         "uid": "a7e89222-e8e5-11e4-8fde-42010af09327",
         "resourceVersion": "379",
         "creationTimestamp": "2015-04-22T11:49:39Z"

pkg/api/testing/replication_controller_example.json

@@ -4,7 +4,6 @@
     "metadata": {
         "name": "elasticsearch-logging-controller",
         "namespace": "default",
-        "selfLink": "/api/v1/namespaces/default/replicationcontrollers/elasticsearch-logging-controller",
         "uid": "aa76f162-e8e5-11e4-8fde-42010af09327",
         "resourceVersion": "98",
         "creationTimestamp": "2015-04-22T11:49:43Z",

pkg/printers/tablegenerator.go

@@ -110,13 +110,11 @@ func (h *HumanReadableGenerator) GenerateTable(obj runtime.Object, options Gener
 	}
 	if m, err := meta.ListAccessor(obj); err == nil {
 		table.ResourceVersion = m.GetResourceVersion()
-		table.SelfLink = m.GetSelfLink()
 		table.Continue = m.GetContinue()
 		table.RemainingItemCount = m.GetRemainingItemCount()
 	} else {
 		if m, err := meta.CommonAccessor(obj); err == nil {
 			table.ResourceVersion = m.GetResourceVersion()
-			table.SelfLink = m.GetSelfLink()
 		}
 	}
 	return table, nil