github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #123834 from alvaroaleman/emit-err

Browse Source 
Nodelifecycle: Emit event when deletion failed
This commit is contained in:
Kubernetes Prow Robot
2024-04-18 01:04:03 -07:00
committed by GitHub
parent d9d6986948 b2eb6e7d03
commit e43015ad42
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/cloud-provider/controllers/nodelifecycle/node_lifecycle_controller.go
View File

@@ -43,6 +43,7 @@ import (
const ( const (
deleteNodeEvent = "DeletingNode" deleteNodeEvent = "DeletingNode"
deleteNodeFailedEvent = "DeletingNodeFailed"
) )
var ShutdownTaint = &v1.Taint{ var ShutdownTaint = &v1.Taint{
@@ -175,6 +176,8 @@ func (c *CloudNodeLifecycleController) MonitorNodes(ctx context.Context) {
if err := c.kubeClient.CoreV1().Nodes().Delete(ctx, node.Name, metav1.DeleteOptions{}); err != nil { if err := c.kubeClient.CoreV1().Nodes().Delete(ctx, node.Name, metav1.DeleteOptions{}); err != nil {
klog.Errorf("unable to delete node %q: %v", node.Name, err) klog.Errorf("unable to delete node %q: %v", node.Name, err)
c.recorder.Eventf(ref, v1.EventTypeWarning, deleteNodeFailedEvent,
"Failed deleting node %s: %v", node.Name, err)
} }
} else { } else {
// Node exists. We need to check this to get taint working in similar in all cloudproviders // Node exists. We need to check this to get taint working in similar in all cloudproviders