Merge pull request #122128 from my-git9/configut
kubeadm: increase ut coverage of util/config
This commit is contained in:
		@@ -22,6 +22,9 @@ import (
 | 
			
		||||
	"testing"
 | 
			
		||||
 | 
			
		||||
	"github.com/lithammer/dedent"
 | 
			
		||||
	"github.com/stretchr/testify/assert"
 | 
			
		||||
 | 
			
		||||
	kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
func TestLoadResetConfigurationFromFile(t *testing.T) {
 | 
			
		||||
@@ -98,3 +101,53 @@ func TestLoadResetConfigurationFromFile(t *testing.T) {
 | 
			
		||||
		})
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func TestSetResetDynamicDefaults(t *testing.T) {
 | 
			
		||||
	type args struct {
 | 
			
		||||
		cfg           *kubeadmapi.ResetConfiguration
 | 
			
		||||
		skipCRIDetect bool
 | 
			
		||||
	}
 | 
			
		||||
	tests := []struct {
 | 
			
		||||
		name string
 | 
			
		||||
		args args
 | 
			
		||||
	}{
 | 
			
		||||
		{
 | 
			
		||||
			name: "CRISocket is empty and skipCRIDetect is true",
 | 
			
		||||
			args: args{
 | 
			
		||||
				cfg:           &kubeadmapi.ResetConfiguration{},
 | 
			
		||||
				skipCRIDetect: true,
 | 
			
		||||
			},
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			name: "CRISocket is empty and skipCRIDetect is false",
 | 
			
		||||
			args: args{
 | 
			
		||||
				cfg:           &kubeadmapi.ResetConfiguration{},
 | 
			
		||||
				skipCRIDetect: false,
 | 
			
		||||
			},
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			name: "CRISocket is valid",
 | 
			
		||||
			args: args{
 | 
			
		||||
				cfg: &kubeadmapi.ResetConfiguration{
 | 
			
		||||
					CRISocket: "unix:///var/run/containerd/containerd.sock",
 | 
			
		||||
				},
 | 
			
		||||
				skipCRIDetect: false,
 | 
			
		||||
			},
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			name: "CRISocket is invalid",
 | 
			
		||||
			args: args{
 | 
			
		||||
				cfg: &kubeadmapi.ResetConfiguration{
 | 
			
		||||
					CRISocket: "var/run/containerd/containerd.sock",
 | 
			
		||||
				},
 | 
			
		||||
				skipCRIDetect: false,
 | 
			
		||||
			},
 | 
			
		||||
		},
 | 
			
		||||
	}
 | 
			
		||||
	for _, rt := range tests {
 | 
			
		||||
		t.Run(rt.name, func(t *testing.T) {
 | 
			
		||||
			err := SetResetDynamicDefaults(rt.args.cfg, rt.args.skipCRIDetect)
 | 
			
		||||
			assert.NoError(t, err)
 | 
			
		||||
		})
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user