Merge pull request #759 from brendandburns/valid

Add c-identifier validation to service ids.
2014-08-05 12:32:02 -07:00
parent 6f85a5b8aa 20a8f03d62
commit e75854a1f9
4 changed files with 37 additions and 1 deletions
--- a/pkg/api/validation.go
+++ b/pkg/api/validation.go
@@ -302,6 +302,8 @@ func ValidateService(service *Service) []error {
 	allErrs := errorList{}
 	if service.ID == "" {
 		allErrs.Append(makeInvalidError("Service.ID", service.ID))
+	} else if !util.IsDNS952Label(service.ID) {
+		allErrs.Append(makeInvalidError("Service.ID", service.ID))
 	}
 	if labels.Set(service.Selector).AsSelector().Empty() {
 		allErrs.Append(makeInvalidError("Service.Selector", service.Selector))