github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #43578 from vsiddharth/pause-container

Browse Source 
Automatic merge from submit-queue

Improve pause-container warning message

Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>



**What this PR does / why we need it**:
This just improves the warning message currently emitted by pause

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
```
This commit is contained in:
Kubernetes Submit Queue
2017-05-17 22:56:20 -07:00
committed by GitHub
parent 7f27cebe49 9fa5e857e5
commit e7b1814863
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
build/pause/pause.c
View File

@@ -27,14 +27,13 @@ static void sigdown(int signo) {
} }
static void sigreap(int signo) { static void sigreap(int signo) {
while (waitpid(-1, NULL, WNOHANG) > 0) while (waitpid(-1, NULL, WNOHANG) > 0);
;
} }
int main() { int main() {
if (getpid() != 1) if (getpid() != 1)
/* Not an error because pause sees use outside of infra containers. */ /* Not an error because pause sees use outside of infra containers. */
fprintf(stderr, "Warning: pause should be the first process in a pod\n"); fprintf(stderr, "Warning: pause should be the first process\n");
if (sigaction(SIGINT, &(struct sigaction){.sa_handler = sigdown}, NULL) < 0) if (sigaction(SIGINT, &(struct sigaction){.sa_handler = sigdown}, NULL) < 0)
return 1; return 1;