github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use cloudprovider.NotImplemented in AddSSHKeyToAllInstances

Browse Source 
Minor cleanup: In looking at implementations of this method,
noticed a few providers created their own errors instead of using cloudprovider.NotImplemented
This commit is contained in:
Doug MacEachern
2018-04-27 13:15:59 -07:00
parent 70e9288407
commit e7cc5df3f6
4 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/cloudprovider/providers/azure/azure_instances.go
View File

@@ -18,7 +18,6 @@ package azure
import ( import (
"context" "context"
"fmt"
"os" "os"
"strings" "strings"
@@ -216,7 +215,7 @@ func (az *Cloud) InstanceType(ctx context.Context, name types.NodeName) (string,
// AddSSHKeyToAllInstances adds an SSH public key as a legal identity for all instances // AddSSHKeyToAllInstances adds an SSH public key as a legal identity for all instances
// expected format for the key is standard ssh-keygen format: <protocol> <blob> // expected format for the key is standard ssh-keygen format: <protocol> <blob>
func (az *Cloud) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error { func (az *Cloud) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error {
return fmt.Errorf("not supported") return cloudprovider.NotImplemented
} }
// CurrentNodeName returns the name of the node we are currently running on. // CurrentNodeName returns the name of the node we are currently running on.

2
pkg/cloudprovider/providers/cloudstack/cloudstack_instances.go
View File

@@ -130,7 +130,7 @@ func (cs *CSCloud) InstanceTypeByProviderID(ctx context.Context, providerID stri
// AddSSHKeyToAllInstances is currently not implemented. // AddSSHKeyToAllInstances is currently not implemented.
func (cs *CSCloud) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error { func (cs *CSCloud) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error {
return errors.New("AddSSHKeyToAllInstances not implemented") return cloudprovider.NotImplemented
} }
// CurrentNodeName returns the name of the node we are currently running on. // CurrentNodeName returns the name of the node we are currently running on.

2
pkg/cloudprovider/providers/cloudstack/metadata.go
View File

@@ -101,7 +101,7 @@ func (m *metadata) InstanceTypeByProviderID(ctx context.Context, providerID stri
// AddSSHKeyToAllInstances is currently not implemented. // AddSSHKeyToAllInstances is currently not implemented.
func (m *metadata) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error { func (m *metadata) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error {
return errors.New("AddSSHKeyToAllInstances not implemented") return cloudprovider.NotImplemented
} }
// CurrentNodeName returns the name of the node we are currently running on. // CurrentNodeName returns the name of the node we are currently running on.

2
pkg/volume/cinder/attacher_test.go
View File

@@ -737,7 +737,7 @@ func (instances *instances) List(filter string) ([]types.NodeName, error) {
} }
func (instances *instances) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error { func (instances *instances) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error {
return errors.New("Not implemented") return cloudprovider.NotImplemented
} }
func (instances *instances) CurrentNodeName(ctx context.Context, hostname string) (types.NodeName, error) { func (instances *instances) CurrentNodeName(ctx context.Context, hostname string) (types.NodeName, error) {