Pass obj with lock by reference. Methods->funcs.

Fixes "lock passed by value" issues raised by "go vet".
This commit is contained in:
Eric Tune
2014-08-14 11:09:08 -07:00
parent e5e4c8a7d3
commit ee91a19f90
2 changed files with 13 additions and 15 deletions

View File

@@ -22,26 +22,24 @@ import (
"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
)
func TestLoadBalanceValidateWorks(t *testing.T) {
loadBalancer := NewLoadBalancerRR()
if loadBalancer.isValid("") {
func TestValidateWorks(t *testing.T) {
if isValidEndpoint("") {
t.Errorf("Didn't fail for empty string")
}
if loadBalancer.isValid("foobar") {
if isValidEndpoint("foobar") {
t.Errorf("Didn't fail with no port")
}
if loadBalancer.isValid("foobar:-1") {
if isValidEndpoint("foobar:-1") {
t.Errorf("Didn't fail with a negative port")
}
if !loadBalancer.isValid("foobar:8080") {
if !isValidEndpoint("foobar:8080") {
t.Errorf("Failed a valid config.")
}
}
func TestLoadBalanceFilterWorks(t *testing.T) {
loadBalancer := NewLoadBalancerRR()
func TestFilterWorks(t *testing.T) {
endpoints := []string{"foobar:1", "foobar:2", "foobar:-1", "foobar:3", "foobar:-2"}
filtered := loadBalancer.filterValidEndpoints(endpoints)
filtered := filterValidEndpoints(endpoints)
if len(filtered) != 3 {
t.Errorf("Failed to filter to the correct size")