github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update unit tests for TopologyHints - Topology Manager Policies

Browse Source
This commit is contained in:
nolancon
2019-05-13 04:23:22 +01:00
parent e82fa41fb2
commit ef9baf313d
2 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/kubelet/cm/topologymanager/policy_preferred_test.go
View File

@@ -23,27 +23,25 @@ import (
func TestCanAdmitPodResult1(t *testing.T) { func TestCanAdmitPodResult1(t *testing.T) {
tcases := []struct { tcases := []struct {
name string name string
affinity bool admit bool
expected bool expected bool
}{ }{
{ {
name: "Affinity is set to false in topology hints", name: "Affinity is set to false in topology hints",
affinity: false, admit: false,
expected: true, expected: true,
}, },
{ {
name: "Affinity is set to true in topology hints", name: "Affinity is set to true in topology hints",
affinity: true, admit: true,
expected: true, expected: true,
}, },
} }
for _, tc := range tcases { for _, tc := range tcases {
policy := NewPreferredPolicy() policy := NewPreferredPolicy()
hints := TopologyHints{ admit := tc.admit
Affinity: tc.affinity, result := policy.CanAdmitPodResult(admit)
}
result := policy.CanAdmitPodResult(hints)
if result.Admit != tc.expected { if result.Admit != tc.expected {
t.Errorf("Expected Admit field in result to be %t, got %t", tc.expected, result.Admit) t.Errorf("Expected Admit field in result to be %t, got %t", tc.expected, result.Admit)

12
pkg/kubelet/cm/topologymanager/policy_strict_test.go
View File

@@ -23,27 +23,25 @@ import (
func TestCanAdmitPodResult(t *testing.T) { func TestCanAdmitPodResult(t *testing.T) {
tcases := []struct { tcases := []struct {
name string name string
affinity bool admit bool
expected bool expected bool
}{ }{
{ {
name: "Affinity is set to false in topology hints", name: "Affinity is set to false in topology hints",
affinity: false, admit: false,
expected: false, expected: false,
}, },
{ {
name: "Affinity is set to true in topology hints", name: "Affinity is set to true in topology hints",
affinity: true, admit: true,
expected: true, expected: true,
}, },
} }
for _, tc := range tcases { for _, tc := range tcases {
policy := NewStrictPolicy() policy := NewStrictPolicy()
hints := TopologyHints{ admit := tc.admit
Affinity: tc.affinity, result := policy.CanAdmitPodResult(admit)
}
result := policy.CanAdmitPodResult(hints)
if result.Admit != tc.expected { if result.Admit != tc.expected {
t.Errorf("Expected Admit field in result to be %t, got %t", tc.expected, result.Admit) t.Errorf("Expected Admit field in result to be %t, got %t", tc.expected, result.Admit)