github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Validating the scheduling gate naming format

Browse Source
This commit is contained in:
lianghao208
2023-02-16 14:56:04 +08:00
parent a25834cb5a
commit f09eeaf104
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/apis/core/validation/validation_test.go
View File

@@ -18696,7 +18696,10 @@ func TestValidateSchedulingGates(t *testing.T) {
{Name: "foo"},
{Name: ""},
},
wantFieldErrors: []*field.Error{field.Required(fieldPath.Index(1), "must not be empty")},
wantFieldErrors: field.ErrorList{
field.Invalid(fieldPath.Index(1), "", "name part must be non-empty"),
field.Invalid(fieldPath.Index(1), "", "name part must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]')"),
},
},
{
name: "legal gates",
@@ -18706,6 +18709,14 @@ func TestValidateSchedulingGates(t *testing.T) {
},
wantFieldErrors: field.ErrorList{},
},
{
name: "illegal gates",
schedulingGates: []core.PodSchedulingGate{
{Name: "foo"},
{Name: "\nbar"},
},
wantFieldErrors: []*field.Error{field.Invalid(fieldPath.Index(1), "\nbar", "name part must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]')")},
},
{
name: "duplicated gates (single duplication)",
schedulingGates: []core.PodSchedulingGate{