github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Follow our go code style: error -> err

Browse Source 
Issue #47394
This commit is contained in:
Justin Santa Barbara
2017-06-13 00:05:11 -04:00
parent 54f628ad79
commit f10c9eed69
1 changed files with 24 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
pkg/cloudprovider/providers/aws/aws.go
View File

@@ -1037,39 +1037,36 @@ func (c *Cloud) NodeAddresses(name types.NodeName) ([]v1.NodeAddress, error) {
// This method will not be called from the node that is requesting this ID. i.e. metadata service // This method will not be called from the node that is requesting this ID. i.e. metadata service
// and other local methods cannot be used here // and other local methods cannot be used here
func (c *Cloud) NodeAddressesByProviderID(providerID string) ([]v1.NodeAddress, error) { func (c *Cloud) NodeAddressesByProviderID(providerID string) ([]v1.NodeAddress, error) {
instanceID, error := instanceIDFromProviderID(providerID) instanceID, err := instanceIDFromProviderID(providerID)
if err != nil {
if error != nil { return nil, err
return nil, error
} }
addresses, error := c.describeAddressesByInstanceID(instanceID) addresses, err := c.describeAddressesByInstanceID(instanceID)
if err != nil {
if error != nil { return nil, err
return nil, error
} }
instances, error := c.describeInstancesByInstanceID(instanceID) instances, err := c.describeInstancesByInstanceID(instanceID)
if err != nil {
if error != nil { return nil, err
return nil, error
} }
nodeAddresses := []v1.NodeAddress{} nodeAddresses := []v1.NodeAddress{}
for _, address := range addresses { for _, address := range addresses {
convertedAddress, error := convertAwsAddress(address) convertedAddress, err := convertAwsAddress(address)
if error != nil { if err != nil {
return nil, error return nil, err
} }
nodeAddresses = append(nodeAddresses, convertedAddress...) nodeAddresses = append(nodeAddresses, convertedAddress...)
} }
for _, instance := range instances { for _, instance := range instances {
addresses, error := instanceAddresses(instance) addresses, err := instanceAddresses(instance)
if error != nil { if err != nil {
return nil, error return nil, err
} }
nodeAddresses = append(nodeAddresses, addresses...) nodeAddresses = append(nodeAddresses, addresses...)
@@ -1114,16 +1111,14 @@ func (c *Cloud) InstanceID(nodeName types.NodeName) (string, error) {
// This method will not be called from the node that is requesting this ID. i.e. metadata service // This method will not be called from the node that is requesting this ID. i.e. metadata service
// and other local methods cannot be used here // and other local methods cannot be used here
func (c *Cloud) InstanceTypeByProviderID(providerID string) (string, error) { func (c *Cloud) InstanceTypeByProviderID(providerID string) (string, error) {
instanceID, error := instanceIDFromProviderID(providerID) instanceID, err := instanceIDFromProviderID(providerID)
if err != nil {
if error != nil { return "", err
return "", error
} }
instance, error := c.describeInstanceByInstanceID(instanceID) instance, err := c.describeInstanceByInstanceID(instanceID)
if err != nil {
if error != nil { return "", err
return "", error
} }
return aws.StringValue(instance.InstanceType), nil return aws.StringValue(instance.InstanceType), nil
@@ -3452,10 +3447,9 @@ func (c *Cloud) describeAddressesByInstanceID(instanceID string) ([]*ec2.Address
Filters: filters, Filters: filters,
} }
addresses, error := c.ec2.DescribeAddresses(params) addresses, err := c.ec2.DescribeAddresses(params)
if err != nil {
if error != nil { return nil, err
return nil, error
} }
return addresses, nil return addresses, nil