github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #121716 from kerthcet/cleanup/add-log

Browse Source 
Add more logs to scheduler event handler
This commit is contained in:
Kubernetes Prow Robot
2024-01-15 16:23:19 +01:00
committed by GitHub
parent 591a5c0bff a96d21b4b0
commit f38ff3feea
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/scheduler/eventhandlers.go
View File

@@ -72,8 +72,8 @@ func (sched *Scheduler) addNodeToCache(obj interface{}) {
return return
} }
nodeInfo := sched.Cache.AddNode(logger, node)
logger.V(3).Info("Add event for node", "node", klog.KObj(node)) logger.V(3).Info("Add event for node", "node", klog.KObj(node))
nodeInfo := sched.Cache.AddNode(logger, node)
sched.SchedulingQueue.MoveAllToActiveOrBackoffQueue(logger, queue.NodeAdd, nil, node, preCheckForNode(nodeInfo)) sched.SchedulingQueue.MoveAllToActiveOrBackoffQueue(logger, queue.NodeAdd, nil, node, preCheckForNode(nodeInfo))
} }
@@ -90,6 +90,7 @@ func (sched *Scheduler) updateNodeInCache(oldObj, newObj interface{}) {
return return
} }
logger.V(4).Info("Update event for node", "node", klog.KObj(newNode))
nodeInfo := sched.Cache.UpdateNode(logger, oldNode, newNode) nodeInfo := sched.Cache.UpdateNode(logger, oldNode, newNode)
// Only requeue unschedulable pods if the node became more schedulable. // Only requeue unschedulable pods if the node became more schedulable.
for _, evt := range nodeSchedulingPropertiesChange(newNode, oldNode) { for _, evt := range nodeSchedulingPropertiesChange(newNode, oldNode) {
@@ -114,6 +115,7 @@ func (sched *Scheduler) deleteNodeFromCache(obj interface{}) {
logger.Error(nil, "Cannot convert to *v1.Node", "obj", t) logger.Error(nil, "Cannot convert to *v1.Node", "obj", t)
return return
} }
logger.V(3).Info("Delete event for node", "node", klog.KObj(node)) logger.V(3).Info("Delete event for node", "node", klog.KObj(node))
if err := sched.Cache.RemoveNode(logger, node); err != nil { if err := sched.Cache.RemoveNode(logger, node); err != nil {
logger.Error(err, "Scheduler cache RemoveNode failed") logger.Error(err, "Scheduler cache RemoveNode failed")
@@ -146,6 +148,7 @@ func (sched *Scheduler) updatePodInSchedulingQueue(oldObj, newObj interface{}) {
return return
} }
logger.V(4).Info("Update event for unscheduled pod", "pod", klog.KObj(newPod))
if err := sched.SchedulingQueue.Update(logger, oldPod, newPod); err != nil { if err := sched.SchedulingQueue.Update(logger, oldPod, newPod); err != nil {
utilruntime.HandleError(fmt.Errorf("unable to update %T: %v", newObj, err)) utilruntime.HandleError(fmt.Errorf("unable to update %T: %v", newObj, err))
} }
@@ -168,6 +171,7 @@ func (sched *Scheduler) deletePodFromSchedulingQueue(obj interface{}) {
utilruntime.HandleError(fmt.Errorf("unable to handle object in %T: %T", sched, obj)) utilruntime.HandleError(fmt.Errorf("unable to handle object in %T: %T", sched, obj))
return return
} }
logger.V(3).Info("Delete event for unscheduled pod", "pod", klog.KObj(pod)) logger.V(3).Info("Delete event for unscheduled pod", "pod", klog.KObj(pod))
if err := sched.SchedulingQueue.Delete(pod); err != nil { if err := sched.SchedulingQueue.Delete(pod); err != nil {
utilruntime.HandleError(fmt.Errorf("unable to dequeue %T: %v", obj, err)) utilruntime.HandleError(fmt.Errorf("unable to dequeue %T: %v", obj, err))
@@ -194,8 +198,8 @@ func (sched *Scheduler) addPodToCache(obj interface{}) {
logger.Error(nil, "Cannot convert to *v1.Pod", "obj", obj) logger.Error(nil, "Cannot convert to *v1.Pod", "obj", obj)
return return
} }
logger.V(3).Info("Add event for scheduled pod", "pod", klog.KObj(pod))
logger.V(3).Info("Add event for scheduled pod", "pod", klog.KObj(pod))
if err := sched.Cache.AddPod(logger, pod); err != nil { if err := sched.Cache.AddPod(logger, pod); err != nil {
logger.Error(err, "Scheduler cache AddPod failed", "pod", klog.KObj(pod)) logger.Error(err, "Scheduler cache AddPod failed", "pod", klog.KObj(pod))
} }
@@ -215,8 +219,8 @@ func (sched *Scheduler) updatePodInCache(oldObj, newObj interface{}) {
logger.Error(nil, "Cannot convert newObj to *v1.Pod", "newObj", newObj) logger.Error(nil, "Cannot convert newObj to *v1.Pod", "newObj", newObj)
return return
} }
logger.V(4).Info("Update event for scheduled pod", "pod", klog.KObj(oldPod))
logger.V(4).Info("Update event for scheduled pod", "pod", klog.KObj(oldPod))
if err := sched.Cache.UpdatePod(logger, oldPod, newPod); err != nil { if err := sched.Cache.UpdatePod(logger, oldPod, newPod); err != nil {
logger.Error(err, "Scheduler cache UpdatePod failed", "pod", klog.KObj(oldPod)) logger.Error(err, "Scheduler cache UpdatePod failed", "pod", klog.KObj(oldPod))
} }
@@ -241,6 +245,7 @@ func (sched *Scheduler) deletePodFromCache(obj interface{}) {
logger.Error(nil, "Cannot convert to *v1.Pod", "obj", t) logger.Error(nil, "Cannot convert to *v1.Pod", "obj", t)
return return
} }
logger.V(3).Info("Delete event for scheduled pod", "pod", klog.KObj(pod)) logger.V(3).Info("Delete event for scheduled pod", "pod", klog.KObj(pod))
if err := sched.Cache.RemovePod(logger, pod); err != nil { if err := sched.Cache.RemovePod(logger, pod); err != nil {
logger.Error(err, "Scheduler cache RemovePod failed", "pod", klog.KObj(pod)) logger.Error(err, "Scheduler cache RemovePod failed", "pod", klog.KObj(pod))