github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

volumemanager: remove unneccesary closure

Browse Source
This commit is contained in:
Mike Danese
2018-03-31 09:00:43 -07:00
parent 3cb73605aa
commit f3922dff19
1 changed files with 17 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go
View File

@@ -129,13 +129,13 @@ func (dswp *desiredStateOfWorldPopulator) Run(sourcesReady config.SourcesReady,
glog.Infof("Desired state populator starts to run") glog.Infof("Desired state populator starts to run")
wait.PollUntil(dswp.loopSleepDuration, func() (bool, error) { wait.PollUntil(dswp.loopSleepDuration, func() (bool, error) {
done := sourcesReady.AllReady() done := sourcesReady.AllReady()
dswp.populatorLoopFunc()() dswp.populatorLoop()
return done, nil return done, nil
}, stopCh) }, stopCh)
dswp.hasAddedPodsLock.Lock() dswp.hasAddedPodsLock.Lock()
dswp.hasAddedPods = true dswp.hasAddedPods = true
dswp.hasAddedPodsLock.Unlock() dswp.hasAddedPodsLock.Unlock()
wait.Until(dswp.populatorLoopFunc(), dswp.loopSleepDuration, stopCh) wait.Until(dswp.populatorLoop, dswp.loopSleepDuration, stopCh)
} }
func (dswp *desiredStateOfWorldPopulator) ReprocessPod( func (dswp *desiredStateOfWorldPopulator) ReprocessPod(
@@ -149,8 +149,7 @@ func (dswp *desiredStateOfWorldPopulator) HasAddedPods() bool {
return dswp.hasAddedPods return dswp.hasAddedPods
} }
func (dswp *desiredStateOfWorldPopulator) populatorLoopFunc() func() { func (dswp *desiredStateOfWorldPopulator) populatorLoop() {
return func() {
dswp.findAndAddNewPods() dswp.findAndAddNewPods()
// findAndRemoveDeletedPods() calls out to the container runtime to // findAndRemoveDeletedPods() calls out to the container runtime to
@@ -168,7 +167,6 @@ func (dswp *desiredStateOfWorldPopulator) populatorLoopFunc() func() {
} }
dswp.findAndRemoveDeletedPods() dswp.findAndRemoveDeletedPods()
}
} }
func (dswp *desiredStateOfWorldPopulator) isPodTerminated(pod *v1.Pod) bool { func (dswp *desiredStateOfWorldPopulator) isPodTerminated(pod *v1.Pod) bool {