github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #105573 from sttts/sttts-etcd-storage-free-kv-early

Browse Source 
apiserver/storage: free etcd kv early in list decoding loop
This commit is contained in:
Kubernetes Prow Robot
2021-10-08 09:39:11 -07:00
committed by GitHub
parent 76c86ce324 dbf98e4266
commit f6facec054
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go
View File

@@ -763,7 +763,7 @@ func (s *store) List(ctx context.Context, key string, opts storage.ListOptions,
} }
// take items from the response until the bucket is full, filtering as we go // take items from the response until the bucket is full, filtering as we go
for _, kv := range getResp.Kvs { for i, kv := range getResp.Kvs {
if paging && int64(v.Len()) >= pred.Limit { if paging && int64(v.Len()) >= pred.Limit {
hasMore = true hasMore = true
break break
@@ -779,6 +779,9 @@ func (s *store) List(ctx context.Context, key string, opts storage.ListOptions,
return err return err
} }
numEvald++ numEvald++
// free kv early. Long lists can take O(seconds) to decode.
getResp.Kvs[i] = nil
} }
// indicate to the client which resource version was returned // indicate to the client which resource version was returned