github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feedback: leasecandidate clients

Browse Source
This commit is contained in:
Jefftree
2024-07-23 14:28:08 +00:00
parent 68226b0501
commit fac7581640
9 changed files with 64 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/kube-controller-manager/app/controllermanager.go
View File

@@ -293,7 +293,11 @@ func Run(ctx context.Context, c *config.CompletedConfig) error {
}
if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.CoordinatedLeaderElection) {
ver, err := semver.ParseTolerant(version.Get().String())
binaryVersion, err := semver.ParseTolerant(utilversion.DefaultComponentGlobalsRegistry.EffectiveVersionFor(utilversion.DefaultKubeComponent).BinaryVersion().String())
if err != nil {
return err
}
emulationVersion, err := semver.ParseTolerant(utilversion.DefaultComponentGlobalsRegistry.EffectiveVersionFor(utilversion.DefaultKubeComponent).EmulationVersion().String())
if err != nil {
return err
}
@@ -301,11 +305,11 @@ func Run(ctx context.Context, c *config.CompletedConfig) error {
// Start lease candidate controller for coordinated leader election
leaseCandidate, waitForSync, err := leaderelection.NewCandidate(
c.Client,
id,
"kube-system",
id,
"kube-controller-manager",
ver.FinalizeVersion(),
ver.FinalizeVersion(), // TODO(Jefftree): Use compatibility version when it's available
binaryVersion.FinalizeVersion(),
emulationVersion.FinalizeVersion(),
[]coordinationv1.CoordinatedLeaseStrategy{coordinationv1.OldestEmulationVersion},
)
if err != nil {