Make sure the ports is valid when parsing portString

2017-11-13 16:51:30 +08:00
parent bfe581d9e5
commit fe9303d7f7
2 changed files with 25 additions and 0 deletions
--- a/pkg/kubectl/service_basic_test.go
+++ b/pkg/kubectl/service_basic_test.go
@@ -115,6 +115,20 @@ func TestServiceBasicGenerate(t *testing.T) {
 			},
 			expectErr: false,
 		},
+		{
+			name:        "invalid-port",
+			tcp:         []string{"65536"},
+			clusterip:   "None",
+			serviceType: v1.ServiceTypeClusterIP,
+			expectErr:   true,
+		},
+		{
+			name:        "invalid-port-mapping",
+			tcp:         []string{"8080:-abc"},
+			clusterip:   "None",
+			serviceType: v1.ServiceTypeClusterIP,
+			expectErr:   true,
+		},
 		{
 			expectErr: true,
 		},