Updating EndpointSlices to use PublishNotReadyAddresses from Services.

The Service spec includes a PublishNotReadyAddresses field which has
been used by Endpoints to report all matching resources ready. This may
or may not have been the initial purpose of the field, but given the
desire to provide backwards compatibility with the Endpoints API here,
it seems to make sense to continue to provide the same functionality.

pkg/controller/endpointslice/utils_test.go

@@ -18,6 +18,7 @@ package endpointslice
 
 import (
 	"fmt"
+	"reflect"
 	"testing"
 	"time"
 
@@ -91,10 +92,11 @@ func TestPodToEndpoint(t *testing.T) {
 	}
 
 	testCases := []struct {
-		name             string
-		pod              *v1.Pod
-		node             *v1.Node
-		expectedEndpoint discovery.Endpoint
+		name                     string
+		pod                      *v1.Pod
+		node                     *v1.Node
+		expectedEndpoint         discovery.Endpoint
+		publishNotReadyAddresses bool
 	}{
 		{
 			name: "Ready pod",
@@ -112,6 +114,23 @@ func TestPodToEndpoint(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:                     "Ready pod + publishNotReadyAddresses",
+			pod:                      readyPod,
+			publishNotReadyAddresses: true,
+			expectedEndpoint: discovery.Endpoint{
+				Addresses:  []string{"1.2.3.5"},
+				Conditions: discovery.EndpointConditions{Ready: utilpointer.BoolPtr(true)},
+				Topology:   map[string]string{"kubernetes.io/hostname": "node-1"},
+				TargetRef: &v1.ObjectReference{
+					Kind:            "Pod",
+					Namespace:       ns,
+					Name:            readyPod.Name,
+					UID:             readyPod.UID,
+					ResourceVersion: readyPod.ResourceVersion,
+				},
+			},
+		},
 		{
 			name: "Unready pod",
 			pod:  unreadyPod,
@@ -128,6 +147,23 @@ func TestPodToEndpoint(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:                     "Unready pod + publishNotReadyAddresses",
+			pod:                      unreadyPod,
+			publishNotReadyAddresses: true,
+			expectedEndpoint: discovery.Endpoint{
+				Addresses:  []string{"1.2.3.5"},
+				Conditions: discovery.EndpointConditions{Ready: utilpointer.BoolPtr(true)},
+				Topology:   map[string]string{"kubernetes.io/hostname": "node-1"},
+				TargetRef: &v1.ObjectReference{
+					Kind:            "Pod",
+					Namespace:       ns,
+					Name:            readyPod.Name,
+					UID:             readyPod.UID,
+					ResourceVersion: readyPod.ResourceVersion,
+				},
+			},
+		},
 		{
 			name: "Ready pod + node labels",
 			pod:  readyPod,
@@ -174,8 +210,10 @@ func TestPodToEndpoint(t *testing.T) {
 
 	for _, testCase := range testCases {
 		t.Run(testCase.name, func(t *testing.T) {
-			endpoint := podToEndpoint(testCase.pod, testCase.node)
-			assert.EqualValues(t, testCase.expectedEndpoint, endpoint, "Test case failed: %s", testCase.name)
+			endpoint := podToEndpoint(testCase.pod, testCase.node, testCase.publishNotReadyAddresses)
+			if !reflect.DeepEqual(testCase.expectedEndpoint, endpoint) {
+				t.Errorf("Expected endpoint: %v, got: %v", testCase.expectedEndpoint, endpoint)
+			}
 		})
 	}
 }