github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
115,151 Commits 1 Branch 31 Tags 1,019 MiB
main
Commit Graph

6090 Commits

Author SHA1 Message Date
Rahul Rangith
3cf636b22e PR feedback 2023-01-17 10:21:41 -05:00
Rahul Rangith
c1cc18ccd5 Automatically recreate pvc when sts pod is stuck in pending 2023-01-17 10:21:41 -05:00
Kubernetes Prow Robot
7b01daba71
Merge pull request #115074 from yangjunmyfm192085/deleteklogv0-controller 
use klog instead of klog.V(0)--controller manager part
 2023-01-16 09:58:50 -08:00
Kubernetes Prow Robot
ed8cad1e80
Merge pull request #115056 from mimowo/podgc-do-not-add-condition-for-terminated-pods 
PodGC should not add DisruptionTarget condition for pods which are in terminal phase
 2023-01-16 03:04:50 -08:00
JunYang
29086e2b04 use klog instead of klog.V(0) 2023-01-14 21:15:50 +08:00
Andrew Sy Kim
3da0f1809c apiserver: update lease label key to apiserver.kubernetes.io/identity 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2023-01-13 15:37:22 -05:00
Kubernetes Prow Robot
9af5ae0365
Merge pull request #115030 from kannon92/remove-pod-error-job-tracking 
Update SyncJob with PodControllerError updates in job unit tests
 2023-01-13 12:08:14 -08:00
Kubernetes Prow Robot
70217a4083
Merge pull request #114944 from mimowo/fix-active-deadline-test 
Fix the job controller unit test for enforcing ActiveDeadlineSeconds
 2023-01-13 10:46:26 -08:00
Michal Wozniak
3833c0c349 PodGC should not add DisruptionTarget condition for pods which are in terminal phase 2023-01-13 18:28:44 +01:00
kannon92
4890928b78 tracking with finalizers is the default way for the job controller 2023-01-13 16:48:35 +00:00
kannon92
3a838033f8 Update SyncJob with PodControllerError updates in job unit tests 2023-01-13 16:39:18 +00:00
Michal Wozniak
7065b42bb2 Fix the job controller unit test for enforcing ActiveDeadlineSeconds 2023-01-13 16:48:15 +01:00
Kubernetes Prow Robot
c0c386b9c9
Merge pull request #114516 from nikhita/job-backoff-fix 
pkg/controller/job: re-honor exponential backoff delay
 2023-01-13 07:36:40 -08:00
Kubernetes Prow Robot
1b8692ce46
Merge pull request #114296 from cbroglie/concurrent-monitor-node-health 
controller/nodelifecycle: Make monitorNodeHealth process nodes concurrently
 2023-01-12 12:42:54 -08:00
Nikhita Raghunath
fd8d92a29d pkg/controller/job: re-honor exponential backoff 
This commit makes the job controller re-honor exponential backoff for
failed pods. Before this commit, the controller created pods without any
backoff. This is a regression because the controller used to
create pods with an exponential backoff delay before (10s, 20s, 40s ...).

The issue occurs only when the JobTrackingWithFinalizers feature is
enabled (which is enabled by default right now). With this feature, we
get an extra pod update event when the finalizer of a failed pod is
removed.

Note that the pod failure detection and new pod creation happen in the
same reconcile loop so the 2nd pod is created immediately after the 1st
pod fails. The backoff is only applied on 2nd pod failure, which means
that the 3rd pod created 10s after the 2nd pod, 4th pod is created 20s
after the 3rd pod and so on.

This commit fixes a few bugs:

1. Right now, each time `uncounted != nil` and the job does not see a
_new_ failure, `forget` is set to true and the job is removed from the
queue. Which means that this condition is also triggered each time the
finalizer for a failed pod is removed and `NumRequeues` is reset, which
results in a backoff of 0s.

2. Updates `updatePod` to only apply backoff when we see a particular
pod failed for the first time. This is necessary to ensure that the
controller does not apply backoff when it sees a pod update event
for finalizer removal of a failed pod.

3. If `JobsReadyPods` feature is enabled and backoff is 0s, the job is
now enqueued after `podUpdateBatchPeriod` seconds, instead of 0s. The
unit test for this check also had a few bugs:
    - `DefaultJobBackOff` is overwritten to 0 in certain unit tests,
    which meant that `DefaultJobBackOff` was considered to be 0,
    effectively not running any meaningful checks.
    - `JobsReadyPods` was not enabled for test cases that ran tests
    which required the feature gate to be enabled.
    - The check for expected and actual backoff had incorrect
    calculations.
 2023-01-12 20:34:10 +05:30
Christopher Broglie
3c88de52c8 controller/nodelifecycle: Make monitorNodeHealth process nodes concurrently 
Marking the pods not ready on a node requires looping over them and
updating each pod's status one at a time. This is performed serially,
and can take a while if we're processing each node serially as well.

Since the time is spent waiting on io, there's an opportunity to go
faster by processing multiple nodes concurrently. This change modifies
the loop to process nodes in parallel, using the same number of workers
as doNodeProcessingPassWorker.

This change also introduces histogram metrics to better observe
monitorNodeHealth.
 2023-01-11 12:34:39 -08:00
kannon92
6dfaeff33c Remove Legacy Job Tracking 2023-01-10 14:52:54 +00:00
Kubernetes Prow Robot
e7549eae87
Merge pull request #114905 from kannon92/sync-job-test-fix 
Fix SyncPastDeadlineJobFinished for enabling finalizer path
 2023-01-09 12:47:28 -08:00
kannon92
0362c67859 Fix SyncPastDeadlineJobFinished for enabling finalizer path 2023-01-09 17:12:52 +00:00
Aldo Culquicondor
4c1b95ddfa
Ensure job is up to date in informer cache in test 
The fake client doesn't guarantee that the informer cache is updated.
If it's not up-to-date, the controller always tries to set the
StartTime, leading to a broken test.

Change-Id: I71f26d46ea44beff88f0d03517985348654aec95
 2023-01-09 10:53:19 -05:00
Kubernetes Prow Robot
901c1de5ea
Merge pull request #114870 from mattcary/mutation 
Avoid mutation of PVC in stateful set controller shared cache
 2023-01-05 23:16:09 -08:00
Matthew Cary
ed18ab54ba Avoid mutation of PVC in stateful set controller shared cache 
Change-Id: Ieb8e443e460150d16524ca1c1fb3770f546b2c28
 2023-01-05 18:09:05 -08:00
Kubernetes Prow Robot
492637878f
Merge pull request #111660 from pacoxu/key-encipherment-v1.26 
Key encipherment usage  v1.27
 2023-01-04 15:51:57 -08:00
Michal Wozniak
c3d0e8ff05 Fix clearing rate limiter in disruption controller 2023-01-03 15:06:06 +01:00
Kushagra
80384bbb55 spelling mistake rectified 2022-12-29 17:55:17 +00:00
Kushagra
f380ef8b61 Misleading message when there are no metrics. 2022-12-29 10:57:43 +00:00
Paco Xu
160f015ef4 kubelet: add key encipherment usage only if it is rsa key 
remove allowOmittingUsageKeyEncipherment as it is always true

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
 2022-12-27 16:04:25 +08:00
Kubernetes Prow Robot
45f14a93f1
Merge pull request #113787 from gjkim42/update-daemonset-status-despite-error 
Update daemonSet status even if syncDaemonSet fails
 2022-12-22 15:49:25 -08:00
Kubernetes Prow Robot
d1c715a982
Merge pull request #113834 from atiratree/sts-handle-delete-pod-error 
statefulset: handle API error on pod deletion
 2022-12-22 08:17:26 -08:00
Harsha Narayana
208c3868cf
job controller: refactored job controller to be able to inject FakeClock for Unit Test 2022-12-20 21:29:24 +05:30
Jordan Liggitt
78cb3862f1
Fix indentation/spacing in comments to render correctly in godoc 2022-12-17 23:27:38 -05:00
Kubernetes Prow Robot
7f7bf68c7c
Merge pull request #111178 from lucming/cleanup 
clean up code
 2022-12-16 19:17:52 -08:00
Kubernetes Prow Robot
9edd4d86c8
Merge pull request #114522 from zshihang/master 
lock LegacyServiceAccountTokenNoAutoGeneration
 2022-12-16 14:24:32 -08:00
Kubernetes Prow Robot
f11e9aaf10
Merge pull request #113929 from howardjohn/endpointslice/use-optimized-set 
endpoints: remove obsolete ServiceSelectorCache
 2022-12-16 14:24:09 -08:00
Shihang Zhang
4fd09a06d6 lock LegacyServiceAccountTokenNoAutoGeneration 2022-12-16 10:45:35 -08:00
Daniel Smith
8100efc7b3 Enable propagration of HasSynced 
* Add tracker types and tests
* Modify ResourceEventHandler interface's OnAdd member
* Add additional ResourceEventHandlerDetailedFuncs struct
* Fix SharedInformer to let users track HasSynced for their handlers
* Fix in-tree controllers which weren't computing HasSynced correctly
* Deprecate the cache.Pop function
 2022-12-14 18:43:33 +00:00
bzsuni
16fcb1c708 optimise some code 2022-12-13 09:56:36 +08:00
Kubernetes Prow Robot
741bd5c382
Merge pull request #113947 from mowangdk/chore/change_adcontroller_log_level 
Lower volume attached touch log level
 2022-12-12 17:41:51 -08:00
John Howard
d9f2cc0c95 endpoints: remove obsolete ServiceSelectorCache 
Since https://github.com/kubernetes/kubernetes/pull/112648, we can
efficiently handle selectors from pre-existing `map[string]string`,
making the cache obsolete.

Benchmark:

```
name                         old time/op    new time/op    delta
GetPodServiceMemberships-48     189µs ± 1%     193µs ± 1%  +2.10%  (p=0.000 n=10+10)

name                         old alloc/op   new alloc/op   delta
GetPodServiceMemberships-48    59.0kB ± 0%    58.9kB ± 0%  -0.09%  (p=0.000 n=9+9)

name                         old allocs/op  new allocs/op  delta
GetPodServiceMemberships-48     1.02k ± 0%     1.02k ± 0%    ~     (all equal)
```
 2022-12-12 08:00:48 -08:00
Kubernetes Prow Robot
2118bc8aec
Merge pull request #114155 from aojea/mirroring_repack 
endpointslicemirroring handle endpoints with multiple subsets
 2022-12-10 07:53:42 -08:00
Kubernetes Prow Robot
9303ea836f
Merge pull request #114076 from akhilles/remove-unused-var 
Remove unused `numExistingEndpoints` variable
 2022-12-10 06:04:25 -08:00
Kubernetes Prow Robot
92ffe94592
Merge pull request #114033 from Octopusjust/k8s-pr14 
pkg/controller/deployment/util/deployment_util.go:Improving test cove…
 2022-12-10 06:03:55 -08:00
Antonio Ojea
ef6d9edea5 endpointslicemirroring handle endpoints with multiple subsets 
Endpoints generated by the endpoints controller are in the canonical
form, however, custom endpoints can not be in canonical format
(there was a time they were canonicalized in the apiserver, but this
caused performance issues because the endpoint controller kept
updating them since the created endpoint were different than the
stored one due to the canonicalization)

There are cases where a custom endpoint may generate multiple slices
due to the controller, per example, when the same address is present
in different subsets.

The endpointslice mirroring controller should canonicalize the
endpoints subsets before start processing them to be consistent
on the slices generated, there is no risk of hotlooping because
the endpoint is only used as input.

Change-Id: I2a8cd53c658a640aea559a88ce33e857fa98cc5c
 2022-12-10 11:44:10 +00:00
Kubernetes Prow Robot
0cd13e573c
Merge pull request #113196 from mimowo/job-controller-reviewer 
Self-nominate mimowo as a reviewer for pkg/controller/job & test/integration/job packages
 2022-12-10 02:01:39 -08:00
Gunju Kim
69fcde750a
Update daemonSet status even if syncDaemonSet fails 
This ensures that the daemonset controller updates daemonset statuses in
a best-effort manner even if syncDaemonSet fails.

In order to add an integration test, this also replaces
`cmd/kube-apiserver/app/testing.StartTestServer` with
`test/integration/framework.StartTestServer` and adds
`setupWithServerSetup` to configure the admission control of the
apiserver.
 2022-12-10 11:45:56 +09:00
Kubernetes Prow Robot
63a01a5465
Merge pull request #112260 from aryan9600/cidr-metrics 
Add metric for max no. of CIDRs available
 2022-12-09 15:42:59 -08:00
Kubernetes Prow Robot
da3d98277b
Merge pull request #111839 from ialidzhikov/cleanup/pkg-controller 
pkg/controller: Replace deprecated func usage from the `k8s.io/utils/pointer` pkg
 2022-12-09 15:42:37 -08:00
Kubernetes Prow Robot
4557c694ef
Merge pull request #111683 from lucming/code-cleanup5 
reorganize some logic of controller_utils.go
 2022-12-09 15:42:21 -08:00
Kubernetes Prow Robot
5fe12aae11
Merge pull request #111207 from lucming/code-cleanup2 
Reduce indentation in daemonset controller code
 2022-12-09 15:41:41 -08:00
Mengjiao Liu
c28b287253 clusterroleaggregation: use contextual logging 2022-12-09 11:02:47 +08:00
Sanskar Jaiswal
b501d6036a add metric for max no. of CIDRs that can be allocated from MultiCIDRSet 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
 2022-12-05 15:18:45 +00:00
Sanskar Jaiswal
37f4d4624b add metric for max no. of CIDRs that can be allocated from CidrSet 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
 2022-12-05 15:18:45 +00:00
ialidzhikov
aede3fbf40 pkg/controller: Replace deprecated func usage from the k8s.io/utils/pointer pkg 2022-11-23 17:40:23 +02:00
songxiao-wang87
9ae5af4b6a StorageVersionGC logger 
Signed-off-by: songxiao-wang87 <wang.xiaosong23@zte.com.cn>
 2022-11-23 03:20:12 +00:00
Akhil Velagapudi
70d31ea917 Remove unused numExistingEndpoints variable 2022-11-23 00:54:50 +00:00
ZhangYu
d61849e800 pkg/controller/deployment/util/deployment_util.go:Improving test coverage 2022-11-22 10:12:58 +08:00
mowangdk
bf244d3046 Lower volume attached touch log level 2022-11-16 16:49:07 +08:00
Michelle Au
524a8b32a6 add sig-storage reviewers, remove inactive sig-storage reviewers, remove redundant owners files 2022-11-15 23:51:57 +00:00
Aldo Culquicondor
7dc36bdf82
Wait for Pods to finish before considering Failed in Job (#113860) 
* Wait for Pods to finish before considering Failed

Limit behavior to feature gates PodDisruptionConditions and
JobPodFailurePolicy and jobs with a podFailurePolicy.

Change-Id: I926391cc2521b389c8e52962afb0d4a6a845ab8f

* Remove check for unsheduled terminating pod

Change-Id: I3dc05bb4ea3738604f01bf8cb5fc8cc0f6ea54ec
 2022-11-15 09:44:53 -08:00
Kubernetes Prow Robot
84a55ad8d2
Merge pull request #113147 from andrewsykim/storageversiongc-controller-tests 
add unit tests for storageversiongc controller
 2022-11-14 10:56:41 -08:00
Michal Wozniak
a910ca563b Fix race conditions 2022-11-14 10:11:26 +01:00
Michal Wozniak
3b5c3acd61 Improve stability if the taint_manager tests 2022-11-13 19:40:18 +01:00
Kubernetes Prow Robot
d1c0171aed
Merge pull request #111023 from pohly/dynamic-resource-allocation 
dynamic resource allocation
 2022-11-11 16:21:56 -08:00
Aldo Culquicondor
bc5afaf580
Fix match onExitCodes when Pod is not terminated 
Change-Id: Id1f9c46f8b6a12115577a1fadb12adc580c9ba6a
 2022-11-11 10:05:11 -05:00
Kubernetes Prow Robot
d7bff1c809
Merge pull request #111577 from brianpursley/troubleshoot-unit-test-flake 
Add logging for reconciler unit test
 2022-11-11 00:44:09 -08:00
Filip Křepinský
ec0b200f3d statefulset: handle API error on pod deletion 
when new revision is being rolled out
 2022-11-10 22:47:23 +01:00
Patrick Ohly
0133df3929 kube-controller-manager: add ResourceClaim controller 
The controller uses the exact same logic as the generic ephemeral inline volume
controller, just for inline ResourceClaimTemplate -> ResourceClaim.

In addition, it supports removal of pods from the ReservedFor field when those
pods are known to not need the claim anymore. At the moment, only this special
case is supported. Removal of arbitrary objects would imply granting full read
access to all types to determine whether a) an object is gone and b) if the
current incarnation is the one which is listed in ReservedFor. This may get
added later.
 2022-11-10 20:23:50 +01:00
Patrick Ohly
b87530af4f kube-controller-manager: clone resource controller from volume/ephemeral 2022-11-10 20:23:50 +01:00
Andrew Sy Kim
dba7740115 pkg/controller/storageversiongc: add constructor function newKubeApiserverLease 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-09 15:52:47 -05:00
Kubernetes Prow Robot
ff19efdf9b
Merge pull request #112744 from pwschuurman/statefulset-slice-impl 
Add implementation of KEP-3335, StatefulSetSlice
 2022-11-09 11:12:28 -08:00
wangxiaojian
02db35ab1c
Optimize case conditions 2022-11-10 00:49:20 +08:00
Andrew Sy Kim
1320adc83f pkg/controller/storageversiongc: add comments for Test_StorageVersionUpdatedWithAllEncodingVersionsEqualOnLeaseDeletion, Test_StorageVersionUpdatedWithDifferentEncodingVersionsOnLeaseDeletion, Test_StorageVersionContainsInvalidLeaseID, and Test_StorageVersionDeletedOnLeaseDeletion 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-09 11:49:07 -05:00
Andrew Sy Kim
2fb8329eee pkg/controller/storageversiongc: add unit tests for storageversiongc controller 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-09 11:48:20 -05:00
Michal Wozniak
c803892bd8 Enable the feature into beta 2022-11-09 09:02:40 +01:00
Kubernetes Prow Robot
694698ca38
Merge pull request #110485 from Octopusjust/k8s-pr 
cidr_set.go :  fix several typo
 2022-11-08 13:51:00 -08:00
Peter Schuurman
9258cb4041 Fix typo in function emptyInvariants() 2022-11-08 07:48:10 -08:00
Peter Schuurman
366997951b Update doc comments and change name of feature gate 2022-11-08 07:48:10 -08:00
Peter Schuurman
8a9c126eca Small updates and comment fixes 2022-11-08 07:48:09 -08:00
Peter Schuurman
7b3d77a41a Adding implementation of KEP-3335, StatefulSetSlice 2022-11-08 07:48:00 -08:00
Maciej Szulik
3c93d540c6
Revert "Update daemonSet status even if syncDaemonSet fails" 
This reverts commit 2ee024a4df.
 2022-11-08 15:01:09 +01:00
Kubernetes Prow Robot
aef9a37df9
Merge pull request #113010 from soltysh/promote_job_metrics 
Promote job metrics
 2022-11-08 03:16:32 -08:00
Kubernetes Prow Robot
3451501c2e
Merge pull request #112737 from gjkim42/cleanup-defer-from-sts 
StatefulSet: Cleanup the complex defer function updating the status
 2022-11-08 03:16:21 -08:00
Kubernetes Prow Robot
0e530f44af
Merge pull request #113544 from LiorLieberman/topology-hints-events 
Added: publishing events for topologyAwareHints changes
 2022-11-07 16:01:15 -08:00
Kubernetes Prow Robot
47952e0917
Merge pull request #112360 from mimowo/handling-pod-failures-beta-kubelet 
Add pod disruption conditions for kubelet-initiated failures
 2022-11-07 16:00:40 -08:00
Kubernetes Prow Robot
b4f42864f5
Merge pull request #112127 from gjkim42/update-status-despite-error 
Update daemonSet status even if syncDaemonSet fails
 2022-11-07 16:00:28 -08:00
Gunju Kim
6559050ee1
StatefulSet: Cleanup the complex defer function updating the status 
In the long term, the complex defer function makes the code harder to
maintain as code after it should take that into account. This removes
the complex defer function updating the status of a statefulset.
 2022-11-08 08:39:42 +09:00
Kubernetes Prow Robot
1c230d519e
Merge pull request #113262 from jsafrane/rework-reconstruction 
Rework volume reconstruction
 2022-11-07 12:42:29 -08:00
Lior Lieberman
4faede03fa Added events publishing for topologyHints changes 2022-11-07 19:45:40 +00:00
Maciej Szulik
39d9981dc2
Promote job-related metrics to stable 2022-11-07 19:28:40 +01:00
Kubernetes Prow Robot
ac95e5b701
Merge pull request #113510 from alculquicondor/finalizers-stable 
Graduate JobTrackingWithFinalizers to stable
 2022-11-07 08:06:41 -08:00
Michal Wozniak
52cd6755eb Add pod disruption conditions for kubelet initiated failures 2022-11-07 11:23:22 +01:00
Kubernetes Prow Robot
c519bc02e8
Merge pull request #112011 from pbeschetnov/ambiguous-selectors 
Add ambiguous selector check to HPA
 2022-11-06 21:08:16 -08:00
Aldo Culquicondor
4948918155
Graduate JobTrackingWithFinalizers to stable 
Change-Id: Ifc749a85b1270c0155ac511b91d4681d53236820
 2022-11-04 17:05:53 -04:00
Kubernetes Prow Robot
b20ddbd75a
Merge pull request #113351 from andrewsykim/endpointslice-terminating-ga 
Promote EndpointSliceTerminatingCondition to GA
 2022-11-04 09:36:39 -07:00
Kubernetes Prow Robot
ead17f3dc8
Merge pull request #113008 from soltysh/promote_cronjob_metrics 
Promote cronjob_job_creation_skew metric to stable
 2022-11-04 09:36:27 -07:00
Kubernetes Prow Robot
20ffe3bbf9
Merge pull request #111607 from tnqn/reduce-redundant-index 
Remove duplicate and unused index from PodIndexer
 2022-11-04 09:36:16 -07:00
Maciej Szulik
4af97e599a
Promote cronjob_job_creation_skew metric to stable 2022-11-04 13:55:32 +01:00
Pavel Beschetnov
caddfdd040 Add pod ambiguous selector check 2022-11-04 12:49:20 +00:00
Wojciech Tyczyński
e0002c7e26 Clean shutdown of nodeipam controller 2022-11-04 10:34:36 +01:00
Andrew Sy Kim
e282b6c6b3 pkg/controller/endpointslice: remove all references to the EndpointSliceTerminatingCondition feature gate 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-03 20:26:51 -04:00
Kubernetes Prow Robot
d802bd56ac
Merge pull request #113559 from wojtek-t/clean_shutdown_5 
Clean shutdown of few more integration tests
 2022-11-03 09:01:45 -07:00
Kubernetes Prow Robot
38bcc0c153
Merge pull request #113519 from xing-yang/node_shutdown_metrics 
Add metric deleting_pods_total
 2022-11-03 09:01:37 -07:00
Jan Safranek
fc245b339b Refactor ConstructVolumeSpec 
Return a struct from ConstructVolumeSpec to be able to add more fields to
it later.
 2022-11-03 16:55:13 +01:00
Kubernetes Prow Robot
98742f9d77
Merge pull request #110747 from harshanarayana/cleanup/GIT-110737/logging-improvements 
structured-logging: replace KObjs with KObjSlice for logging
 2022-11-03 00:49:34 -07:00
Kubernetes Prow Robot
4b2aa18bde
Merge pull request #113478 from alculquicondor/finalizer_metric 
Add benchmark for large indexed job
 2022-11-02 16:29:13 -07:00
xing-yang
85f5583684 Address review comments 2022-11-02 22:40:02 +00:00
Wojciech Tyczyński
c84c27b6ac Clean shutdown of event broadcaster in controllers 2022-11-02 21:08:43 +01:00
xing-yang
b4e6bed525 Moved Register() to init() 2022-11-02 19:54:38 +00:00
Aldo Culquicondor
5e03865f65
Add benchmark for large indexed job 
Change-Id: I556f0cce5842699c98654cfb5a66e7c8d63b2e2e
 2022-11-02 11:56:26 -04:00
xing-yang
8ce37fde95 Add metric deleting_pods_total 2022-11-02 11:01:47 +00:00
Kubernetes Prow Robot
114a54c098
Merge pull request #113450 from neogopher/pv-controller-fix-log-message 
docs: Correct the log message for pv controller to make it more accurately descriptive
 2022-11-01 19:59:19 -07:00
Kubernetes Prow Robot
9b5fa57654
Merge pull request #113358 from mengjiao-liu/fix-StatefulSetAutoDeletePVC 
StatefulSet: fix kube-controller-manager panic due to StatefulSetPersistentVolumeClaimRetentionPolicy being nil
 2022-11-01 08:24:45 -07:00
Michał Woźniak
3628532311
Extend metrics with the new labels (#113324) 
* Extend job metrics

* Refactor TestMetrics to extract its checks into dedicated tests per feature
 2022-10-31 08:50:45 -07:00
neogopher
400c8f71cf docs: Correct the log message for pv controller to make it more accurately descriptive 2022-10-30 23:17:55 +05:30
Kubernetes Prow Robot
3c9928e4f8
Merge pull request #113304 from mimowo/handling-pod-failures-beta-ssa 
Use SSA to add pod failure conditions
 2022-10-28 07:32:32 -07:00
Kubernetes Prow Robot
f9f9f0107d
Merge pull request #112544 from abhijit-dev82/master 
HPA : Enhance error message to capture POD details
 2022-10-28 04:14:30 -07:00
Michal Wozniak
fea883687f SSA to add pod failure conditions - ready for review 2022-10-27 18:21:33 +02:00
Mengjiao Liu
b9740694f3 StatefulSet: fix kube-controller-manager panic due to StatefulSetPersistentVolumeClaimRetentionPolicy being nil 2022-10-27 23:13:36 +08:00
Roman Bednar
42422a1d16 add a metric for retroactive sc errors 2022-10-25 15:09:16 +02:00
Kubernetes Prow Robot
245d59273c
Merge pull request #113136 from jprzychodzen/kcm-remove-race-condition 
NodeLifecycleController: Remove race condition
 2022-10-24 15:48:34 -07:00
Jakub Przychodzeń
de25c5fdcf NodeLifecycleController: Remove race condition 
Patch request does not support RV by default, we need to include them explicitly and patching lists actually overwrites whole field. It means that there is a race condition, in which we can overwrite changes to taints that happened between GET and PATCH requests.
 2022-10-24 19:36:58 +00:00
Aldo Culquicondor
12d308f5c4 Add metric for terminated pods with tracking finalizer 
Change-Id: I26f3169588c30ed82250cb7baff8e277f8d13bb7
 2022-10-20 11:35:20 -04:00
Michal Wozniak
b1e575aaf7 Self-nominate mimowo as a reviewer for pkg/controller/job & test/integration/job 
I think I'm ready to start review and LGTM code changes within this
package, but not necessarily for the entire sig-apps.

My PRs to the packages:
https://github.com/kubernetes/kubernetes/pull/110292
https://github.com/kubernetes/kubernetes/pull/111113
https://github.com/kubernetes/kubernetes/pull/112948

PRs to the packages I contributed reviews to:
https://github.com/kubernetes/kubernetes/pull/113166
https://github.com/kubernetes/kubernetes/pull/110294
 2022-10-20 09:22:35 +02:00
Kubernetes Prow Robot
962235c86a
Merge pull request #110559 from danishprakash/danish-default-storageclass 
pkg/admission/storageclass: pick one storageclass conditionally if >1 present
 2022-10-19 13:56:55 -07:00
Kubernetes Prow Robot
bf14677914
Merge pull request #112546 from oscr/the-the 
grammar: replace all occurrences of "the the" with "the"
 2022-10-19 10:03:02 -07:00
danishprakash
f10f4d372c
pv_controller: update tests for multiple storageclasses 
Signed-off-by: danishprakash <grafitykoncept@gmail.com>
 2022-10-19 09:33:44 +05:30
Kubernetes Prow Robot
23721935d3
Merge pull request #113129 from chaunceyjiang/pr_remove_redundant_conversion 
Remove redundant type conversion
 2022-10-18 10:23:19 -07:00
Kubernetes Prow Robot
deb6712358
Merge pull request #113137 from RomanBednar/restart-sync-unbound 
restart claim sync when PVC is updated
 2022-10-18 07:33:19 -07:00
chaunceyjiang
d2b372e029 Remove redundant type conversion 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
 2022-10-18 14:37:40 +08:00
Kubernetes Prow Robot
85643c0f93
Merge pull request #108501 from zroubalik/hpa 
add `--concurrent-horizontal-pod-autoscaler-syncs` flag to kube-controller-manager
 2022-10-17 14:13:18 -07:00
Kubernetes Prow Robot
28ced69b76
Merge pull request #113054 from logicalhan/proxy-metric 
remove rate limiter metric as it is not in use
 2022-10-17 11:09:18 -07:00
Zbynek Roubalik
1cefcdea2d add --concurrent-horizontal-pod-autoscaler-syncs flag to kube-controller-manager 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
 2022-10-17 17:39:31 +02:00
Roman Bednar
f5693a4008 restart claim sync when PVC is updated 
We should not rely on syncUnboundClaim() to do nothing after it updates
PVC with a default storage class until next re-sync but instead restart
the sync explicitly to make sure we hit isDelayBindingMode() and
findBestMatchForClaim() immediately right after the PVC update.
 2022-10-17 14:05:39 +02:00
Abhijit
ac56e6f34e HPA : Enhance error message to capture POD details 
HPA : Enhance error message to capture POD details
 2022-10-17 14:21:28 +05:30
Kubernetes Prow Robot
5e775e3c83
Merge pull request #112558 from aojea/ipam_owners 
update sig-network reviewers/approvers on controller manager
 2022-10-14 10:54:46 -07:00
Kubernetes Prow Robot
5c36a3c372
Merge pull request #110902 from 0xff-dev/master 
convert int32 to pointer using library function
 2022-10-14 08:48:46 -07:00
Oscar Utbult
e4f776f230 grammar: replace all occurrences of "the the" with "the" 2022-10-14 09:03:14 +02:00
Han Kang
2bbd445f50 remove rate limiter metric as it is not in use 
Change-Id: I91157653e3860eeecc3f572aee88da6ffc65faed
 2022-10-13 13:07:11 -07:00
Michal Wozniak
b64e5b2d15 Fix the occasional double-counting job_finished_total metric 
The reason for the issue is that the metrics were bumped before the
final job status update. In case the update failed the path was
repeated by the next syncJob leading to double-counting of the metrics.

The solution is to delay recording metrics and broadcasting events
after the job status update succeeds.
 2022-10-13 17:23:03 +02:00
Gunju Kim
2ee024a4df
Update daemonSet status even if syncDaemonSet fails 2022-10-11 22:55:50 +09:00
Kubernetes Prow Robot
afebf498d7
Merge pull request #111314 from BinacsLee/binacs/cleanup-use-clone-to-avoid-interim-slice 
cleanup: use sets.Clone() to avoid interim slice
 2022-10-04 07:34:22 -07:00
Kubernetes Prow Robot
4245895261
Merge pull request #111463 from pbetkier/hpa-comment-fix 
Fix comment in HPA's scale event replicaChange
 2022-09-30 04:08:28 -07:00
Wojciech Tyczyński
57c95fbfa1 Lock ServerSideApply feature to true 2022-09-27 13:48:28 +02:00
Kubernetes Prow Robot
ed8c302cc6
Merge pull request #112692 from liggitt/dot-cleanup 
Drop DOT dependency
 2022-09-23 13:02:06 -07:00
Jordan Liggitt
8221960b65
Reimplement GC dot graph dumping without gonum library 2022-09-23 13:12:33 -04:00
Michal Wozniak
bb561e0324 Fix controller policy and improve logging of related errors 
Improve error logging from timed workers which are used for pod eviction

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
 2022-09-23 16:53:32 +02:00
Kubernetes Prow Robot
3a0dbe5749
Merge pull request #112335 from piotrnosek/fixcustomcrd 
Fix HPA E2E CustomResourceDefinition test
 2022-09-22 11:01:06 -07:00
Kubernetes Prow Robot
2dba4034f8
Merge pull request #112554 from kushagra98/variable-name-change 
variable name change for better understanding
 2022-09-22 03:37:02 -07:00
Kushagra
dc321b4d2a requeted changes: fix variables in test cases 2022-09-22 09:17:15 +00:00
Kushagra
01b553145c requested changes: fix return type variables 2022-09-22 08:59:02 +00:00