Commit Graph

19 Commits

Author SHA1 Message Date
Dr. Stefan Schimanski
012b085ac8 pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
Jordan Liggitt
b8155e107c
Limit 52-character cronjob name validation to create 2017-09-24 23:56:27 -04:00
Kubernetes Submit Queue
d85f4c26e0 Merge pull request #52733 from julia-stripe/validate-cronjob-name-length
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..

Validate that cronjob names are 52 characters or less

**What this PR does / why we need it**:

Right now when you create a cronjob with a name longer than 52 characters, creation will succeed but the cronjob controller will create Job objects with names longer than 63 characters. Jobs cannot have names longer than 63 characters, so the cronjob will never be able to run any jobs.

**Which issue this PR fixes** : Fixes #50850 

**Special notes for your reviewer**:

**Release note**:
```release-note
Validate that cronjob names are 52 characters or less
```
2017-09-22 19:22:20 -07:00
Julia Evans
e30237b869 Validate that cronjob names are less than 52 characters 2017-09-19 13:39:33 -07:00
cedric lamoriniere
3989b18586 update API v1 Job object
Add new fields in api v1.JobSpec object for backoff policy
- BackoffLimit
- FailedPodsLimit

fixes: https://github.com/kubernetes/community/pull/583
2017-09-01 21:01:29 +02:00
peay
2b33de0684 Modify CronJob API to add job history limits, cleanup jobs in controller 2017-02-25 06:51:54 -05:00
deads2k
dd7cd951ce move meta/v1/validation to apimachinery 2017-01-16 13:40:13 -05:00
deads2k
6a4d5cd7cc start the apimachinery repo 2017-01-11 09:09:48 -05:00
jianhuiz
0e5d7c3fc0 fix swapped new/old job obj for validating object meta update 2016-12-16 17:17:34 -08:00
Clayton Coleman
3454a8d52c
refactor: update bazel, codec, and gofmt 2016-12-03 19:10:53 -05:00
Clayton Coleman
5df8cc39c9
refactor: generated 2016-12-03 19:10:46 -05:00
Maciej Szulik
41d88d30dd Rename ScheduledJob to CronJob 2016-11-07 10:14:12 +01:00
Maciej Szulik
0163b0a3c6 Remove hacks from ScheduledJobs cron spec parsing
Previusly github.com/robfig/cron library did not allow passing cron spec without
seconds. Previous commit updates the library, which has additional
method ParseStandard which follows the standard cron spec, iow. minute,
hour, day of month, month, day of week.
2016-09-14 20:30:20 +02:00
Maciej Szulik
43612afaae Set Job's labels from PodTemplateSpec if none are specified 2016-09-06 14:12:52 +02:00
Maciej Szulik
902ecd85fc Remove seconds from scheduled jobs cron format 2016-08-10 11:15:33 +02:00
David McMahon
ef0c9f0c5b Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
Maciej Szulik
d8b9495ea0 Change suspend to be pointer for ScheduledJob and modify validation to forbid setting job selectors 2016-05-30 15:43:23 +02:00
Maciej Szulik
adc890a57e ScheduledJob validation & defaults 2016-05-21 15:48:40 +02:00
Maciej Szulik
a3b4447305 Move internal types of job from pkg/apis/extensions to pkg/apis/batch 2016-04-25 11:03:54 +02:00