Commit Graph

9078 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
2343b8a68b
Merge pull request #95872 from 22dm/kube-proxy-comment-fix
Fix the kube-proxy document
2020-11-08 19:23:37 -08:00
liuhongyu
d38ff93e4b remove kube-proxy/config/v1alpha1 from .golint_failures 2020-11-07 11:02:16 +08:00
Marcio Caroso
4b8b9c92bf Fix go lint on folder apimachinery/pkg/runtime/serializer/json 2020-11-06 20:45:27 -03:00
Javier Diaz-Montes
c8da7128eb Ensuring default DNS cluster-domain of Kubelet is cluster.local
Currently e2e tests run under test-e2e-node have a cluster-domain
equals to "". This change makes test-e2e-node consistent with other
e2e tests. For example, in hack/ginkgo-e2e.sh, cluster-domain
defaults to cluster.local and it can be changed by defining KUBE_DNS_DOMAIN.
2020-11-06 13:42:13 -05:00
cici37
895a0a8d5e Adding config extension to CCM. 2020-11-06 02:42:44 -08:00
Kubernetes Prow Robot
226ea6b49d
Merge pull request #96231 from deads2k/clean-up-feature
update features to indicate beta in comment
2020-11-05 15:17:04 -08:00
Kubernetes Prow Robot
38f14f3874
Merge pull request #95876 from saschagrunert/proto
Propose seccomp/apparmor protobuf type definitions for CRI graduation
2020-11-05 06:31:08 -08:00
David Eads
73f7a9b394 update features to indicate beta in comment 2020-11-05 07:21:19 -05:00
Kubernetes Prow Robot
1328d8c8c6
Merge pull request #96235 from PurelyApplied/exclude-levee-in-verify-all
Exclude KEP-1933 from verify-all.sh until after alpha status.
2020-11-04 18:11:25 -08:00
Kubernetes Prow Robot
ff225efc10
Merge pull request #96095 from masap/local_up_cluster4
local-up-cluster.sh: Use config file instead of flags for kubelet
2020-11-04 13:25:30 -08:00
Patrick Rhomberg
e67ab309b7 Exclude KEP-1933 from verify-all.sh until after alpha status. 2020-11-04 20:18:57 +00:00
Kubernetes Prow Robot
6a3fd8f3d7
Merge pull request #96204 from knight42/fix/curl-bearer-token
fix: pass bearer token to curl using --header instead of --oauth2-bearer
2020-11-04 10:38:53 -08:00
knight42
00e4234cc9
fix: pass bearer token to curl using -H instead of --oauth2-bearer
The flag `--oauth2-bearer` might have no effect in some environment.

Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-11-05 01:15:19 +08:00
Kubernetes Prow Robot
792b4b1e32
Merge pull request #94661 from PurelyApplied/PoC-bazel-analysis-rebased
[KEP-1933] Provide hack/ testing target for static analysis.
2020-11-04 01:58:03 -08:00
Kubernetes Prow Robot
b00665c61b
Merge pull request #96073 from masap/local_up_cluster3
local-up-cluster.sh: Remove ineffective parameters
2020-11-03 14:58:04 -08:00
Masashi Honma
29c9fb6102 local-up-cluster.sh: Use config file instead of flags for kubelet
Because /tmp/kubelet.log shows trailing log twice.

Flag --address has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --rotate-certificates has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --feature-gates has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --cpu-cfs-quota has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --enable-controller-attach-detach has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --cgroups-per-qos has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --cgroup-driver has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --cgroup-root has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --eviction-hard has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --eviction-soft has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --eviction-pressure-transition-period has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --pod-manifest-path has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --fail-swap-on has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --authorization-mode has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --authentication-token-webhook has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --client-ca-file has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --cluster-dns has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --cluster-domain has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --runtime-request-timeout has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
Flag --port has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
2020-11-04 07:42:31 +09:00
Patrick Rhomberg
90b85bf3fa KEP-1933: add static analysis target to hack/
* Add static analysis to hack/verify-govet-levee.sh for defense against
accidental logging of credentials.
* Add binary dependency to hack/tools/tools.go and associated go.mod, go.sum.
* Add analysis configuration to hack/testdata/levee/
2020-11-03 20:03:26 +00:00
Sascha Grunert
7b9d7fd953
Propose seccomp/apparmor protobuf type definitions for CRI graduation
With the graduation of the Container Runtime Interface (CRI) we will
have a unique chance to change the protobuf protocol. We now use native
types for seccomp and AppArmor to make the API more clear and concise to
be used.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-11-03 20:17:17 +01:00
Kubernetes Prow Robot
cf4a33c549
Merge pull request #95761 from ingvagabund/move-rbac-under-component-helpers
Move pkg/registry/rbac code imported by kubectl under component helpers
2020-11-02 11:56:29 -08:00
Kubernetes Prow Robot
8e6a98992d
Merge pull request #93859 from habibrosyad/patch-92402-2
fix vendor/k8s.io/apimachinery/pkg/api/meta staticcheck
2020-11-02 10:24:14 -08:00
Jan Chaloupka
a5920f7edb Move helpers from pkg/registry/rbac/reconciliation and pkg/registry/rbac/validation under k8s.io/component-helpers 2020-11-02 17:51:16 +01:00
Kubernetes Prow Robot
d1c296431e
Merge pull request #96059 from knight42/refactor/migrate-health-check
refactor: migrate health checks of control-plane off insecure port in tests
2020-11-02 08:21:08 -08:00
M. Habib Rosyad
979fba1cb0 fix vendor/k8s.io/apimachinery/pkg/api/meta staticcheck 2020-11-01 15:38:57 +07:00
Kubernetes Prow Robot
b2e1165da8
Merge pull request #96063 from thockin/fix-96015-extra-dirs-conversion-gen
Pass all packages to conversion-gen
2020-10-31 03:38:51 -07:00
Masashi Honma
0cfb6a16e7 local-up-cluster.sh: Remove ineffective parameters
Because kube-apiserver shows these warnings, this patch removes parameters
which has no effect.

Flag --insecure-bind-address has been deprecated, This flag has no effect now and will be removed in v1.24.
Flag --insecure-port has been deprecated, This flag has no effect now and will be removed in v1.24.
2020-10-31 16:04:32 +09:00
Tim Hockin
54e2748e13 Pass all packages to conversion-gen
As per #96015 and other reports, conversion-gen does the wrong thing if
dependent packages are not ALSO being re-generated.  It creates new
versions of generated files that have missing conversions.

This change passes all packages as "extras" which will be parsed but not
regenerated (default already does exactly this).
2020-10-30 22:22:57 -07:00
knight42
3c4d6859c8
refactor: migrate health checks of control-plane off insecure port in tests
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-10-31 11:39:25 +08:00
Kubernetes Prow Robot
bf67247124
Merge pull request #93258 from zshihang/token
mv TokenRequest and TokenRequestProjection to GA
2020-10-30 16:36:51 -07:00
Kubernetes Prow Robot
4b65f70652
Merge pull request #95740 from cici37/moveCCM
Move cloud-controller-manager to staging k8s.io/cloud-provider
2020-10-30 13:48:51 -07:00
Kubernetes Prow Robot
3662e1e344
Merge pull request #96025 from haircommander/fix-API_PORT
hack/local-up-cluster.sh: fix API_PORT
2020-10-29 21:04:15 -07:00
cici37
9465d95ea6 Move CCM to staging k8s.io/cloud-provider 2020-10-29 20:50:23 -07:00
Shihang Zhang
ff641f6eb2 mv TokenRequest and TokenRequestProjection to GA 2020-10-29 20:47:01 -07:00
Masashi Honma
181a724dc3 local-up-cluster.sh: Pass CLUSTER_CIDR to kube-proxy
This patch fixes the local-up-cluster.sh to pass CLUSTER_CIDR to kube-proxy.
Previously, CLUSTER_CIDR was passed only to controller manager and cloud
controller manager.
2020-10-30 09:50:02 +09:00
Kubernetes Prow Robot
4d4570979a
Merge pull request #95982 from masap/local_up_cluster1
local-up-cluster.sh: Pass SERVICE_CLUSTER_IP_RANGE to controller manager
2020-10-29 17:40:36 -07:00
Peter Hunt
174548659f hack/local-up-cluster.sh: fix API_PORT
commit kubernetes/kubernetes@cfc2b33 causes a local cluster to not come up because it sets the default insecure port to 8080, which is no longer valid

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2020-10-29 17:17:58 -04:00
Kubernetes Prow Robot
1968e96165
Merge pull request #95856 from knight42/refactor/disable-apiserver-insecure-port
refactor(apiserver): disable insecure port
2020-10-29 10:47:58 -07:00
knight42
cfc2b330a7
refactor(apiserver): ignore the insecure flags
Leave the insecure flags intact but stop serving on insecure port.
2020-10-29 23:20:17 +08:00
Masashi Honma
8e84f3d78d local-up-cluster.sh: Pass SERVICE_CLUSTER_IP_RANGE to controller manager
Previously, SERVICE_CLUSTER_IP_RANGE was passed only to kube-apiserver.

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
2020-10-29 17:47:19 +09:00
Kubernetes Prow Robot
ec0ef23599
Merge pull request #95923 from deads2k/remove-deprecated
remove the deprecated client that we stopped generating
2020-10-28 12:50:11 -07:00
Kubernetes Prow Robot
17312ea4a9
Merge pull request #95810 from ruiwen-zhao/staticcheck_fix
Fix staticcheck failures on apiserver/plugin/pkg/{authenticator, auth…
2020-10-28 07:45:55 -07:00
David Eads
1f349b5d05 remove the deprecated client that we stopped generating 2020-10-28 10:43:31 -04:00
Joakim Roubert
434611b3fb Fix shellcheck issues in cluster/gce/gci/master-helper.sh
Based on PR 88582 by gavinfish that was closed due to inactivity.
Contains a few updates.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
2020-10-27 08:58:48 +01:00
Renaud Gaubert
a989bece00 Add podresources v1 API 2020-10-26 12:10:18 -07:00
Ben Hu
4e62298c1b Fix static checks for pkg/controller/podautoscaler 2020-10-23 18:53:07 +00:00
ruiwen-zhao
bdedc4ce34 Fix staticcheck failures on apiserver/plugin/pkg/{authenticator, authorizer} 2020-10-22 21:47:17 +00:00
Wilson Husin
889ffb04d0 Fix golint failures in client-go/transport
Signed-off-by: Wilson Husin <whusin@vmware.com>
2020-10-21 01:01:29 -07:00
Abhisek Banerjee
462326afba Support cross compilation only on amd64.
Based on a patch to Bottlerocket by Ben Cressey <bcressey@amazon.com>
41a72fe214/packages/kubernetes-1.17/0001-always-set-relevant-variables-for-cross-compiling.patch
2020-10-21 00:13:01 +00:00
bnrjee
6b672863c7 Always set relevant variables for cross compiling
Based on a patch to Bottlerocket by Ben Cressey <bcressey@amazon.com>
41a72fe214/packages/kubernetes-1.17/0001-always-set-relevant-variables-for-cross-compiling.patch
2020-10-21 00:13:01 +00:00
Kubernetes Prow Robot
a8a779133a
Merge pull request #95502 from suramrit/lintCorrection
Fix golint errors by adding definition comments for pkg/apis/apiserverinternal
2020-10-20 12:56:33 -07:00
Kubernetes Prow Robot
e0f7d0ce3e
Merge pull request #95659 from makhov/fix-verify-sh
fix unbound variable issue in verify.sh
2020-10-20 11:22:44 -07:00
Kubernetes Prow Robot
3b868e1a71
Merge pull request #92829 from marload/patch-0706-04
Refactoring: Reduce unnecessary lines
2020-10-19 19:12:07 -07:00
Kubernetes Prow Robot
a5dceab0ce
Merge pull request #95580 from jayunit100/jayunit100/pillarnodelocal
support multiple bind records (fie nodelocaldns  test regression)
2020-10-16 22:24:12 -07:00
Kubernetes Prow Robot
c913d4ed2a
Merge pull request #95640 from lala123912/staticcheck_2
vendor/k8s.io/metrics/pkg/client/custom_metrics: fix static check
2020-10-16 16:00:12 -07:00
Aleksei Makhov
1777a356c8 fix unbound variable issue in verify.sh 2020-10-16 21:39:25 +03:00
jayunit100
aefe930562 support multiple bind records (fie nodelocaldns test regression), by
first replacing PILLAR_ and then replacing other vars.
2020-10-16 14:28:55 -04:00
Kubernetes Prow Robot
23e5a85648
Merge pull request #93627 from hasheddan/verify-py3
run make verify with python3 to fix publishing bot issue
2020-10-16 08:01:25 -07:00
lala123912
324e969a6c fix staticcheck
vendor/k8s.io/metrics/pkg/client/custom_metrics/multi_client.go:49:4: ineffective break statement. Did you mean to break out of the outer loop? (SA4011)
vendor/k8s.io/metrics/pkg/client/custom_metrics/versioned_client.go:38:2: var codecs is unused (U1000)
2020-10-16 16:08:53 +08:00
Kubernetes Prow Robot
297b021f49
Merge pull request #95230 from Git-Jiro/fix_vendor_client_go
Fix staticchecks in vendor/k8s.io/client-go
2020-10-15 06:04:37 -07:00
Martin Schimandl
13c017056c Fix staticchecks in vendor/k8s.io/client-go 2020-10-15 07:27:02 +02:00
Kubernetes Prow Robot
7ff41c1ba0
Merge pull request #94588 from MaXinjian/shellcheck-typo
Fix typo in comment of hack/verify-shellcheck.sh
2020-10-14 11:15:49 -07:00
Kubernetes Prow Robot
8647eece9c
Merge pull request #95113 from Git-Jiro/lint_ttlcontroller
Lint ttl_controller
2020-10-13 22:51:53 -07:00
Kubernetes Prow Robot
ea896a2e64
Merge pull request #95224 from Git-Jiro/lint_endpoint
Fix lint errors in pkg/contoller/endpoint
2020-10-13 12:06:27 -07:00
Kubernetes Prow Robot
01f3f67989
Merge pull request #92663 from AndersonQ/68026-golint-/pkg/kubelet/stats
cleanup: fix golint errors in /pkg/kubelet/stats
2020-10-12 23:48:26 -07:00
Kubernetes Prow Robot
1dff024e64
Merge pull request #91014 from cici37/apiConfig
Move cmd/controller-manager to k8s.io/controller-manager
2020-10-12 15:17:22 -07:00
Suramrit Singh
e0249c4b0b - fix golint errors by adding defition comments
- remove /pkg/apiserverinternal from .golint_failures
2020-10-12 15:03:53 -07:00
Kubernetes Prow Robot
c1e5e6a556
Merge pull request #93836 from jayunit100/salt_cleanup_92835
remove __pillar__ refs
2020-10-11 17:58:47 -07:00
cici37
ae8ce0d190 Move cmd/controller-manager to k8s.io/controller-manager and cloud specific configs to k8s.io/cloud-provider. 2020-10-08 13:23:16 -07:00
Anderson Queiroz
8c724d7933 cleanup: fix golint errors in /pkg/kubelet/stats 2020-10-08 21:59:42 +02:00
Kubernetes Prow Robot
b53ba30c6a
Merge pull request #94762 from joakimr-axis/joakimr-axis_log-dump-array
log-dump.sh: Fix shellcheck issues
2020-10-08 10:10:55 -07:00
Joakim Roubert
d4dd0ad53c log-dump.sh: Fix shellcheck issues
Mitigate the shellcheck warning for the assignment of local variable.
Add rest of shellcheck fixes from #88349

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
2020-10-08 13:58:00 +02:00
Kubernetes Prow Robot
777e84e184
Merge pull request #95101 from a1k24/patch-92402-staticcheck
fixes test/integration/ttlcontroller staticcheck
2020-10-07 02:16:42 -07:00
cici37
33e23c4005 Move cloud related feature gates to controller-manager 2020-10-05 10:19:08 -07:00
Kubernetes Prow Robot
267ba6781e
Merge pull request #95098 from phunziker/92402-memcache_test
Fix vendor/k8s.io/client-go/discovery/cached/memory staticcheck
2020-10-04 11:23:05 -07:00
Kubernetes Prow Robot
c87dd9c512
Merge pull request #95275 from ProZsolt/golint-pkg-registry-core-replicationcontroller
Fix golint failures in pkg/registry/core/replicationcontroller
2020-10-04 03:35:05 -07:00
Kubernetes Prow Robot
0d1ac16ca4
Merge pull request #95180 from SaiHarshaK/staticcheck_kubectl_get
fix staticcheck for kubectl pkg files
2020-10-03 10:47:05 -07:00
Zsolt Prontvai
c244e175e2 Fix golint failures in pkg/registry/core/replicationcontroller 2020-10-03 12:56:14 +01:00
Sai Harsha Kottapalli
f6b3c5fb3f
fix staticcheck for kubectl pkg files 2020-10-03 13:50:53 +05:30
Martin Schimandl
104ad794e5 Fix lint errors in pkg/contoller/endpoint
Also mark reason for lint errors in:
pkg/controller/endpoint/config/v1alpha1,
pkg/controller/endpointslice/config/v1alpha1
pkg/controller/endpointslicemirroring/config/v1alpha1
2020-10-01 09:11:00 +02:00
a1k24
8854924e65 fixes test/integration/ttlcontroller staticcheck 2020-09-30 11:54:23 +05:30
Martin Schimandl
600d621ce6 Lint ttl_controller 2020-09-28 14:22:37 +02:00
Patrick Hunziker
b08e36eeb9 Fix staticcheck failure for vendor/k8s.io/client-go/discovery/cached/memory 2020-09-27 18:31:46 +02:00
Kubernetes Prow Robot
8eda21ea3f
Merge pull request #94950 from dashpole/empty_package_vendor
Fix empty package license generation
2020-09-23 10:14:39 -07:00
Kubernetes Prow Robot
d19aec8bf1
Merge pull request #92985 from serathius/summary
Move Kubelet Summary API to staging directory
2020-09-22 22:30:08 -07:00
Kubernetes Prow Robot
f728fbaa62
Merge pull request #94501 from ialidzhikov/nit/labels-staticcheck
Fix staging/src/k8s.io/apimachinery/pkg/labels golint findings
2020-09-22 12:23:51 -07:00
Kubernetes Prow Robot
100fe77b38
Merge pull request #86582 from mlmhl/local-up-cluster
do not wait for node ready when starting kube-proxy in 'nokubelet' mode
2020-09-22 12:21:09 -07:00
Marek Siarkowicz
7d309e0104 Move Kubelet Summary API to staging repo 2020-09-22 18:23:28 +02:00
David Ashpole
cbdf84a374 handle longer vendor paths without go files 2020-09-21 14:48:19 -07:00
Kubernetes Prow Robot
3fd5f367d6
Merge pull request #94820 from roycaihw/conversion-gen-clean-build
verify-generated-swagger-docs: remove unnecessary build
2020-09-16 00:17:19 -07:00
Haowei Cai
1ad3ba35ff verify-generated-swagger-docs: remove unnecessary build 2020-09-15 19:30:58 -07:00
Kubernetes Prow Robot
3e8e0dbf4a
Merge pull request #94482 from oomichi/expect_no_error-2
Use ExpectNoError(err) for some e2e tests
2020-09-15 18:27:19 -07:00
Kubernetes Prow Robot
aed5ffd195
Merge pull request #94449 from justaugustus/go115
[go1.15] Update to go1.15.2
2020-09-15 15:15:19 -07:00
Kubernetes Prow Robot
e7b9453972
Merge pull request #93537 from timuthy/enhancement.move-resourcequota
Move ResourceQuota admission to k8s.io/apiserver lib
2020-09-15 12:26:58 -07:00
Kubernetes Prow Robot
fd9828b02a
Merge pull request #92632 from RenaudWasTaken/move-podresources-api
Move external facing podresources apis to staging
2020-09-15 10:04:07 -07:00
Renaud Gaubert
60304452ff Move podresources api to k8s.io/kubelet/pkg/apis
Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
2020-09-15 05:13:33 -07:00
Kubernetes Prow Robot
4378481172
Merge pull request #94768 from justaugustus/aug-hack
hack: Add justaugustus as reviewer
2020-09-14 11:48:58 -07:00
David Eads
82ed033ec9 clean up podpreset deprecated client 2020-09-14 09:24:41 -04:00
David Eads
c7911a384c remove pod presets 2020-09-14 09:24:40 -04:00
Stephen Augustus
8d665d8863 hack: Add justaugustus as reviewer
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-09-14 09:06:38 -04:00
Mike Danese
bdadb2a187 make kube::util::find-binary not dependent on bazel-out/ structure
Implement an aspect that outputs go_build_mode metadata for go binaries,
and use that during binary selection.
2020-09-11 13:19:38 -07:00
Mike Danese
5a72bb001f hack/lib/util.sh: some bash cleanups
* switched one spot to use kube::logging
* make kube::util::find-binary return an error when it doesn't find
  anything so that hack scripts fail fast instead of with '' binary not
  found errors.
  * this required deleting some genfeddoc stuff. the binary no longer
    exists in k/k repo since we removed federation/, and I don't see it
    in https://github.com/kubernetes-sigs/kubefed/ either. I'm assuming
    that it's gone for good now.
2020-09-11 13:19:37 -07:00
Stephen Augustus
01a0c45f4a [go1.15] hack/tools: Update to k/repo-infra@v0.1.1 (supports go1.15.2)
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-09-11 13:15:08 -07:00
Kubernetes Prow Robot
360659102c
Merge pull request #94702 from huikang/fix-minor-comment
Fix minor comment in a script
2020-09-11 10:48:23 -07:00
Hui Kang
8f2c29635c Fix minor comment in a script
The variable API_HOST is defined below the comment

Signed-off-by: Hui Kang <kangh@us.ibm.com>
2020-09-10 20:53:46 +00:00
ialidzhikov
88fadb24c1 Fix staging/src/k8s.io/apimachinery/pkg/labels golint findings
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-09-10 18:55:17 +03:00
Kubernetes Prow Robot
1c6057b59c
Merge pull request #94605 from yttan/lint
fix golint failures for staging/src/k8s.io/client-go/examples/workqueue
2020-09-08 21:35:52 -07:00
Haowei Cai
d7ff169552 fix import paths 2020-09-08 14:34:55 -07:00
Haowei Cai
b71252a0ab add internal.apiserver.k8s.io/v1alpha1 to known gvs 2020-09-08 14:34:55 -07:00
Kubernetes Prow Robot
8728450be1
Merge pull request #94179 from ddymko/golint-fix-azuredd
fix golint for pkg/volume/azure_dd
2020-09-08 12:29:53 -07:00
yttan
d3db1ec12d fix golint failures for staging/src/k8s.io/client-go/examples/workqueue 2020-09-08 15:02:40 +08:00
Matt Matejczyk
67f9d69eaf Revert "fix cluster/log-dump/log-dump.sh shellcheck failures"
This reverts commit 742701622a.

It broke log dumping, see https://github.com/kubernetes/kubernetes/pull/88349#issuecomment-688385378
2020-09-07 17:13:33 +02:00
Ma Xinjian
a451e2ec3d Fix typo in comment of hack/verify-shellcheck.sh
Signed-off-by: Ma Xinjian <maxj.fnst@cn.fujitsu.com>
2020-09-07 16:25:44 +08:00
David Dymko
cda0070f28 fix golint for pkg/volume/azure_dd 2020-09-05 09:44:27 -04:00
Tim Usner
70d440bc7e Move ResourceQuota admission to k8s.io/apiserver 2020-09-04 14:53:52 +02:00
M. Habib Rosyad
558b31a5e9 fix vendor/k8s.io/apimachinery/pkg/runtime staticcheck 2020-09-04 11:46:45 +07:00
Kenichi Omichi
12c0eaef25 Use ExpectNoError(err)
We missed another pattern to check error doesn't happen on e2e tests.
This covers the pattern for consistent test implementation.
2020-09-03 23:29:07 +00:00
M. Habib Rosyad
19060e312f fix vendor/k8s.io/apimachinery/pkg/runtime/serializer/versioning staticcheck 2020-09-03 21:44:32 +07:00
Kubernetes Prow Robot
8296643fad
Merge pull request #94371 from bbyrne5/bmb-resourcequota-staticcheck-errorfix
fix staticcheck errors in resourcequota
2020-09-03 03:41:41 -07:00
Kubernetes Prow Robot
0455c2d5e7
Merge pull request #94407 from lavalamp/big-rename
Control Plane is a better name
2020-09-02 14:49:55 -07:00
Kubernetes Prow Robot
09851c014f
Merge pull request #91596 from brahmaroutu/mount-utils
Mount utils
2020-09-02 14:49:41 -07:00
Kubernetes Prow Robot
e2c5387d3f
Merge pull request #93164 from roycaihw/fix/clientgen-use-canonical-import-path
Use canonical import path in client-gen input-base
2020-09-02 13:37:21 -07:00
Daniel Smith
9eb664f88a fix a few missed references
```
grep -RIl pkg/master . | xargs -n 1 sed -i 's|pkg/master|pkg/controlplane|g'
LC_ALL=C sort -o hack/.golint_failures hack/.golint_failures
```
2020-09-02 11:45:10 -07:00
Kubernetes Prow Robot
cc14d5f3a1
Merge pull request #94338 from JeremyShih/fix-golint-error-in-admissionregistration
fixed golint error in pkg/apis/admissionregistration/validation
2020-09-02 10:37:19 -07:00
Kubernetes Prow Robot
80ada96466
Merge pull request #88349 from BenTheElder/shell-dump
fix cluster/log-dump/log-dump.sh shellcheck failures
2020-09-02 09:03:07 -07:00
Kubernetes Prow Robot
eb1fa66aac
Merge pull request #94387 from habibrosyad/patch-92402-9
fix vendor/k8s.io/apimachinery/pkg/conversion staticcheck
2020-09-02 06:59:07 -07:00
Srini Brahmaroutu
5db0ae548f moving files from k8s.io/util/mount into staging/src/k8s.io/mount-utils 2020-09-01 23:25:28 -07:00
Kubernetes Prow Robot
dd6c53d035
Merge pull request #93946 from alexzimmer96/68026-pkg-controller-resourcequota
Refactor pkg/controllers/resourcequota to fix golint errors
2020-09-01 19:41:06 -07:00
M. Habib Rosyad
9444a2f2f6
fix vendor/k8s.io/apimachinery/pkg/conversion staticcheck 2020-09-02 05:58:41 +07:00
Kubernetes Prow Robot
b49724d5fc
Merge pull request #94287 from jingyih/update_etcd_server_3p4p13
Update default etcd server to 3.4.13
2020-09-01 15:35:20 -07:00
Brian Byrne
a820a82785 fix staticcheck errors in resourcequota 2020-08-31 12:27:23 -04:00
Jeremy Shih
a39f502fc0 fix golint failures
some packages under staging/src/k8s.io/sample-apiserver/
2020-08-31 17:19:01 +08:00
Jeremy Shih
4ee5cdc838 fixed golint error in pkg/apis/admissionregistration 2020-08-31 09:43:51 +08:00
jay vyas
1693c111be Getting rid of the Salt DNS replacements, addded / back. 2020-08-30 09:11:27 +00:00
Kubernetes Prow Robot
3e8bc58cce
Merge pull request #91970 from SergeyKanzhelev/criLinterIssuesFix
fix linter issues for kubelet/cri/remote and ri-api/pkg/apis/testing
2020-08-28 10:39:49 -07:00
Kubernetes Prow Robot
a53285feb1
Merge pull request #93733 from adtac/jenkins/KUBE_ROOT
benchmark-dockerized.sh: set KUBE_ROOT
2020-08-28 08:04:46 -07:00
Kubernetes Prow Robot
eae3294b8d
Merge pull request #93101 from yiduyangyi/fix-golint
fix golint failures in pkg/kubeapiserver/options
2020-08-28 08:03:50 -07:00
Kubernetes Prow Robot
9ff9e8798a
Merge pull request #93498 from luigibk/use-ebtables-from-utils
Update k8s.io/utils dependency and use ebtables from there
2020-08-28 06:37:21 -07:00
Kubernetes Prow Robot
7abc47d315
Merge pull request #93136 from donggangcj/fix-static-check-error
fix(staticcheck): fix static error of package `/pkg/volume/gcepd`
2020-08-28 06:35:21 -07:00
jingyih
c96b93fbd4 Update default etcd server to 3.4.13 2020-08-28 21:19:24 +08:00
Benjamin Elder
742701622a fix cluster/log-dump/log-dump.sh shellcheck failures 2020-08-28 00:35:11 -07:00
Sergey Kanzhelev
df2f67daf8 fix linter issues for pkg/kubelet/cri/remote and staging/src/k8s.io/cri-api/pkg/apis/testing 2020-08-28 04:15:39 +00:00
Kubernetes Prow Robot
d8937faf23
Merge pull request #92917 from maryamklabib/staticcheck_fix
Resolves staticcheck failures for component-base/metrics
2020-08-27 20:15:02 -07:00
Kubernetes Prow Robot
fd20de89d9
Merge pull request #90433 from joakimr-axis/joakimr-axis_configure-helper.sh
Fix shellcheck w/e in cluster/gce/gci/configure-helper.sh
2020-08-27 19:05:47 -07:00
Kubernetes Prow Robot
aa084d4919
Merge pull request #92491 from BenTheElder/fuzz-only-test
compile out gofuzz from prod binaries
2020-08-27 17:57:36 -07:00
Kubernetes Prow Robot
67a7509ef3
Merge pull request #92430 from wangkai1994/fix/garbagecollector-staticcheck
Fix staticcheck failures for pkg/controller/garbagecollector/garbagecollector_test.go
2020-08-27 17:57:22 -07:00
Kubernetes Prow Robot
99d645d3f3
Merge pull request #92418 from panpan0000/static-check-server-healthz
Fix static check failures for staging/src/k8s.io/apiserver/pkg/server/healthz
2020-08-27 17:57:08 -07:00
Kubernetes Prow Robot
5ec83bc973
Merge pull request #91181 from zvier/master
fix golint errors for `pkg/kubelet/dockershim`
2020-08-27 17:54:45 -07:00
Kubernetes Prow Robot
02838bde69
Merge pull request #93817 from habibrosyad/patch-92402-test/e2e_node
fix test/e2e_node staticcheck
2020-08-27 16:07:37 -07:00
Kubernetes Prow Robot
274e33b691
Merge pull request #93581 from SergeyKanzhelev/nameOfPortMappingIsNotNeeded
Clean up in port mapping functionality
2020-08-27 16:06:11 -07:00
Kubernetes Prow Robot
42f1b278a3
Merge pull request #93414 from nikhita/publishing-cm-goversion
publishing: disallow specifying go version for master branch in rules
2020-08-27 16:05:29 -07:00
M. Habib Rosyad
ef56177df5 fix vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured/unstructuredscheme staticcheck 2020-08-27 19:37:23 +07:00
Kubernetes Prow Robot
72f355a97e
Merge pull request #94036 from saschagrunert/bash
Use /usr/bin/env bash in Makefiles and scripts
2020-08-27 04:49:35 -07:00
Kubernetes Prow Robot
9f14b1c89c
Merge pull request #93960 from habibrosyad/patch-92402-5
fix vendor/k8s.io/apimachinery/pkg/util/framer staticcheck
2020-08-27 04:48:48 -07:00
Kubernetes Prow Robot
07110b7b34
Merge pull request #93871 from habibrosyad/patch-92402-4
fix vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured staticcheck
2020-08-27 04:47:30 -07:00
Kubernetes Prow Robot
b9f25004c3
Merge pull request #93860 from habibrosyad/patch-92402-3
fix vendor/k8s.io/apimachinery/pkg/labels staticcheck
2020-08-27 04:47:03 -07:00
Alexander Zimmermann
86dc0364f4
Refactored pkg/controllers/resourcequota
* Fixed golint issues
* Removed redundant package import names
* Improved some variables and names

Co-authored-by: Mike Danese <mikedanese@gmail.com>
2020-08-20 14:37:27 +02:00
Sascha Grunert
975b8d352e
Use /usr/bin/env bash in Makefiles and scripts
This allows the execution of the Makefiles from distributions which do
have `bash` in a different path.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-08-16 21:13:18 +02:00
Odin Ugedal
1524794231
Fix building with GOFLAGS=-v
With go1.15 running go version with "-v" fails, and we should support
it.
2020-08-15 17:44:07 +02:00
M. Habib Rosyad
1e780605a9 fix vendor/k8s.io/apimachinery/pkg/util/framer staticcheck 2020-08-14 09:50:30 +07:00
Jordan Liggitt
bdcffdced3 [go115] Require go1.15 in build helper scripts 2020-08-13 13:46:52 -04:00
Stephen Augustus
5d1e299230 [go1.15] hack/tools: Update to k/repo-infra@v0.0.12 (supports go1.15.0)
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-08-12 14:19:59 -04:00
M. Habib Rosyad
42c68c303b
fix test/e2e_node staticcheck 2020-08-11 22:11:22 +07:00
M. Habib Rosyad
445cd35b5c
fix vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured staticcheck 2020-08-11 10:19:42 +07:00
M. Habib Rosyad
9436c5f8b3
fix vendor/k8s.io/apimachinery/pkg/labels staticcheck 2020-08-10 21:56:29 +07:00
Odin Ugedal
6dfdf05eaa
Add timeout config for node_e2e tests
Some test suits use more than the default 45m, resulting in the test to
crash.
2020-08-09 15:45:56 +02:00
Stephen Augustus
6733a9c470 generated: hack/update-hack-tools.sh && hack/update-vendor.sh
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-08-09 02:31:05 -04:00
Stephen Augustus
c3d1099205 [go1.15] hack/tools: Update to k/repo-infra@v0.0.11 (supports go1.15rc2)
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-08-09 02:23:47 -04:00
Adhityaa Chandrasekar
1edb5a892a benchmark-dockerized.sh: set KUBE_ROOT
See https://testgrid.k8s.io/sig-scalability-benchmarks#scheduler for an
example of this script failing.
2020-08-05 20:28:34 +00:00
Jordan Liggitt
4d1b34a582 Speed up update-swagger-docs
Only build genswaggertypedocs once per run instead of per-package

Speeds up the script from ~1:10 to ~0:18
2020-08-02 10:56:46 -04:00
Jordan Liggitt
f411880c73 Stop installing all commands before vetting 2020-08-02 10:56:46 -04:00
Jordan Liggitt
d8b0f6fc50 Build code-generator tools directly 2020-08-02 10:56:46 -04:00
Jordan Liggitt
a8ae7aefd0 Lower default log verbosity 2020-08-02 01:22:59 -04:00
Kubernetes Prow Robot
353903b154
Merge pull request #93603 from liggitt/lint
Remove golang.org exception for preferring latest minimal version
2020-08-01 20:22:13 -07:00
Kubernetes Prow Robot
e8f58be5a7
Merge pull request #93448 from hasheddan/vendor-deps
Add dependencycheck tool to address long running no-vendor-cycles test
2020-08-01 16:13:40 -07:00
hasheddan
8accd354b0
Run make verify with python3 to fix publishing bot issue
verify-publishing-bot is experiencing errors importing pyyaml since
python3 was added to kubekins-e2e image. This changes make verify to run
verify-publishing-bot with python3.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-08-01 09:46:13 -05:00
hasheddan
89bfeb5fb4
Update verify-no-vendor-cycles to use dependencycheck
verify-no-vendor-cycles currently routinely takes 3-4 minutes to run due
to the way that it checks for cyclical imports in vendored packages.
Moving to using the new dependencycheck tool makes this test much faster.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-08-01 08:11:05 -05:00
Jordan Liggitt
19b636bc84 Remove golang.org exception for preferring latest minimal version 2020-07-31 10:57:07 -04:00
Sergey Kanzhelev
d20fd40884 remove legacy leftovers of portmapping functionality that was moved to CNI 2020-07-30 23:12:16 +00:00
Luigi Bitonti
19793bd3fa Update k8s.io/utils dependency and use ebtables from there 2020-07-30 08:58:21 +01:00
Kubernetes Prow Robot
5a4aa2026c
Merge pull request #92679 from RainbowMango/pr_etcd_debug_parameter
remove etcd deprecated parameters in scripts
2020-07-26 19:52:17 -07:00
Jordan Liggitt
2257f46cac [go1.15] fix pin-dependency.sh to only use module info 2020-07-25 16:45:02 -04:00
Jordan Liggitt
247fcdfda5 [go1.15] go.mod: update to go1.15 2020-07-25 16:45:02 -04:00
Jordan Liggitt
f33dc28094 generated: hack/update-hack-tools.sh && hack/update-vendor.sh 2020-07-25 16:45:02 -04:00
Stephen Augustus
ed5a62f220 [go1.15] tools: Update to k/repo-infra@v0.0.10 (supports go1.15rc1)
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-25 16:45:01 -04:00
Stephen Augustus
05ffc95347 [go1.15] Remove client support for darwin/386
Removed in go1.15 (GH/golang/go/issues/37610).

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-25 16:45:01 -04:00
Nikhita Raghunath
1dffb87037 hack: ensure go version is not specified for master in publishing rules
The go version for all master branches is defined in `default-go-version`
locally.

Note that this validation isn't added to publishing-bot directly because
we still want to give users of the publishing-bot the ability to specify
specific go versions for the master branch if they need, but we want to
explicitly disallow this for kubernetes repos.
2020-07-24 14:33:05 +05:30
Dong Gang
b30f6f30ed fix(staticcheck): fix static error of package /pkg/volume/gcepd
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
2020-07-18 10:54:10 +08:00
Kubernetes Prow Robot
f9ad7db9a6
Merge pull request #92349 from jingyih/update_etcd_server_3p4p9
Update default etcd server to 3.4.9
2020-07-17 07:53:01 -07:00
Haowei Cai
5de47de7cf use canonical import path in client-gen so that package comments are
honored
2020-07-16 14:54:06 -07:00
Kubernetes Prow Robot
fbbc3ed359
Merge pull request #92490 from neolit123/1.19-increase-kubeadm-cmd-test-timeout
kubeadm: increase the timeout for cmd integration tests
2020-07-16 12:18:14 -07:00
yiduyangyi
e2838df7c7 fix golint failures in pkg/kubeapiserver/options 2020-07-15 16:03:08 +08:00
Lubomir I. Ivanov
b086fad508 kubeadm: increase the timeout for kubeadm cmd integration tests 2020-07-13 02:21:57 +03:00
Kubernetes Prow Robot
79ee122c18
Merge pull request #92854 from coderanger/patch-2
Make sure the _output folder exists before using it from module-graph.sh
2020-07-11 20:56:53 -07:00
Kubernetes Prow Robot
d20c5ed626
Merge pull request #92832 from marload/patch-0706-03
Refactoring: Change Inf Loop Condition (1 -> True)
2020-07-10 23:03:20 -07:00
Kubernetes Prow Robot
4efed03276
Merge pull request #91637 from robscott/endpointslice-mirroring
Adding new EndpointSlice Mirroring Controller
2020-07-10 10:19:48 -07:00
Maryam Labib
ac8abb7ac2 Resolves staticcheck failures for component-base/metrics 2020-07-09 20:05:15 -07:00
Kubernetes Prow Robot
fe43b104ba
Merge pull request #91745 from Bisnode/gh-87369
Presence of bearer token should cancel exec action
2020-07-09 09:07:00 -07:00
Kubernetes Prow Robot
896da2253c
Merge pull request #92611 from liggitt/go1.13
Tolerate go 1.13 builds
2020-07-09 00:05:50 -07:00
jingyih
e9bf1c3c90 Update default etcd server to 3.4.9 2020-07-08 14:16:40 +08:00
Noah Kantrowitz
a1fb2f9c7a
Make sure the _output folder exists before using it from module-graph.sh 2020-07-07 01:19:59 -07:00
Kubernetes Prow Robot
aaf40adcd0
Merge pull request #92461 from Haleygo/001
update static check failed from pkg/volume/rbd
2020-07-07 00:57:58 -07:00
wangkai1994
b3b95f5ab5 add defer 2020-07-07 10:20:19 +08:00
Rob Scott
e701cb0205
Enabling the EndpointSliceMirroring controller, adding related config 2020-07-06 12:43:34 -07:00
Jeff Grafton
089a1af421 Move ixdy to emeritus 2020-07-06 10:39:56 -07:00
Jordan Liggitt
ae43f87954 Move go.mod back to go1.13 2020-07-06 10:38:39 -04:00
marload
429672037c Refactoring: Reduce unnecessary lines 2020-07-06 21:19:35 +09:00
marload
b602ddf901 Refactoring: Change Inf Loop Condition (1 -> True) 2020-07-06 21:15:03 +09:00
Kubernetes Prow Robot
393f9e94e4
Merge pull request #92417 from wawa0210/ipam-staticcheck
Ipam staticcheck
2020-07-04 00:30:48 -07:00
Kubernetes Prow Robot
5da9ba51cd
Merge pull request #92750 from wawa0210/e2e-app-staticcheck
fix test/e2e/apps staticcheck
2020-07-03 05:04:12 -07:00
Kubernetes Prow Robot
7f78c330c0
Merge pull request #92421 from wawa0210/deployment-staticcheck
fix pkg/controller/deployment staticcheck
2020-07-02 06:41:29 -07:00
Kubernetes Prow Robot
2fd2d1b911
Merge pull request #92729 from liggitt/fix-root-license
Fix searching for licenses in single-segment modules
2020-07-02 04:18:26 -07:00
Kubernetes Prow Robot
1b871091b9
Merge pull request #91645 from chelseychen/event-api
Promote new Event API to v1
2020-07-02 04:16:46 -07:00
wawa0210
444cdc2944
fix pkg/controller/nodeipam staticcheck 2020-07-02 18:32:13 +08:00
wawa0210
9d1948a2f5
fix test/e2e/apps staticcheck 2020-07-02 18:14:12 +08:00
Anders Eknert
b423216a3b Presence of bearer token should cancel exec action
If a bearer token is present in a request, the exec credential plugin should accept that as the chosen method of authentication. Judging by an [earlier comment in exec.go](c18bc7e9f7/staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go (L217)), this was already intended. This would however not work since UpdateTransportConfig would set the GetCert callback which would then get called by the transport, triggering the exec plugin action even with a token present in the request. See linked issue for further details.

See #87369 for further details.

Signed-off-by: Anders Eknert <anders.eknert@bisnode.com>
2020-07-02 12:12:32 +02:00
Kubernetes Prow Robot
94e1c54735
Merge pull request #92655 from BenTheElder/cleanup-some-owners
Cleanup some owners
2020-07-01 23:14:08 -07:00
Kubernetes Prow Robot
406671910a
Merge pull request #92415 from wawa0210/statefulset-staticcheck
fix pkg/controller/statefulset staticcheck
2020-07-01 23:12:58 -07:00
Jordan Liggitt
49b78b88dc Fix searching for licenses in single-segment modules 2020-07-01 16:12:36 -04:00
Chelsey Chen
75612c1746 Promote new Event API to v1 2020-07-01 10:50:28 -04:00
Kubernetes Prow Robot
d114b5e542
Merge pull request #92445 from cheftako/graph
Added script to generate module level dependency graph.
2020-07-01 00:07:17 -07:00
RainbowMango
23613a90aa remove etcd deprecated parameters 2020-07-01 11:48:27 +08:00
Benjamin Elder
42acb51e2c disable goffuzz in binaries 2020-06-30 20:30:59 -07:00
Benjamin Elder
2abc8afece eparis to emeritus 2020-06-30 09:50:44 -07:00
Benjamin Elder
960ef085e9 zmerlynn to emeritus 2020-06-30 09:43:59 -07:00
Kubernetes Prow Robot
908847c01e
Merge pull request #91526 from maciaszczykm/dashboard-v2.0.1
Bump Dashboard to v2.0.1
2020-06-30 05:28:06 -07:00
Kubernetes Prow Robot
2c964aee15
Merge pull request #92536 from jherrera123/fix-issue-92488
Suppress expected error messages in verify-generated-files-remake.sh which cause confusion
2020-06-30 00:03:06 -07:00
Kubernetes Prow Robot
850080c41f
Merge pull request #91867 from yan-dblinf/fix_golint_failures_pkg_kubelet_lifecycle
Fix golint failures in pkg/kubelet/lifecycle
2020-06-30 00:02:42 -07:00
Kubernetes Prow Robot
c664611f5a
Merge pull request #92462 from Haleygo/vspherevolume-staticcheck
fix pkg/volume/vspherevolume static check
2020-06-29 18:34:49 -07:00
Joakim Roubert
80a8566a8c Fix shellcheck w/e in cluster/gce/gci/configure-helper.sh
Change-Id: Ic8fca2509a7cb07f4170eaf25a878036d18ba51c
Signed-off-by: Joakim Roubert <joakimr@axis.com>
2020-06-29 08:43:55 +02:00
Kubernetes Prow Robot
fe4fae0343
Merge pull request #92212 from thockin/verify-typecheck-no-gopath
Make verify-typecheck not depend on GOPATH
2020-06-26 20:16:14 -07:00
Jesus Herrera
9f2480208b Supress expected errors 2020-06-26 20:10:57 -04:00
haleygo
d6cf8d3e57 update static check failed from pkg/volume/rbd
remove field from staticcheck_failures
2020-06-27 02:21:51 +08:00
Tim Hockin
d187d7effa Rewrite typecheck against x/tools/go/packages
This runs much faster than before.  This change removes all of the
async status output because all of the compute time is spent inside
go/packages, with no opportunity to update the status.

Adds testdata code to prove it fails when expected.
2020-06-26 11:12:06 -07:00
haleygo
a5b7ce1bfd fix static check failed from pkg/volume/vspherevolume
remove field from staticcheck_failures
2020-06-27 02:03:13 +08:00
Kubernetes Prow Robot
a03db636da
Merge pull request #91366 from giuseppe/cgroupfs-cgroupv2
vendor: update google/cadvisor and opencontainers/runc
2020-06-26 04:17:31 -07:00
Tim Hockin
734f27d980 Add a reminder to add/rm files 2020-06-25 13:40:17 -07:00
Tim Hockin
15df3d6042 Make verify-typecheck not depend on GOPATH
This script fails if not under a GOPATH because we use go/types, which
is not modules aware.
2020-06-25 13:39:51 -07:00
wfender
9e354b2a16 Added script to generate module level dependency graph.
Added comments and switched to _output for bentheelder.
Added error checking for logicalhan.
Fixed egrep error.
Added dedupe logic.
Added staging only option.
Fixed ls -> find.
2020-06-25 13:24:15 -07:00
wawa0210
d360be0f7c
fix pkg/controller/statefulset staticcheck 2020-06-26 00:00:41 +08:00
Kubernetes Prow Robot
ad021a88b0
Merge pull request #92408 from BenTheElder/coverage-staticcheck
fix pkg/util/coverage staticcheck
2020-06-24 17:52:37 -07:00
Kubernetes Prow Robot
3fbe8c09ef
Merge pull request #92148 from oomichi/block-tests-in-e2e-framework
Add check for blocking tests in e2e framework
2020-06-24 13:31:07 -07:00
Kubernetes Prow Robot
67afc8ea3c
Merge pull request #91625 from pancernik/v1beta1-extender-encoding
Fix API encoding inconsistencies in KubeSchedulerConfig
2020-06-24 10:31:58 -07:00
Giuseppe Scrivano
78d295d168
hack/update-vendor-licenses.sh: skip empty packages
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-06-24 18:39:49 +02:00
Rafal Wicha
d7c84e11f5 Fix API encoding inconsistencies in KubeSchedulerConfig 2020-06-24 09:03:35 +01:00
Benjamin Elder
d1ec9b3f9c fix pkg/util/coverage staticcheck 2020-06-23 18:30:32 -07:00
Jordan Liggitt
660c290bbf go1.14: set -mod=mod while rebuilding/linting vendor and building licenses, preserve explicit imports in modules.txt 2020-06-23 19:04:43 -04:00
Jordan Liggitt
becd9f4a2e go1.14: update staticcheck for go 1.14, ignore new staticcheck warnings 2020-06-23 19:04:43 -04:00
Jordan Liggitt
c82fe149a6 go1.14: update minimum required go version 2020-06-23 16:40:22 -04:00
wawa0210
7d8aae51df
fix pkg/controller/deployment staticcheck 2020-06-23 19:32:20 +08:00
panpan0000
16c42fffb0 Fix static check failures for staging/src/k8s.io/apiserver/pkg/server/healthz/healthz_test.go 2020-06-23 07:18:04 -04:00
Mark Janssen
e3a0ca2731 Fix staticcheck failures for pkg/registry/...
Errors from staticcheck:
pkg/registry/autoscaling/horizontalpodautoscaler/storage/storage_test.go:207:7: this value of err is never used (SA4006)
pkg/registry/core/namespace/storage/storage.go:256:5: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional  (SA1019)
pkg/registry/core/namespace/storage/storage.go:257:11: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional  (SA1019)
pkg/registry/core/namespace/storage/storage.go:266:5: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional  (SA1019)
pkg/registry/core/namespace/storage/storage.go:267:11: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional  (SA1019)
pkg/registry/core/persistentvolumeclaim/storage/storage_test.go:165:2: this value of err is never used (SA4006)
pkg/registry/core/resourcequota/storage/storage_test.go:202:7: this value of err is never used (SA4006)
pkg/registry/core/service/ipallocator/allocator_test.go:338:2: this value of other is never used (SA4006)
pkg/registry/core/service/portallocator/allocator_test.go:199:2: this value of other is never used (SA4006)
pkg/registry/core/service/storage/rest_test.go:1843:2: this value of location is never used (SA4006)
pkg/registry/core/service/storage/rest_test.go:1849:2: this value of location is never used (SA4006)
pkg/registry/core/service/storage/rest_test.go:3174:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
pkg/registry/core/service/storage/rest_test.go:3178:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
pkg/registry/core/service/storage/rest_test.go:3185:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
pkg/registry/core/service/storage/rest_test.go:3189:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
2020-06-21 17:23:42 +02:00
Yan Yao
cef7876952 Fix golint failures in pkg/kubelet/lifecycle
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-06-20 18:44:54 -07:00
Kubernetes Prow Robot
219c856ce2
Merge pull request #91555 from daixiang0/scr
*.sh: cleanup all white noise
2020-06-20 05:26:53 -07:00
Tim Hockin
4842cb6339 Make verify-api-groups.sh not depend on GOPATH
This script quiently depended on being under a GOPATH, and failed
completely when it was not.  This change sorts the input (to make
comparing results easier) and operates on files, rather than packages
until the last moment when we add back the package prefix.

Verified by instrumenting the code and comparing runs inside and outside
of GOPATH.
2020-06-16 21:40:09 -07:00
Kubernetes Prow Robot
3be451d4d1
Merge pull request #91936 from SataQiu/fix-update-bazel-20200609
Fix bazel BUILD rule and suppress pkg-config errors
2020-06-15 14:18:13 -07:00
Kenichi Omichi
f7fb21c394 Add check for blocking tests in e2e framework
e2e test framework provides useful functions for implementing e2e tests,
but the framework itself should not contain e2e tests theirself.
This adds hacking check for blocking implementing e2e tests in the
framework.
2020-06-15 18:08:19 +00:00
Kubernetes Prow Robot
7ac6b15ee4
Merge pull request #91479 from ZhiFeng1993/ZF--add-comments-in-hack-update-scripts
Add usage in some hack/update scripts
2020-06-15 05:28:26 -07:00
SataQiu
2281e57e2c fix bazel BUILD rule and suppress pkg-config errors
Signed-off-by: SataQiu <1527062125@qq.com>
2020-06-14 17:47:08 +08:00
Kubernetes Prow Robot
47e79c73cb
Merge pull request #91684 from dims/use-containerd-as-default-in-cluster-kube-up
Use containerd as default in kube-up.sh
2020-06-09 14:49:21 -07:00
Kubernetes Prow Robot
416e0576d6
Merge pull request #91525 from bjrara/standalone-aggregator
Improve the standalone kube-aggregator
2020-06-09 14:48:33 -07:00
Kubernetes Prow Robot
0e93436ce1
Merge pull request #90976 from andrewsykim/move-cloud-controllers
Move cloud provider controllers to k8s.io/cloud-provider
2020-06-09 06:31:18 -07:00
bjrara
c8ac95321d Enhance kube-aggregator in standalone mode 2020-06-09 13:29:27 +08:00
Kubernetes Prow Robot
77fb14464e
Merge pull request #91537 from bjrara/kube-aggregator-openapi
Add openapi generation for the kube-aggregator
2020-06-08 21:43:18 -07:00
Andrew Sy Kim
41dc075a85 move pkg/controller/cloud/node_lifecycle_controller.go to k8s.io/cloud-provider/controllers/nodelifecycle for easier external consumption
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-06-08 17:34:01 -04:00
Andrew Sy Kim
6d4a19b31c move pkg/controller/cloud/node_controller.go to k8s.io/cloud-provider/controllers/node for easier external consumption
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-06-08 17:34:01 -04:00
Andrew Sy Kim
99d9dda5a7 move pkg/controller/route to k8s.io/cloud-provider/controllers/route for easier external consumption
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-06-08 17:34:01 -04:00
Davanum Srinivas
1731cb30f5
Use containerd as default in kube-up.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-06-07 14:34:50 -04:00
Kubernetes Prow Robot
3f8bb1bf50
Merge pull request #91685 from liggitt/csr-v1
CertificateSigningRequest v1 API
2020-06-05 15:30:14 -07:00
Jordan Liggitt
e0f5cca410 Copy CSR v1beta1 to v1
* Remove prerelease tags
* Update copyright, package, imports to v1
* Remove signerName, usages, and condition status defaulting
2020-06-05 00:47:24 -04:00
bjrara
5e0bd8a44c Add openapi generation for the kube-aggregator 2020-06-05 11:10:08 +08:00
Kubernetes Prow Robot
ae2422ae15
Merge pull request #91617 from jqmichael/vendorMd
Added link to vendor.md in go.mod
2020-06-04 13:52:12 -07:00
Kubernetes Prow Robot
1bc526aa6c
Merge pull request #88607 from caesarxuchao/add-storage-version-api
Add the storage version API
2020-06-03 19:20:43 -07:00
Walter Fender
a47b8d0a3c Handle clean up of read only files.
verify-bazel seems to create read only files under its tmp dir.
When it then goes to clean up the tmp dir it fails.
Adding a command prior to delete to make sure we have perms.
2020-06-03 13:31:18 -07:00
Kubernetes Prow Robot
6dbb92de3d
Merge pull request #91504 from pohly/local-up-cluster-snapshotter
local-up-cluster.sh: install CSI snapshotter
2020-06-03 07:30:18 -07:00
Chao Xu
a2ad36f1e5 Add the StorageVersion API 2020-06-02 23:13:46 -07:00
Patrick Ohly
2a31764ba7 local-up-cluster.sh: install CSI snapshotter
This cluster add-on is required for snapshotting of CSI volumes and
must be installed when bringing up a cluster because CSI driver
installations depend on that.

It is unclear how many users of the script need CSI snapshotting,
therefore it is disabled by default (= the previous behavior).
2020-06-02 16:15:53 +02:00
Qing Ju
fe8ecb18b0 Added link to vendor.md in go.mod 2020-06-01 17:20:47 -07:00
Kubernetes Prow Robot
d1586ea3f9
Merge pull request #91502 from deads2k/dyn-audit-removal-00
remove --feature-gates=DynamicAuditing
2020-05-29 11:56:20 -07:00
Xiang Dai
e09bc312cb *.sh: cleanup all white noise
Signed-off-by: Xiang Dai <long0dai@foxmail.com>
2020-05-29 09:56:00 +08:00
Kubernetes Prow Robot
c682b313d9
Merge pull request #91420 from pancernik/scheduler-config-v1beta1
Promote kubescheduler.config.k8s.io to v1betav1
2020-05-28 12:24:39 -07:00
Marcin Maciaszczyk
e5af792ad2 Bump Dashboard to v2.0.1 2020-05-28 13:08:53 +02:00
David Eads
e857adbdfd remove-api 2020-05-27 16:58:05 -04:00
ZhiFeng1993
4ad6ae83ae Add usage in some hack/update scripts 2020-05-26 21:49:38 -07:00
Kubernetes Prow Robot
f097cee156
Merge pull request #90960 from zhouya0/fix_kubectl_create_secret_docker_registry
Fix kubectl create secret docker-registry --from-file
2020-05-26 05:39:12 -07:00
Rafal Wicha
852442c0ff Promote kubescheduler.config.k8s.io to v1betav1 2020-05-25 22:25:57 +01:00
Kubernetes Prow Robot
779f875243
Merge pull request #91180 from PengJi/fix_golint_failures
fix golint errors in pkg/controller/volume/events/event
2020-05-25 06:27:12 -07:00
zvier
d43817b5ec fix golint errors for pkg/kubelet/dockershim
Signed-off-by: zvier <zvier20@gmail.com>
2020-05-24 23:45:17 +08:00
Kubernetes Prow Robot
4e8b56e667
Merge pull request #91116 from liggitt/local-up-cluster-rotation
Enable kubelet client-cert bootstrap/rotation in local-up-cluster
2020-05-23 13:23:10 -07:00
Davanum Srinivas
c7e79d2048
fix import restrictions and BUILD
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-20 10:57:47 -04:00
Kubernetes Prow Robot
ba2855eaa5
Merge pull request #91213 from dims/support-for-banning-incompatible-deps-klog-v1
Support for banning incompatible dependencies - start with klog v1
2020-05-18 13:34:17 -07:00
Kubernetes Prow Robot
ee8731a385
Merge pull request #91012 from justaugustus/verify-external
verify: Exclude verify-external-dependencies from make verify
2020-05-18 13:33:37 -07:00
Davanum Srinivas
8fd27f62ca
Support for banning incompatible dependencies - start with klog v1
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-18 11:55:01 -04:00
pengji
69999a6d54 fix golint in pkg/controller/volume/events/event.go 2020-05-17 23:34:02 +08:00
QianChenglong
9372e80ec6 fix: golint errors in staging/src/k8s.io/apimachinery/pkg/api/validation
Signed-off-by: QianChenglong <qian_cheng_long@163.com>
2020-05-16 21:23:13 +08:00
zhouya0
bbf41448f6 Fix kubectl create secret docker-registry 2020-05-15 12:14:03 +08:00
Jordan Liggitt
734de1bf8c Enable kubelet client-cert bootstrap/rotation in local-up-cluster
Change-Id: Ifea64abbc0b78b12b8aaa5885fd7c4b09c31c98e
2020-05-15 00:22:20 +00:00
Stephen Augustus
edb98fb493 verify: Exclude verify-external-dependencies from make verify
Also adds verify-external-dependencies to QUICK_PATTERNS

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-05-12 18:07:14 -04:00
Kubernetes Prow Robot
2260d97d74
Merge pull request #90994 from thockin/fix_license_again
Fix umask better
2020-05-12 08:25:18 -07:00
Tim Hockin
8d7adb7d94 Fix umask better
While the umask was previously set for builds (and in fact `docker run`
sets it to 0022 by default), the release pipeline `cp`'s files (with
`-a`) which respect the user's umask, and is outside of the build path.

This sets the umask in a common function called by all build tools,
which Stephen agreed was the simplest and most complete fix.  The
`verify-prereqs` function is already poorly named for what it does, and
this only makes it epsilon worse.
2020-05-11 13:23:54 -07:00
Kubernetes Prow Robot
b5f67110ed
Merge pull request #87746 from mattjmcnaughton/mattjmcnaughton/poc-compiling-kubelet-wo-docker
Support compiling Kubelet w/o docker/docker
2020-05-09 12:01:51 -07:00
Tim Hockin
b450001983 Let verify-vendor operate on a dirty repo
Several hours of wasted debug because of this.
2020-05-07 22:36:14 -07:00
Tim Hockin
7cbef7b26f Fix truncated logfile in verify-vendor
Writing to /dev/stderr causes a new FD to be opened.  If this is a
literal file, that file can get truncated.  `>&2` does not suffer the
same problem.
2020-05-07 21:49:06 -07:00
Tim Hockin
04c2b1fbdc Purge almost all memories of godep 2020-05-07 21:49:00 -07:00
Tim Hockin
fad9e0650a Generate new LICENSES tree with revised scripts 2020-05-07 21:49:00 -07:00
Tim Hockin
325ea6e3c2 Restructure licenses again (revert cd4474a)
This moves licenses of vendored code from one monolith file into a tree
of individual files for easier reviews.  This fixes both the bash and
bazel paths.
2020-05-07 21:48:59 -07:00
mattjmcnaughton
4a8da5e7b4
Add typecheck-dockerless
Ensure that k8s still passes the typecheck when the `dockerless` tag is
enabled. We perform a similar verify step for `providerless`.
2020-05-07 17:18:50 -04:00
Kubernetes Prow Robot
eec809aa93
Merge pull request #90779 from thockin/umask-for-builds
Set umask 0022 when building
2020-05-07 14:01:57 -07:00
Tim Hockin
dff449ee9e Set umask 0022 when building
Some binaries now run as non-root (kube-scheduler).  When umask is 0027,
for example, the container image we build has the binary 0750, which is
not executable by the non-root UID.
2020-05-05 16:28:43 -07:00
David Eads
8e43b5e5ea add prerelease-lifecycle verification to all beta APIs 2020-05-05 09:47:31 -04:00
Cecile Robert-Michon
7d6ba67da0
Update find-binary-for-platform to work with non-GNU versions of find 2020-05-01 16:19:00 -07:00
Jie Shen
c71a25e912
Fix shellcheck warnings/errors in cluster/gce/upgrade.sh (#88576)
* Fix shellcheck warnings/errors in cluster/gce/upgrade.sh

* Update cluster/gce/upgrade.sh

Co-Authored-By: Slava Semushin <slava.semushin@gmail.com>

Co-authored-by: Slava Semushin <slava.semushin@gmail.com>
2020-04-30 21:26:06 -07:00
Davanum Srinivas
14a0e86d1d
Avoid running files-remake in verify-all
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-30 11:35:35 -04:00
Aaron Crickenberger
c2e7ccf2d4 default import-boss --include-test-files=true 2020-04-28 08:41:36 -07:00
Joakim Roubert
bf77061cb1 Fix shellcheck failures in cluster/pre-existing/util.sh
This is merely bringing PR #82059 back to life in a contemporary
context, so all cred should go to k-toyoda-pi (and BenTheElder).

Change-Id: I7cf33e50adabbd23d18348448c21c6255502c1ba
Signed-off-by: Joakim Roubert <joakimr@axis.com>
2020-04-23 16:02:48 +02:00
Kubernetes Prow Robot
653396da21
Merge pull request #87405 from gavinfish/kubectl_pkg_cmd_set
Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit
2020-04-22 23:09:44 -07:00
Davanum Srinivas
6974d32755
Add Makefile and a note in README.md
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-20 13:45:47 -04:00
Davanum Srinivas
ff6a888180
generate LICENSES used in tools
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-20 13:45:46 -04:00
Davanum Srinivas
ad70acf018
add update/verify for go.mod/sum files in hack/tools
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-20 13:45:46 -04:00
Davanum Srinivas
f981628ce8
move linting dependencies to hack/tools/tools.go
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-20 13:45:38 -04:00
Davanum Srinivas
12146cb4df
Do not include bazel related deps in root go.mod
- add ./hack/tools/go.mod, this makes ./hack/tools a distinct module
- hack/tools/tools.go undescore imports bazel related tools, over time we
can add others.
- hack/*.sh scripts will cd to hack/tools and go install tools from there

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-19 22:01:50 -04:00
toyoda
a01b1dada5 Fix shellcheck failure in cluster/gce/config-default.sh 2020-04-17 16:11:58 +09:00
Kubernetes Prow Robot
b4a088f1cf
Merge pull request #88217 from gkarthiks/master
fix: golint failures
2020-04-16 08:38:46 -07:00
Kubernetes Prow Robot
1df63e7dc7
Merge pull request #88510 from steveazz/steveazz/68026-rlimit
Fix golint issues for `pkg/util/rlimit`
2020-04-15 15:22:45 -07:00
Kubernetes Prow Robot
b7a6d53f5e
Merge pull request #88924 from dims/add-support-for-listing-conformance-tests-in-e2e.test
Add support for listing conformance tests in e2e.test
2020-04-15 13:14:45 -07:00
Kubernetes Prow Robot
aed3f05495
Merge pull request #88459 from joakimr-axis/joakimr-axis_config-test.sh
Fix shellcheck warnings/errors in cluster/gce/config-test.sh
2020-04-14 15:38:02 -07:00
Kubernetes Prow Robot
ea2d784545
Merge pull request #89895 from jingyih/update_etcd_server_3p4p7
Update default etcd server to 3.4.7 in k8s v1.19
2020-04-14 12:34:06 -07:00
Steve Azzopardi
4936cd476b
Fix golint issues for pkg/util/rlimit
pkg/util/rlimit/rlimit_linux.go:25:1: exported function RlimitNumFiles should have comment or be unexported
pkg/util/rlimit/rlimit_linux.go:25:6: func name will be used as rlimit.RlimitNumFiles by other packages, and that stutters; consider calling this NumFiles
pkg/util/rlimit/rlimit_unsupported.go:25:1: exported function RlimitNumFiles should have comment or be unexported
pkg/util/rlimit/rlimit_unsupported.go:25:6: func name will be used as rlimit.RlimitNumFiles by other packages, and that stutters; consider calling this NumFiles

Ref: https://github.com/kubernetes/kubernetes/issues/68026
2020-04-14 21:00:41 +02:00
jingyih
394df132bd Update default etcd server to 3.4.7 2020-04-13 14:37:56 -07:00
Kubernetes Prow Robot
b17ddac4df
Merge pull request #78944 from avorima/golint_fix_job
Fix golint errors in pkg/controller/job
2020-04-12 21:57:47 -07:00
Kubernetes Prow Robot
c7297a4498
Merge pull request #87646 from SataQiu/staticcheck-20200129
Fix staticcheck failures of pkg/probe/http
2020-04-10 14:39:48 -07:00
Kubernetes Prow Robot
95c3a69b19
Merge pull request #89980 from agadelshin/68026-pkg-registry-apps-golint
Fix goling issues for pkg/registry/apps
2020-04-10 09:29:47 -07:00
Kubernetes Prow Robot
5bfe8fe2b9
Merge pull request #88940 from tianhongw/master
fix golint errors in staging/src/k8s.io/client-go/plugin/pkg/client/a…
2020-04-10 08:09:47 -07:00
Kubernetes Prow Robot
b0ed3cdd24
Merge pull request #90015 from serathius/visible_to
Move prometheus visibility rules to build/visible_to
2020-04-09 22:28:01 -07:00
SataQiu
68ba2fecc1 fix staticcheck failures of pkg/probe/http 2020-04-10 12:14:25 +08:00
Kubernetes Prow Robot
3d350d86d6
Merge pull request #81892 from praseodym/fix-staticcheck-pkg/volume
Fix staticcheck failures for pkg/volume/...
2020-04-09 20:03:48 -07:00
Mark Janssen
2c61627f8c Fix staticcheck failures for pkg/volume/...
Errors from staticcheck:
pkg/volume/azure_dd/azure_common.go:68:2: var winDiskNumFormat is unused (U1000)
pkg/volume/csi/csi_block.go:97:2: field volumeInfo is unused (U1000)
pkg/volume/csi/csi_block_test.go:56:6: func prepareBlockUnmapperTest is unused (U1000)
pkg/volume/csi/csi_client.go:108:2: const initialDuration is unused (U1000)
pkg/volume/csi/csi_client.go:109:2: const factor is unused (U1000)
pkg/volume/csi/csi_client.go:110:2: const steps is unused (U1000)
pkg/volume/csi/csi_client_test.go:83:8: this value of err is never used (SA4006)
pkg/volume/csi/csi_mounter.go:76:2: field options is unused (U1000)
pkg/volume/csi/csi_mounter_test.go:454:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:766:16: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:861:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:1186:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:1249:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_test.go:305:5: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
pkg/volume/flexvolume/probe_test.go:67:10: this value of err is never used (SA4006)
pkg/volume/iscsi/iscsi_test.go:95:2: field attachCalled is unused (U1000)
pkg/volume/iscsi/iscsi_test.go:96:2: field detachCalled is unused (U1000)
pkg/volume/iscsi/iscsi_test.go:501:24: this value of err is never used (SA4006)
pkg/volume/iscsi/iscsi_util_test.go:159:2: this value of exist is never used (SA4006)
pkg/volume/local/local.go:351:57: argument devicePath is overwritten before first use (SA4009)
pkg/volume/plugins_test.go:119:2: this value of plug is never used (SA4006)
pkg/volume/plugins_test.go:125:2: this value of plug is never used (SA4006)
pkg/volume/quobyte/quobyte.go:474:23: this result of append is never used, except maybe in other appends (SA4010)
pkg/volume/quobyte/quobyte.go:477:23: this result of append is never used, except maybe in other appends (SA4010)
pkg/volume/quobyte/quobyte.go:480:23: this result of append is never used, except maybe in other appends (SA4010)
pkg/volume/rbd/rbd.go:886:2: field adminSecret is unused (U1000)
pkg/volume/rbd/rbd.go:887:2: field adminID is unused (U1000)
pkg/volume/rbd/rbd.go:888:2: field imageFormat is unused (U1000)
pkg/volume/rbd/rbd.go:889:2: field imageFeatures is unused (U1000)
pkg/volume/storageos/storageos.go:302:2: field secretName is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:43:2: field apiAddr is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:44:2: field apiUser is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:45:2: field apiPass is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:46:2: field apiVersion is unused (U1000)
pkg/volume/util/atomic_writer_test.go:756:49: argument err is overwritten before first use (SA4009)
pkg/volume/util/fsquota/common/quota_linux_common.go:37:2: const acct is unused (U1000)
pkg/volume/util/fsquota/common/quota_linux_common.go:38:2: const enforcing is unused (U1000)
pkg/volume/util/fsquota/project.go:168:31: identical expressions on the left and right side of the '==' operator (SA4000)
pkg/volume/util/fsquota/quota_linux.go:306:50: argument poduid is overwritten before first use (SA4009)
pkg/volume/util/fsquota/quota_linux_test.go:558:16: this value of err is never used (SA4006)
pkg/volume/util/subpath/subpath_linux.go:232:81: argument err is overwritten before first use (SA4009)
pkg/volume/util/subpath/subpath_linux_test.go:579:73: argument err is overwritten before first use (SA4009)
2020-04-09 22:08:07 +02:00
Marek Siarkowicz
62d010d6ac Move prometheus visibility rules to build/visible_to 2020-04-09 20:18:26 +02:00
Joakim Roubert
21bef7536c Fix shellcheck warnings/errors in cluster/gce/config-test.sh
Change-Id: I3760337aa345ca5b801587ea12c971a95168f7d7
Signed-off-by: Joakim Roubert <joakimr@axis.com>
2020-04-09 08:30:13 +02:00
Lubomir I. Ivanov
9bbd321fec remove /cluster/kubeadm.sh and /test/cmd/kubeadm.sh
/cluster/kubeadm.sh is used to find the kubeadm binary.
This file is legacy and is removed.

Remove /test/cmd/kubeadm.sh. This file contains a function that is used
to build kubeadm and invoke "make test". Move the function contents
to hack/make-rules/test-cmd.cmd.

Stop sourcing /test/cmd/kubeadm.sh in /test/cmd/legacy-script.sh.

Also remove the --kubeadm-path invocation as this can be handled
with an env. variable directly.
2020-04-09 00:47:15 +03:00
Artur Gadelshin
3ab5ea09ed Fix goling issues for pkg/registry/apps 2020-04-08 23:12:29 +02:00
Kubernetes Prow Robot
8cdf21ab4c
Merge pull request #86409 from sshukun/fix-golint
Fix go-lint issues in package pkg/kubelet/checkpointmanager/testing/example_checkpoint_formats/v1
2020-04-06 15:42:01 -07:00
Kubernetes Prow Robot
9c3b5887d2
Merge pull request #89821 from wojtek-t/cleanup_apimachinery_tests
Cleanup apimachinery tests and stop relying on default conversions
2020-04-06 13:48:00 -07:00
Sean R. Sullivan
748ad74245 Even with build error, kubectl apply should apply all valid resources 2020-04-04 15:48:31 -07:00
wojtekt
8eb60c2474 Remove k8s.io/apimachinery/pkg/runtime/serializer/testing directory 2020-04-03 17:45:02 +02:00
Kubernetes Prow Robot
dd35908c7f
Merge pull request #89298 from gavinfish/scheuler-config-alph1
Remove kubescheduler.config.k8s.io/v1alpha1
2020-04-02 21:39:59 -07:00
Kubernetes Prow Robot
821ebaf0c6
Merge pull request #87448 from YuikoTakada/fix_81657_t_integ_dep
Fix static check failures in test/integration/deployment
2020-04-02 21:39:45 -07:00
Davanum Srinivas
b6a07b92fc
add conformance testdata/ and make it available from bindata
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-04-01 10:48:01 -04:00
Kubernetes Prow Robot
1b7f5662e1
Merge pull request #89215 from k-toyoda-pi/use_expectnotequal_service
Use ExpectNotEqual in test/e2e/network/
2020-03-31 14:15:28 -07:00
Kubernetes Prow Robot
7b621d82d5
Merge pull request #89620 from dims/fix-mismatch-between-pod-resources-verify/update-scripts
fix mismatch between pod resources verify/update scripts
2020-03-31 09:26:40 -07:00
Kenichi Omichi
03c7bdcacc Enable import-boss check for integration test
Integration tests imported e2e test code and the dependency made two drawbacks:

- Hard to move test/e2e/framework into staging (#74352)
- Need to run integration tests always even if PRs are just changing e2e test code

This enables import-boss check for blocking such dependency.
2020-03-30 21:09:15 +00:00
Davanum Srinivas
62269f5e6e
fix mismatch between pod resources verify/update scripts
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-03-28 20:25:36 -04:00