Commit Graph

107 Commits

Author SHA1 Message Date
Han Kang
52097bc02d add support for timing histograms and const labels
Change-Id: I8f77d5e16c01a403c7cfdccec464a81f4e3beba0
2022-10-11 17:19:14 -07:00
Han Kang
521a027fea update capabilities of static analysis parser
Change-Id: Ie09399981fcef213e0e7c7d12a8039aedbf0246a
2022-09-27 17:21:14 -07:00
Han Kang
178e57c17b clean-up apiserver metrics and use subsystem
this is specifically so that we have more structured information when
the metric is parsed and stored as a stable metric. This change does not
change the name of the actual metrics.

Change-Id: I861482401ad9a0ae12306b93abf91d6f76d7a407
2022-07-29 12:51:32 -07:00
Han Kang
c38746c353 add test for fake objectives
Change-Id: Ib0bfdf1299cd74490474f92c41d93090809f41c4
2022-07-26 15:31:25 -07:00
Han Kang
cefa194998 Update test/instrumentation/error.go
Co-authored-by: Damien Grisonnet <damien.grisonnet@epita.fr>
2022-07-26 15:31:25 -07:00
Han Kang
e452850ec3 Add support for summary metrics for stablity checks
Also add entrypoints for verifying and updating a test file for easier
debugging. This is considerably faster than running the stablity checks
against the entire Kubernetes codebase.

Change-Id: I5d5e5b3abf396ebf1317a44130f20771a09afb7f
2022-07-26 15:31:25 -07:00
Kubernetes Prow Robot
e8410006ac
Merge pull request #107042 from kkkkun/update_metrics_bucket
Update etcdRequestLatency metrics bucket size
2022-07-16 00:28:52 -07:00
Han Kang
731397086b remove deprecated metric and promote the replacement to STABLE 2022-05-31 09:53:28 -07:00
Elana Hashman
eb540aaa4a
Update OWNERS file for stable metrics 2022-04-07 13:22:39 -07:00
Kubernetes Prow Robot
2161071d0b
Merge pull request #108919 from denkensk/rename-usQ
Rename unschedulableQ to unschedulablePods
2022-03-24 12:18:53 -07:00
Alex Wang
8a5df1302a rename unschedulableQ to unschedulablePods
Signed-off-by: Alex Wang <wangqingcan1990@gmail.com>
2022-03-24 17:38:49 +08:00
Kir Kolyshkin
d8fdb00b34 Fix verify: generated-stable-metrics wrt go 1.18
This should fix the following error when running
./hack/update-generated-stable-metrics.sh:

	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

Using `go get` to download gopkg.in/yaml.v2 package into
KUBE_EXTRA_GOPATH directory no longer works. Interestingly, main repo
already has gopkg.in/yaml.v2@v2.4.0, same version that was installed by
that go get.

I guess that GOPATH with multiple elements no longer works either,
and since this code was the only user of KUBE_EXTRA_GOPATH, let's remove
it as well.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2022-03-23 10:19:59 -07:00
Davanum Srinivas
3470453e01
Fix for verify: generated-stable-metrics problem
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-03-23 08:02:53 -04:00
ahrtr
fe95aa614c io/ioutil has already been deprecated in golang 1.16, so replace all ioutil with io and os 2022-02-03 05:32:12 +08:00
Sergey Kanzhelev
7e7bc6d53b remove DynamicKubeletConfig logic from kubelet 2022-01-19 22:38:04 +00:00
zk
fb372d0798 Update etcdRequestLatency metrics bucket size 2022-01-09 23:45:09 +08:00
Kubernetes Prow Robot
ba200841fd
Merge pull request #106366 from cyclinder/evictions_number_stable
adding evictions_total metric and marking evictions_number deprecated
2021-12-12 23:19:59 -08:00
cyclinder
b88b51c6e5 adding evictions_total metric and marking evictions_number deprecated
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-13 10:36:02 +08:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Kubernetes Prow Robot
c9a245fa48
Merge pull request #106266 from ahg-g/ahg-metrics
Move a number of scheduler metrics to STABLE
2021-11-11 15:15:37 -08:00
Abdullah Gharaibeh
a241c45dc7 move a number of scheduler metrics to STABLE 2021-11-10 12:51:17 -05:00
Paweł Banaszewski
a8bd20a5af Changed buckets for apiserver_request_duration_seconds metric 2021-11-10 11:53:49 +00:00
Reza Karimi
894e31f41a making some apiserver metrics stable 2021-11-05 14:50:05 +00:00
Reza Karimi
bb15f02039 issue#105861: making scheduler metrics stable 2021-11-03 15:34:50 +00:00
Pat Christopher
f720c4fd44
hack/verify fixes 2021-07-28 19:26:44 -07:00
Pat Christopher
4549573a44
minor cleanups 2021-07-27 18:39:33 -07:00
Pat Christopher
b09bbd808a
testing patches. add k8s.io/staging, remove local home 2021-07-19 20:26:53 -07:00
Pat Christopher
169583bf4e
tests for path resolver, add KUBE_ROOT to both top level func calls 2021-07-14 20:35:49 -07:00
Pat Christopher
e75f3fb563
add happy path tests for two types of imports 2021-07-13 20:08:13 -07:00
Pat Christopher
d3aabe2397
fix existing unit tests 2021-07-13 19:25:45 -07:00
Pat Christopher
585ce7f04d
missed a paren 2021-07-13 19:03:39 -07:00
Pat Christopher
bde2ef2a1a
review comments 2021-07-13 19:02:23 -07:00
Pat Christopher
ef3c344868
seems to work, needs tests and a lot of cleanup 2021-07-12 20:28:10 -07:00
Jordan Liggitt
7877539e30 Promote apiserver_requested_deprecated_apis metric to stable 2021-05-11 16:25:14 -04:00
Han Kang
50e6f15dee rename apiserver_storage_object_counts to conform to best practices (apiserver_storage_objects)
Change-Id: I8c08a37cd3ed7c943a6691185f750e55d389dd3a
2021-03-10 04:32:27 -08:00
Yu Yi
77950ba79b metrics: promote apiserver_storage_object_counts to stable
- rename etcd_object_counts to apiserver_storage_object_counts

CONTEXT https://github.com/kubernetes/kubernetes/issues/98270
FIXES https://github.com/kubernetes/kubernetes/issues/98270
2021-03-08 20:28:55 +00:00
Han Kang
69e3d89a38 promote apiserver_request_duration_seconds to STABLE
Change-Id: I1b050b812738719aedd7ac6f4794ec742812e12d
2021-03-07 17:14:36 -08:00
Kubernetes Prow Robot
ffa4e3414e
Merge pull request #99788 from logicalhan/stable-m
promote apiserver_request_total to STABLE status
2021-03-06 12:50:13 -08:00
Han Kang
cfd00de686 bump apiserver_request_total to STABLE status
We've dropped the content-type field since it is effectively unbounded
(we had a sec-vuln about this before actually). We retain all other
fields, despite their unboundedness due to the fact that we can now
explicitly set bounds on label values.

Change-Id: Icc483fc6a17ea6382928f4448643cda6f3e21adb
2021-03-04 11:39:15 -08:00
Benjamin Elder
56e092e382 hack/update-bazel.sh 2021-02-28 15:17:29 -08:00
Han Kang
c3f550f3cb fix arguments too long error 2021-02-08 11:55:25 -08:00
Han Kang
db107b190c remove the rest of the bazel test wiring for metrics stability 2021-02-05 10:48:48 -08:00
Han Kang
73d797d474 Wire up static-analysis so that it executes in the normal 'hack' flow 2021-02-04 18:48:03 -08:00
Nikhita Raghunath
3a74f461a2 Revert "Merge pull request #93160 from logicalhan/triage-instrumentation"
This reverts commit 1ed2cf1895, reversing
changes made to 04ecdb9eb6.
2020-07-24 18:09:07 +05:30
Han Kang
f3c02d7221 auto triage sig-instrumentation tagged PRs
Change-Id: Ibae7373fb197485aeb222f1455515178cc3b4d13
2020-07-16 13:48:25 -07:00
Kubernetes Prow Robot
d350ace52b
Merge pull request #84373 from serathius/metrics-stability-variables
Allow usage of consts and variables for stable metrics in static analysis
2020-01-09 20:12:49 -08:00
Marek Siarkowicz
4dd546cf2c Allow usage of consts and variables for stable metrics in static analysis 2019-11-08 09:41:59 +01:00
Kubernetes Prow Robot
1b4155804c
Merge pull request #84378 from serathius/static-analysis-bazel-25
Handle bazel >= 0.25 in stable metric static analysis
2019-11-07 04:34:56 -08:00
RainbowMango
db9ab74a7e Deal with auto-generated files.
- Update bazel by hack/update-bazel.sh
2019-10-29 15:32:09 +08:00
RainbowMango
4355772bb6 Remove directly reference to Prometheus 2019-10-29 15:08:16 +08:00
Marek Siarkowicz
4c7c581308 Handle bazel >= 0.25 in stable metric static analysis
Check both "bazel-genfiles" and "bazel-bin" due https://github.com/bazelbuild/bazel/issues/6761
2019-10-25 19:18:24 +02:00
Marek Siarkowicz
c62da00c56 Pass list of files through stdin to avoid hitting ARG_MAX on some environments 2019-10-25 18:52:23 +02:00
Timothy St. Clair
97055841b1 Audit of test/* OWNERS files 2019-10-10 15:52:51 -05:00
Marek Siarkowicz
c601d34eba Introduce sig-instrumentation aliases in OWNERS_ALISES and simplify OWNERS files 2019-10-10 14:04:20 +02:00
Marek Siarkowicz
53fc6f9b58 Finish implementation of stable metrics static analysis
Handle "DeprecatedVersion" field
Fix kube metrics framework path
Implement handling prometheus util functions for generating buckets
2019-08-21 23:46:36 +02:00
Marek Siarkowicz
a5377a684c Implement stable metric validation and verification
Based on KEP:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-validation-and-verification.md

Add //test/instrumentation:stable_metric_test that compares metrics
in source code to those available in
"test/instrumentation/testdata/stable-metrics-list.yaml".
2019-08-12 12:01:35 +02:00
Marek Siarkowicz
0260d4f287 Setup directories for Metrics validation and verification KEP
KEP link: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-validation-and-verification.md
2019-08-06 15:11:39 +02:00