Commit Graph

413 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
7f8539ff20 Merge pull request #101441 from dobsonj/101332-deprecate-mount-path-removal
Deprecate removal of CSI nodepublish path by kubelet (#101332)
2021-04-28 10:32:50 -07:00
Jonathan Dobson
260426bf44 clarify deprecation comment 2021-04-27 17:52:40 -06:00
Jonathan Dobson
75a7966414 move deprecation comment to TearDownAt function 2021-04-27 11:40:12 -06:00
Jonathan Dobson
e92dc8d9be Deprecate removal of CSI nodepublish path by kubelet (#101332) 2021-04-27 08:41:47 -06:00
Niels de Vos
de3a4429d9 Make type BlockVolume a MetricsProvider 2021-04-22 08:36:20 +02:00
Niels de Vos
e99ced3114 Add support for gethering metrics from CSI block-mode volumes 2021-04-22 08:36:20 +02:00
Kubernetes Prow Robot
3e6f244851 Merge pull request #100999 from lojies/cispkgcleanup
code cleanup for pkg volume csi
2021-04-20 00:42:33 -07:00
Kubernetes Prow Robot
a0e6e491e9 Merge pull request #99069 from phantooom/master
kubelet: fix raw block mode CSI NodePublishVolume stage miss pod info
2021-04-15 14:47:00 -07:00
phantooom
82c2266f25 chore: make csi getPodInfoAttrs func private 2021-04-15 20:51:51 +08:00
卢振兴10069964
a36c5f08f4 code cleanup: Omit redundant nil check on slices 2021-04-12 09:00:36 +08:00
卢振兴10069964
b3fea118dc code cleanup for pkg volume csi 2021-04-12 08:36:53 +08:00
Christian Huffman
3bcf407d2f Addresses nitpicks for FSGroupPolicy 2021-04-05 15:45:40 -04:00
fengzixu
edc1c62471 feature: add CSIVolumeHealth feature and gate
1. add EventRecorder to ResourceAnalyzer
2. add CSIVolumeHealth feature and gate
2021-03-10 01:16:37 +09:00
Kubernetes Prow Robot
5404b5a28a Merge pull request #98762 from wzshiming/ut/speed-up-csi
Speed up pkg/volume/csi unit tests
2021-03-01 10:57:25 -08:00
Benjamin Elder
56e092e382 hack/update-bazel.sh 2021-02-28 15:17:29 -08:00
wzshiming
bc3d9252bc Speed up pkg/volume/csi unit tests 2021-02-27 14:09:38 +08:00
Chris Henzie
f36fec997a Poll for VolumeAttachments in CSI attacher
The CSI attacher that runs inside of the AttachDetachController has
access to a VolumeAttachment lister. By polling this lister for the
status of VolumeAttachments, we can save threads on the API server by
not using watches.
2021-02-23 16:54:18 -08:00
Chris Henzie
12e85e0e1c Extend test CSI plugin constructor to support multiple volume host types 2021-02-23 16:54:18 -08:00
phantooom
0017b602be test: add csi raw block mode wiht podinfo ut 2021-02-21 23:47:21 +08:00
phantooom
31aa15284f kubelet: fix raw block mode CSI NodePublishVolume stage miss pod info 2021-02-21 23:46:50 +08:00
drfish
d7fbf44361 Remove CSIDriverRegistry, BlockVolume and CSIBlockVolume feature flags 2021-02-19 23:40:28 +08:00
Jiawei Wang
43bc6fa806 Add csi_operations_seconds metrics on kubelet 2021-02-17 13:38:27 -08:00
Kubernetes Prow Robot
f5fb1c93db Merge pull request #96021 from huffmanca/dont-remove-volume
Dont remove volumes when saveVolumeData fails
2021-02-04 18:20:51 -08:00
pacoxu
a10bdfed09 fix all keps links 404 for kep folder migration
Signed-off-by: pacoxu <paco.xu@daocloud.io>
2021-02-01 19:41:59 +08:00
Christian Huffman
15da65d9ae Include unit test 2021-01-19 16:10:51 -05:00
Christian Huffman
df3119e815 Adjust defer to correctly call 2021-01-19 16:08:25 -05:00
fankangbest
b9afd2d34a do not remove volume dir when saveVolumeData fails 2021-01-19 15:53:10 -05:00
Chris Henzie
736b7e15b7 Remove duplicate test CSI plugin constructor logic 2021-01-06 16:32:41 -08:00
Chris Henzie
359b9e3383 Ensure CSI test plugin informers are synced before returning
This way of syncing informers ensures all informers generated from these
factories are synced. Informers are lazy loaded, and only created once a
user calls .Informer() (which was why the .PollImmediate() worked).
Asserting the number of synced types to ensure everything is set up
correctly.
2021-01-06 16:11:50 -08:00
Chris Henzie
257704b30d Remove setupInformer argument from test CSI plugin constructor 2021-01-06 16:11:50 -08:00
Chris Henzie
70eddfefec Ensure goroutines exit in CSI attacher tests
The reason for adding an expectedVolumeHost field is to prevent a
channel read from hanging when a test fails prior to creating the
VolumeAttachment watch.
2021-01-06 16:11:50 -08:00
Chris Henzie
f098ada9d1 Extract watch reactor out of test CSI plugin constructor 2021-01-06 16:11:50 -08:00
Chris Henzie
195a5af23b Make volume attachment watch timeout configurable for csiAttacher 2021-01-06 16:11:39 -08:00
Chris Henzie
b4e3f272b9 Remove unused waitSleepTime field in csiAttacher 2021-01-06 15:45:56 -08:00
Kubernetes Prow Robot
07bd985724 Merge pull request #96561 from ialidzhikov/cleanup/csi-node-info
Remove CSINodeInfo feature gate
2021-01-05 11:46:00 -08:00
Chris Henzie
9d8f994d4e Separate test Kubelet and AttachDetach VolumeHost types
fakeVolumeHost previously implemented both the KubeletVolumeHost and
AttachDetachVolumeHost interfaces. This design makes it difficult to test the
CSIAttacher since it behaves differently depending on what type of
VolumeHost is supplied.
2020-12-17 15:17:04 -08:00
ialidzhikov
bc432124a2 Remove CSINodeInfo feature gate
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-12-10 09:58:22 +02:00
Christian Huffman
4d2d063635 Included e2e test for CSIDriver FSGroupPolicy 2020-11-12 16:30:38 -05:00
Christian Huffman
01f70d69b7 Move CSIVolumeFSGroupPolicy to beta 2020-11-12 16:28:54 -05:00
Shihang Zhang
d2859cd89b plumb service account token down to csi driver 2020-11-12 09:26:43 -08:00
Kubernetes Prow Robot
2b4be7bb5f Merge pull request #88759 from andyzhangx/csi-dir-fix
feat: ignore mount dir check in csi node stage/publish
2020-11-09 16:08:40 -08:00
Jan Safranek
9a765f8c2d Restore staging path creation
CSI says about NodeStage (=MountDevice):
// The CO SHALL ensure [...]
// that the path is directory and that the process serving the
// request has `read` and `write` permission to that directory. The
// CO SHALL be responsible for creating the directory if it does not
// exist.
2020-11-09 19:22:29 +01:00
Jan Safranek
55ffd9d5fc Add unit test for staging path creation 2020-11-09 19:22:25 +01:00
jornshen
db53ca01da change plugin name in fsgroupapplymetrics of csi and flexvolume to
distinguish different driver
2020-11-04 16:28:28 +08:00
jornshen
4ed7709774 Report a metric for time taken to perform recursive permission change 2020-10-26 21:04:30 +08:00
Kubernetes Prow Robot
0b8c2bf1a1 Merge pull request #94735 from mikedanese/flake
test flake: fix data race in csi_test.go
2020-09-22 12:24:01 -07:00
Srini Brahmaroutu
fbe5daed73 Change code to use staging/k8s.io/mount-utils 2020-09-16 21:51:24 -07:00
knight42
e89e72b637 test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-09-15 16:02:35 +08:00
Mike Danese
94f4f06d13 test flake: fix data race in csi_test.go
The attach goroutine can currently t.Log/t.Error during or after the
subtest completion. This causes races like:

```
==================
WARNING: DATA RACE
Read at 0x00c000e90ac3 by goroutine 1231:
  testing.(*common).logDepth()
      GOROOT/src/testing/testing.go:736 +0xa9
  testing.(*common).log()
      GOROOT/src/testing/testing.go:729 +0x8f
  testing.(*common).Logf()
      GOROOT/src/testing/testing.go:775 +0x21
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21.1()
      pkg/volume/csi/csi_test.go:313 +0x1a4
Previous write at 0x00c000e90ac3 by goroutine 875:
  testing.tRunner.func1()
      GOROOT/src/testing/testing.go:1113 +0x484
  testing.tRunner()
      GOROOT/src/testing/testing.go:1131 +0x22a
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 1231 (running) created at:
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21()
      pkg/volume/csi/csi_test.go:307 +0xf05
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 875 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1178 +0x796
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll()
      pkg/volume/csi/csi_test.go:223 +0xb2c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
==================
```

See also this comment:

07c1788357/src/testing/testing.go (L1141-L1142)

Noticed in:

https://github.com/kubernetes/kubernetes/pull/94449
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/94449/pull-kubernetes-bazel-test/1304519003330318337
2020-09-11 22:19:42 -07:00
Kubernetes Prow Robot
30a9b8b126 Merge pull request #94389 from pacoxu/fix/94378
add lock for csi node update
2020-09-09 06:36:07 -07:00