Commit Graph

6547 Commits

Author SHA1 Message Date
Michal Wozniak
4250d444f8 Cleanup Job controller tests 2024-07-05 14:59:03 +02:00
lukashankeln
58c44005cd fix(cronjob): lastSuccessfullTime not set when successfulJobsHistoryLimit equal to zero (#122025)
* fix(cronjob): lastSuccessfullTime not set when successfulJobsHistoryLimit equal to zero

* fix(cronjob): added tests for successfulJobsHistoryLimit mutations
2024-07-05 03:57:47 -07:00
Kubernetes Prow Robot
11c689b945 Merge pull request #125675 from tnqn/fix-rapid-endpoints-update
Fix endpoints status out-of-sync when the pod state changes rapidly
2024-07-02 23:48:42 -07:00
Kubernetes Prow Robot
6a0aeb2adb Merge pull request #125151 from skitt/drop-ptr-wrappers-pkg-controller
pkg/controller: drop pointer wrapper functions
2024-07-02 09:28:00 -07:00
Stephen Kitt
f55b59fc02 pkg/controller: drop pointer wrapper functions
The new k8s.io/utils/ptr package provides generic wrapper functions,
which can be used instead of type-specific pointer wrapper functions.
This replaces the latter with the former, and migrates other uses of
the deprecated pointer package to ptr in affected files.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2024-07-02 16:19:12 +02:00
Quan Tian
3bd975862a Fix endpoints status out-of-sync when the pod state changes rapidly
When Pod state changes rapidly, endpoints controller may use outdated
informer cache to sync Service. If the outdated endpoints appear to be
expected by the controller, it skips updating it.

The commit fixes it by checking if endpoints informer cache is outdated
when processing a service. If the endpoints is stale, it returns an
error and retries later.

Signed-off-by: Quan Tian <quan.tian@broadcom.com>
2024-07-01 21:56:36 +08:00
Kubernetes Prow Robot
93d56511e6 Merge pull request #125021 from aojea/servicecidrbeta
KEP-1880 Multiple Service CIDRs: Graduate to Beta (2/2)
2024-06-30 08:53:25 -07:00
Antonio Ojea
0e1f9dadd6 modify components to use the networking v1beta1 API 2024-06-30 09:48:46 +00:00
Kubernetes Prow Robot
ac9aec9f9b Merge pull request #125116 from pohly/dra-one-of-source
DRA: remove "source" indirection from v1 Pod API
2024-06-28 12:46:45 -07:00
Matthieu MOREL
0cde5f1e28 fix: enable bool-compare rule from testifylint linter (#125135)
* fix: enable bool-compare rule from testifylint linter

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update hack/golangci.yaml.in

Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>

* Update golangci.yaml.in

* Update golangci-strict.yaml

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml

* Update golangci-hints.yaml

* Update golangci-strict.yaml

* Update golangci.yaml.in

* Update golangci.yaml

* Update mux_test.go

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
2024-06-28 10:58:05 -07:00
Patrick Ohly
bde9b64cdf DRA: remove "source" indirection from v1 Pod API
This makes the API nicer:

    resourceClaims:
    - name: with-template
      resourceClaimTemplateName: test-inline-claim-template
    - name: with-claim
      resourceClaimName: test-shared-claim

Previously, this was:

    resourceClaims:
    - name: with-template
      source:
        resourceClaimTemplateName: test-inline-claim-template
    - name: with-claim
      source:
        resourceClaimName: test-shared-claim

A more long-term benefit is that other, future alternatives
might not make sense under the "source" umbrella.

This is a breaking change. It's justified because DRA is still
alpha and will have several other API breaks in 1.31.
2024-06-27 17:53:24 +02:00
Antonio Ojea
b5cfccbca7 replace iptree on the servicecidr controller 2024-06-27 11:33:36 +00:00
Kubernetes Prow Robot
92e0db2bbf Merge pull request #125640 from googs1025/resourceclaim_controller_log_fix1
added resourceclaim_controller log info
2024-06-27 03:20:10 -07:00
googs1025
5f8fb17652 added resourceclaim_controller log info
Signed-off-by: googs1025 <googs1025@gmail.com>
2024-06-26 18:38:11 +08:00
Patrick Ohly
2da9e660e3 resourceclaim controller: add missing log output
The logging was fairly complete about *not* doing something, but the actual
ResourceClaim creation was not logged.
2024-06-25 16:12:31 +02:00
Kubernetes Prow Robot
0d17892740 Merge pull request #123184 from googs1025/delete_repeat_comments
typo: delete useless comments
2024-06-24 16:48:32 -07:00
Kubernetes Prow Robot
fb6bbc9781 Merge pull request #125359 from yangjunmyfm192085/fixendpointslicemirroring
fix endpointslicemirroring controller not create endpointslice when the endpoints are recreate
2024-06-23 18:22:55 -07:00
杨军10092085
811bd53ee7 fix endpointslicemirroring controller not create endpointslice when the endpoints are recreate 2024-06-22 10:05:03 +08:00
Michal Wozniak
7b5d3f5bc1 Assert on all conditions in the Pod Failure policy tests 2024-06-21 15:42:14 +02:00
Dejan Zele Pejchev
11b6e4c404 count ready pods when deleting active pods for failed jobs 2024-06-21 01:07:40 +02:00
Kubernetes Prow Robot
cc2946e5d1 Merge pull request #125515 from mimowo/refactor-terminating-counter
Refactor tracking of terminating pods in Job controller
2024-06-20 13:01:41 -07:00
Michal Wozniak
c12bcf4e94 Refactor enactJobFinished util function for Job controller 2024-06-20 13:02:54 +02:00
Michal Wozniak
8cec2c7470 Refactor tracking of terminating pods in Job controller 2024-06-20 09:35:56 +02:00
Kubernetes Prow Robot
aeed1d0e1a Merge pull request #124842 from carlory/honor-pv-reclaim-policy-e2e
Promote HonorPVReclaimPolicy to beta and enable it by default
2024-06-19 13:26:41 -07:00
carlory
4058178b8c Promote HonorPVReclaimPolicy to beta and enable it by default 2024-06-19 13:51:37 +08:00
Kubernetes Prow Robot
bd88faee8b Merge pull request #125520 from mimowo/cleanup-success-policy-check
Remove redundant check in Job success policy code
2024-06-18 12:40:09 -07:00
Michal Wozniak
7a3d73d234 Remove redundant check in Job success policy code 2024-06-14 19:59:40 +02:00
Michal Wozniak
18a14bcff9 Remove unused parameter in Job controller function 2024-06-14 19:43:19 +02:00
Kubernetes Prow Robot
eda1c78054 Merge pull request #125445 from mimowo/prepare-gc-controller-test
Cleanup gc_controller tests to do not use deprecated types
2024-06-12 10:04:37 -07:00
Michal Wozniak
150b255962 Cleanup gc_controller tests to do not use deprecated types 2024-06-12 10:16:48 +02:00
Yuki Iwai
be3316e2e1 Job: Fix a bug that the SuccessCriteriaMet condition is added to the Job with successPolicy even if the JobSuccessPolicy featureGate is disabled
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-06-12 00:36:36 +09:00
Kubernetes Prow Robot
c49b140c45 Merge pull request #125175 from dejanzele/feat/count-terminating-for-failed-jobs
Count terminating pods when deleting active pods for failed jobs
2024-06-10 16:56:37 -07:00
Kubernetes Prow Robot
c6b5191c37 Merge pull request #122499 from mattcary/oref
Respect controllers on PVCs for retention policy
2024-06-07 09:33:04 -07:00
Kubernetes Prow Robot
cfd949e321 Merge pull request #124942 from AxeZhan/getFinishTimeFromContainers
[Sidecar Containers] Sidecar containers finish time needs to be accounted for in job controller
2024-06-06 12:23:05 -07:00
Davanum Srinivas
60fe406f67 remove vestiges of providerless tag
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2024-06-06 12:18:38 -04:00
Dejan Pejchev
01536f5a84 add additional tests to make sure job controller logic is correct when counting terminating pods with enabled and disabled PodReplacementPolicy feature 2024-06-06 11:40:54 +02:00
AxeZhan
d97282052e check sidecar featuregate in getFinishedTime 2024-06-06 15:46:41 +08:00
Matthew Cary
d386d6880e Respect controllers on PVCs for retention policy 2024-06-05 12:06:41 -07:00
Kubernetes Prow Robot
d8b33e32b1 Merge pull request #125168 from kaisoz/jobreadypods-fg-removal
Remove the `JobReadyPods` feature flag
2024-06-05 11:36:58 -07:00
Kubernetes Prow Robot
7e88a33c7b Merge pull request #120396 from wangwei10061/master
Fix wrong annotations in defaults.go
2024-06-04 12:53:19 -07:00
Dejan Pejchev
7dd2948620 count terminating pods when deleting active pods for failed jobs 2024-06-04 11:31:00 +02:00
hbostan
db827e67fc Add a new workqueue to endpointslice controller for updating topology
cache and checking node topology distribution.
2024-06-04 08:33:32 +00:00
Kubernetes Prow Robot
1ebc3d2a64 Merge pull request #120699 from liyuerich/ptrderefcontroller
drop deprecated pointer package in controller
2024-05-29 10:12:36 -07:00
Kubernetes Prow Robot
da02fdb2ae Merge pull request #123339 from skitt/canonical-json-patch
Update kustomize, use canonical json-patch v4 import
2024-05-29 08:02:24 -07:00
Stephen Kitt
5300466a5c Use canonical json-patch v4 import
The canonical import for json-patch v4 is
gopkg.in/evanphx/json-patch.v4 (see
https://github.com/evanphx/json-patch/blob/master/README.md#get-it for
reference).

Using the v4-specific path should also reduce the risk of unwanted v5
upgrade attempts, because they won't be offered as automated upgrades
by dependency upgrade management tools, and they won't happen through
indirect dependencies (see
https://github.com/kubernetes/kubernetes/pull/120327 for context).

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2024-05-28 10:48:22 +02:00
Tomas Tormo
ce56b2ca58 Remove JobReadyPods feature flag 2024-05-27 13:09:52 +00:00
carlory
214287b370 kube-controller-manager removed deprecated command flags: --volume-host-cidr-denylist and --volume-host-allow-local-loopback 2024-05-27 10:59:09 +08:00
AxeZhan
3a2a500182 check restartpolicy in getFinishTimeFromContainers 2024-05-21 11:58:06 +08:00
AxeZhan
e4348a1210 consider sidecar containers in getFinishTimeFromContainers 2024-05-20 18:31:23 +08:00
SataQiu
4bd3baece3 kube-controller-manager: remove the deprecated horizontal-pod-autoscaler-upscale-delay and horizontal-pod-autoscaler-downscale-delay flags 2024-05-19 17:49:23 +08:00